[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 4/4] hw/i386: Introduce the microvm machine t
|
From: |
Gerd Hoffmann |
|
Subject: |
Re: [Qemu-devel] [PATCH v3 4/4] hw/i386: Introduce the microvm machine type |
|
Date: |
Tue, 2 Jul 2019 15:58:25 +0200 |
|
User-agent: |
NeoMutt/20180716 |
Hi,
> +#define MICROVM_MAX_BELOW_4G 0xe0000000
> +
> +/* Platform virtio definitions */
> +#define VIRTIO_MMIO_BASE 0xd0000000
That isn't going to fly ...
I'd also suggest to add a microvm.txt file to docs/ with specification
(io memory, io ports, memory layout in pvh mode, in firmware mode, ...)
and usage information.
cut & paste the bits sprinkled all over in commit messages and cover
letter would be a good start.
cheers,
Gerd
- [Qemu-devel] [PATCH v3 0/4] Introduce the microvm machine type, Sergio Lopez, 2019/07/02
- [Qemu-devel] [PATCH v3 2/4] hw/i386: Add an Intel MPTable generator, Sergio Lopez, 2019/07/02
- [Qemu-devel] [PATCH v3 3/4] hw/i386: Factorize PVH related functions, Sergio Lopez, 2019/07/02
- [Qemu-devel] [PATCH v3 4/4] hw/i386: Introduce the microvm machine type, Sergio Lopez, 2019/07/02
- Re: [Qemu-devel] [PATCH v3 0/4] Introduce the microvm machine type, no-reply, 2019/07/02
- Re: [Qemu-devel] [PATCH v3 0/4] Introduce the microvm machine type, Peter Maydell, 2019/07/02
- Re: [Qemu-devel] [PATCH v3 0/4] Introduce the microvm machine type, Sergio Lopez, 2019/07/02
- Re: [Qemu-devel] [PATCH v3 0/4] Introduce the microvm machine type, Peter Maydell, 2019/07/02
- Re: [Qemu-devel] [PATCH v3 0/4] Introduce the microvm machine type, Sergio Lopez, 2019/07/02
- Re: [Qemu-devel] [PATCH v3 0/4] Introduce the microvm machine type, Michael S. Tsirkin, 2019/07/25
- Re: [Qemu-devel] [PATCH v3 0/4] Introduce the microvm machine type, Peter Maydell, 2019/07/25
- Re: [Qemu-devel] [PATCH v3 0/4] Introduce the microvm machine type, Michael S. Tsirkin, 2019/07/25
- Re: [Qemu-devel] [PATCH v3 0/4] Introduce the microvm machine type, Sergio Lopez, 2019/07/25