Re: [Qemu-devel] [RFC PATCH 0/7] target/i386: support VMX features in "-cpu"

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Subject: [Qemu-devel] [RFC PATCH 0/7] target/i386: support VMX features in 
"-cpu"
Message-id: address@hidden

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Switched to a new branch 'test'
d88c7eb target/i386: work around KVM_GET_MSRS bug for secondary execution 
controls
c5362c7 target/i386: add VMX features
8b2be4b vmxcap: correct the name of the variables
b85f895 target/i386: add VMX definitions
3962d04 target/i386: expand feature words to 64 bits
cbeb933 target/i386: introduce generic feature dependency mechanism
9fd6230 target/i386: handle filtered_features in a new function 
mark_unavailable_features

=== OUTPUT BEGIN ===
1/7 Checking commit 9fd62303df59 (target/i386: handle filtered_features in a 
new function mark_unavailable_features)
ERROR: suspect code indent for conditional statements (4, 9)
#27: FILE: target/i386/cpu.c:3243:
+    for (w = 0; w < ARRAY_SIZE(feature_word_info); w++) {
+         if (cpu->filtered_features[w]) {

ERROR: suspect code indent for conditional statements (9, 13)
#28: FILE: target/i386/cpu.c:3244:
+         if (cpu->filtered_features[w]) {
+             return true;

WARNING: line over 80 characters
#121: FILE: target/i386/cpu.c:5225:
+            mark_unavailable_features(cpu, FEAT_7_0_EBX, 
CPUID_7_0_EBX_INTEL_PT, prefix);

total: 2 errors, 1 warnings, 130 lines checked

Patch 1/7 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

2/7 Checking commit cbeb933580d4 (target/i386: introduce generic feature 
dependency mechanism)
WARNING: line over 80 characters
#69: FILE: target/i386/cpu.c:1223:
+        .from = FEAT_7_0_EDX,            .from_flag = 
CPUID_7_0_EDX_ARCH_CAPABILITIES,

WARNING: line over 80 characters
#73: FILE: target/i386/cpu.c:1227:
+        .from = FEAT_7_0_EDX,            .from_flag = 
CPUID_7_0_EDX_CORE_CAPABILITY,

WARNING: line over 80 characters
#111: FILE: target/i386/cpu.c:5119:
+            /* Not an error unless the dependent feature was added explicitly. 
 */

ERROR: line over 90 characters
#112: FILE: target/i386/cpu.c:5120:
+            mark_unavailable_features(cpu, d->to, unavailable_features & 
env->user_features[d->to],

total: 1 errors, 3 warnings, 114 lines checked

Patch 2/7 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

3/7 Checking commit 3962d049bcf1 (target/i386: expand feature words to 64 bits)
WARNING: line over 80 characters
#130: FILE: target/i386/cpu.c:3616:
+    assert(bitnr < 32 || !(name && feature_word_info[w].type == 
CPUID_FEATURE_WORD));

total: 0 errors, 1 warnings, 214 lines checked

Patch 3/7 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
4/7 Checking commit b85f8959ed62 (target/i386: add VMX definitions)
5/7 Checking commit 8b2be4b559cb (vmxcap: correct the name of the variables)
6/7 Checking commit c5362c7576b9 (target/i386: add VMX features)
ERROR: line over 90 characters
#32: FILE: target/i386/cpu.c:1223:
+            "vmx-cr8-store-exit", "vmx-flexpriority", "vmx-vnmi-pending", 
"vmx-movdr-exit",

WARNING: line over 80 characters
#34: FILE: target/i386/cpu.c:1225:
+            "vmx-msr-bitmap", "vmx-monitor-exit", "vmx-pause-exit", 
"vmx-secondary-ctls",

WARNING: line over 80 characters
#45: FILE: target/i386/cpu.c:1236:
+            "vmx-apicv-x2apic", "vmx-vpid", "vmx-wbinvd-exit", 
"vmx-unrestricted-guest",

WARNING: line over 80 characters
#47: FILE: target/i386/cpu.c:1238:
+            "vmx-invpcid-exit", "vmx-vmfunc", "vmx-shadow-vmcs", 
"vmx-encls-exit",

WARNING: Block comments use a leading /* on a separate line
#84: FILE: target/i386/cpu.c:1275:
+            NULL, NULL /* vmx-exit-host-addr-space-size */, NULL, NULL,

ERROR: line over 90 characters
#103: FILE: target/i386/cpu.c:1294:
+            NULL, "vmx-entry-load-perf-global-ctrl", "vmx-entry-load-pat", 
"vmx-entry-load-efer",

WARNING: line over 80 characters
#145: FILE: target/i386/cpu.c:1336:
+                "vmx-invvpid-all-context", 
"vmx-invept-single-context-noglobals",

WARNING: line over 80 characters
#166: FILE: target/i386/cpu.c:1357:
+        /* Just to be safe - we don't support setting the MSEG version field.  
*/

ERROR: line over 90 characters
#216: FILE: target/i386/cpu.c:1416:
+        .from = FEAT_VMX_PROCBASED_CTLS, .from_flag = 
VMX_CPU_BASED_ACTIVATE_SECONDARY_CONTROLS,

WARNING: line over 80 characters
#225: FILE: target/i386/cpu.c:1425:
+        .to = FEAT_VMX_SECONDARY_CTLS,   .to_flags = 
VMX_SECONDARY_EXEC_RDRAND_EXITING,

WARNING: line over 80 characters
#229: FILE: target/i386/cpu.c:1429:
+        .to = FEAT_VMX_SECONDARY_CTLS,   .to_flags = 
VMX_SECONDARY_EXEC_ENABLE_INVPCID,

WARNING: line over 80 characters
#233: FILE: target/i386/cpu.c:1433:
+        .to = FEAT_VMX_SECONDARY_CTLS,   .to_flags = 
VMX_SECONDARY_EXEC_RDSEED_EXITING,

WARNING: line over 80 characters
#240: FILE: target/i386/cpu.c:1440:
+        .from = FEAT_VMX_SECONDARY_CTLS, .from_flag = 
VMX_SECONDARY_EXEC_ENABLE_EPT,

WARNING: line over 80 characters
#244: FILE: target/i386/cpu.c:1444:
+        .from = FEAT_VMX_SECONDARY_CTLS, .from_flag = 
VMX_SECONDARY_EXEC_ENABLE_VPID,

WARNING: line over 80 characters
#248: FILE: target/i386/cpu.c:1448:
+        .from = FEAT_VMX_SECONDARY_CTLS, .from_flag = 
VMX_SECONDARY_EXEC_ENABLE_VMFUNC,

WARNING: Block comments use a leading /* on a separate line
#362: FILE: target/i386/kvm.c:2458:
+    /* If a feature bit is set, the control can be either set or clear.

WARNING: line over 80 characters
#417: FILE: target/i386/kvm.c:2513:
+            (f[FEAT_VMX_SECONDARY_CTLS] & VMX_SECONDARY_EXEC_ENABLE_EPT ? 
0x4100ull : 0);

WARNING: line over 80 characters
#428: FILE: target/i386/kvm.c:2524:
+                                         f[FEAT_VMX_EXIT_CTLS]) | 
fixed_vmx_exit);

total: 3 errors, 15 warnings, 438 lines checked

Patch 6/7 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

7/7 Checking commit d88c7eb83ef2 (target/i386: work around KVM_GET_MSRS bug for 
secondary execution controls)
WARNING: line over 80 characters
#26: FILE: target/i386/kvm.c:473:
+        if (kvm_arch_get_supported_cpuid(s, 0xD, 1, R_ECX) & 
CPUID_XSAVE_XSAVES) {

WARNING: line over 80 characters
#32: FILE: target/i386/kvm.c:479:
+        if (kvm_arch_get_supported_cpuid(s, 7, 0, R_EBX) & 
CPUID_7_0_EBX_INVPCID) {

WARNING: line over 80 characters
#35: FILE: target/i386/kvm.c:482:
+        if (kvm_arch_get_supported_cpuid(s, 7, 0, R_EBX) & 
CPUID_7_0_EBX_RDSEED) {

WARNING: line over 80 characters
#38: FILE: target/i386/kvm.c:485:
+        if (kvm_arch_get_supported_cpuid(s, 0x80000001, 0, R_EDX) & 
CPUID_EXT2_RDTSCP) {

total: 0 errors, 4 warnings, 23 lines checked

Patch 7/7 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden