[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 2/2] vfio/pci: Trace vfio_set_irq_signaling() failure
From: |
Alex Williamson |
Subject: |
[Qemu-devel] [PULL 2/2] vfio/pci: Trace vfio_set_irq_signaling() failure in vfio_msix_vector_release() |
Date: |
Tue, 02 Jul 2019 16:33:07 -0600 |
User-agent: |
StGit/0.19-dirty |
From: Eric Auger <address@hidden>
Report an error in case we fail to set a trigger action
on any VFIO_PCI_MSIX_IRQ_INDEX subindex. This might be
useful in debugging a device that is not working properly.
Signed-off-by: Eric Auger <address@hidden>
Reported-by: Coverity (CID 1402196)
Signed-off-by: Alex Williamson <address@hidden>
---
hw/vfio/pci.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c
index ce3fe96efe2c..d7a4e1875c05 100644
--- a/hw/vfio/pci.c
+++ b/hw/vfio/pci.c
@@ -551,9 +551,12 @@ static void vfio_msix_vector_release(PCIDevice *pdev,
unsigned int nr)
*/
if (vector->virq >= 0) {
int32_t fd = event_notifier_get_fd(&vector->interrupt);
+ Error *err = NULL;
- vfio_set_irq_signaling(&vdev->vbasedev, VFIO_PCI_MSIX_IRQ_INDEX, nr,
- VFIO_IRQ_SET_ACTION_TRIGGER, fd, NULL);
+ if (vfio_set_irq_signaling(&vdev->vbasedev, VFIO_PCI_MSIX_IRQ_INDEX,
nr,
+ VFIO_IRQ_SET_ACTION_TRIGGER, fd, &err)) {
+ error_reportf_err(err, VFIO_MSG_PREFIX, vdev->vbasedev.name);
+ }
}
}