Re: [Qemu-devel] [PULL v3 00/42] Machine and x86 queue, 2019-07-02

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Subject: [Qemu-devel] [PULL v3 00/42] Machine and x86 queue, 2019-07-02
Message-id: address@hidden

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
afcf402 tests: use -numa memdev option in tests instead of legacy 'mem' option
ff0f8ff numa: allow memory-less nodes when using memdev as backend
339c30f i386: Add Cascadelake-Server-v2 CPU model
9e2b740 docs: Deprecate CPU model runnability guarantees
fbb18aa i386: Make unversioned CPU models be aliases
e73a76f i386: Replace -noTSX, -IBRS, -IBPB CPU models with aliases
1e573a4 i386: Define -IBRS, -noTSX, -IBRS versions of CPU models
e186d44 i386: Register versioned CPU models
5738a52 i386: Get model-id from CPU object on "-cpu help"
08d0355 i386: Add x-force-features option for testing
0d7bab5 qmp: Add "alias-of" field to query-cpu-definitions
02d1afb i386: Introduce SnowRidge CPU model
d0c1c9b qmp: Add deprecation information to query-machines
b0b57e3 vl.c: Add -smp, dies=* command line support and update doc
929e154 machine: Refactor smp_parse() in vl.c as MachineClass::smp_parse()
a7ef198 target/i386: Add CPUID.1F generation support for multi-dies PCMachine
1cde7fe i386: Remove unused host_cpudef variable
5475570 x86/cpu: use FeatureWordArray to define filtered_features
b4450bf i386: make 'hv-spinlocks' a regular uint32 property
47b40d9 i386: Fix signedness of hyperv_spinlock_attempts
a92cece i386: Don't print warning if phys-bits was set automatically
b36eb44 deprecate -mem-path fallback to anonymous RAM
ccdf150 target/i386: fix feature check in hyperv-stub.c
22b7316 hppa: Delete unused hppa_cpu_list() function
5b34007 numa: deprecate implict memory distribution between nodes
7cf5bf9 numa: deprecate 'mem' parameter of '-numa node' option
2618aac machine: show if CLI option '-numa node, mem' is supported in QAPI 
schema
c16c6ec pc: fix possible NULL pointer dereference in 
pc_machine_get_device_memory_region_size()
8d4bc4e i386: Update new x86_apicid parsing rules with die_offset support
999969f i386/cpu: Consolidate die-id validity in smp context
ce94f15 hw/i386: Adjust nr_dies with configured smp_dies for PCMachine
dee11ed i386: Add die-level cpu topology to x86CPU on PCMachine
f3876d8 vl.c: Replace smp global variables with smp machine properties
ca2d003 hw: Replace global smp variables with MachineState for all remaining 
archs
1649cab hw/arm: Replace global smp variables with machine smp properties
79402ce hw/i386: Replace global smp variables with machine smp properties
6968db3 hw/s390x: Replace global smp variables with machine smp properties
adc2f4a hw/riscv: Replace global smp variables with machine smp properties
5a0d813 hw/ppc: Replace global smp variables with machine smp properties
76156f7 general: Replace global smp variables with smp machine properties
29b007a machine: Refactor smp-related call chains to pass MachineState
7cd89e6 hw/boards: Add struct CpuTopology to MachineState

=== OUTPUT BEGIN ===
1/42 Checking commit 7cd89e620e72 (hw/boards: Add struct CpuTopology to 
MachineState)
2/42 Checking commit 29b007a6996f (machine: Refactor smp-related call chains to 
pass MachineState)
3/42 Checking commit 76156f775dc4 (general: Replace global smp variables with 
smp machine properties)
4/42 Checking commit 5a0d813c8c1c (hw/ppc: Replace global smp variables with 
machine smp properties)
5/42 Checking commit adc2f4a22a95 (hw/riscv: Replace global smp variables with 
machine smp properties)
6/42 Checking commit 6968db3f1c81 (hw/s390x: Replace global smp variables with 
machine smp properties)
7/42 Checking commit 79402cec8400 (hw/i386: Replace global smp variables with 
machine smp properties)
8/42 Checking commit 1649cab95d4b (hw/arm: Replace global smp variables with 
machine smp properties)
9/42 Checking commit ca2d00324dd0 (hw: Replace global smp variables with 
MachineState for all remaining archs)
10/42 Checking commit f3876d88c29c (vl.c: Replace smp global variables with smp 
machine properties)
11/42 Checking commit dee11eddca30 (i386: Add die-level cpu topology to x86CPU 
on PCMachine)
12/42 Checking commit ce94f1595406 (hw/i386: Adjust nr_dies with configured 
smp_dies for PCMachine)
13/42 Checking commit 999969f8debb (i386/cpu: Consolidate die-id validity in 
smp context)
14/42 Checking commit 8d4bc4ee1ce5 (i386: Update new x86_apicid parsing rules 
with die_offset support)
15/42 Checking commit c16c6ec4e8c3 (pc: fix possible NULL pointer dereference 
in pc_machine_get_device_memory_region_size())
16/42 Checking commit 2618aacf120b (machine: show if CLI option '-numa node, 
mem' is supported in QAPI schema)
17/42 Checking commit 7cf5bf91be06 (numa: deprecate 'mem' parameter of '-numa 
node' option)
18/42 Checking commit 5b3400774fc1 (numa: deprecate implict memory distribution 
between nodes)
19/42 Checking commit 22b731615c02 (hppa: Delete unused hppa_cpu_list() 
function)
20/42 Checking commit ccdf1505e0a3 (target/i386: fix feature check in 
hyperv-stub.c)
21/42 Checking commit b36eb44ab066 (deprecate -mem-path fallback to anonymous 
RAM)
22/42 Checking commit a92cece1b216 (i386: Don't print warning if phys-bits was 
set automatically)
23/42 Checking commit 47b40d9707f5 (i386: Fix signedness of 
hyperv_spinlock_attempts)
24/42 Checking commit b4450bf4ae57 (i386: make 'hv-spinlocks' a regular uint32 
property)
25/42 Checking commit 54755705babb (x86/cpu: use FeatureWordArray to define 
filtered_features)
26/42 Checking commit 1cde7fe4ee5e (i386: Remove unused host_cpudef variable)
27/42 Checking commit a7ef1985fbc0 (target/i386: Add CPUID.1F generation 
support for multi-dies PCMachine)
28/42 Checking commit 929e154f1e54 (machine: Refactor smp_parse() in vl.c as 
MachineClass::smp_parse())
29/42 Checking commit b0b57e32a4b2 (vl.c: Add -smp, dies=* command line support 
and update doc)
30/42 Checking commit d0c1c9be918a (qmp: Add deprecation information to 
query-machines)
31/42 Checking commit 02d1afbe9481 (i386: Introduce SnowRidge CPU model)
32/42 Checking commit 0d7bab5bee5f (qmp: Add "alias-of" field to 
query-cpu-definitions)
33/42 Checking commit 08d0355ff002 (i386: Add x-force-features option for 
testing)
34/42 Checking commit 5738a52b3e2b (i386: Get model-id from CPU object on "-cpu 
help")
35/42 Checking commit e186d443197e (i386: Register versioned CPU models)
WARNING: line over 80 characters
#100: FILE: target/i386/cpu.c:1482:
+static const X86CPUVersionDefinition 
*x86_cpu_def_get_versions(X86CPUDefinition *def)

WARNING: Block comments use a leading /* on a separate line
#105: FILE: target/i386/cpu.c:1487:
+        { /* end of list */ }

WARNING: Block comments use a leading /* on a separate line
#122: FILE: target/i386/cpu.c:1883:
+        .versions = (X86CPUVersionDefinition[]) { { /* end of list */ } },

WARNING: Block comments use a leading /* on a separate line
#134: FILE: target/i386/cpu.c:1942:
+        .versions = (X86CPUVersionDefinition[]) { { /* end of list */ } },

WARNING: Block comments use a leading /* on a separate line
#146: FILE: target/i386/cpu.c:2011:
+        .versions = (X86CPUVersionDefinition[]) { { /* end of list */ } },

WARNING: Block comments use a leading /* on a separate line
#158: FILE: target/i386/cpu.c:2086:
+        .versions = (X86CPUVersionDefinition[]) { { /* end of list */ } },

WARNING: Block comments use a leading /* on a separate line
#170: FILE: target/i386/cpu.c:2127:
+        .versions = (X86CPUVersionDefinition[]) { { /* end of list */ } },

WARNING: Block comments use a leading /* on a separate line
#182: FILE: target/i386/cpu.c:2170:
+        .versions = (X86CPUVersionDefinition[]) { { /* end of list */ } },

WARNING: Block comments use a leading /* on a separate line
#194: FILE: target/i386/cpu.c:2251:
+        .versions = (X86CPUVersionDefinition[]) { { /* end of list */ } },

WARNING: Block comments use a leading /* on a separate line
#206: FILE: target/i386/cpu.c:2294:
+        .versions = (X86CPUVersionDefinition[]) { { /* end of list */ } },

WARNING: Block comments use a leading /* on a separate line
#218: FILE: target/i386/cpu.c:2339:
+        .versions = (X86CPUVersionDefinition[]) { { /* end of list */ } },

WARNING: Block comments use a leading /* on a separate line
#230: FILE: target/i386/cpu.c:2422:
+        .versions = (X86CPUVersionDefinition[]) { { /* end of list */ } },

WARNING: Block comments use a leading /* on a separate line
#242: FILE: target/i386/cpu.c:2519:
+        .versions = (X86CPUVersionDefinition[]) { { /* end of list */ } },

WARNING: Block comments use a leading /* on a separate line
#254: FILE: target/i386/cpu.c:2626:
+        .versions = (X86CPUVersionDefinition[]) { { /* end of list */ } },

WARNING: Block comments use a leading /* on a separate line
#266: FILE: target/i386/cpu.c:3139:
+        .versions = (X86CPUVersionDefinition[]) { { /* end of list */ } },

WARNING: line over 80 characters
#333: FILE: target/i386/cpu.c:4117:
+    for (vdef = x86_cpu_def_get_versions(model->cpudef); vdef->version; 
vdef++) {

WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#509: 
new file mode 100644

ERROR: line over 90 characters
#552: FILE: tests/acceptance/x86_cpu_model_versions.py:39:
+                              '%s.alias-of (%s) is not a valid CPU model name' 
% (c['name'], c['alias-of']))

ERROR: line over 90 characters
#555: FILE: tests/acceptance/x86_cpu_model_versions.py:42:
+                                 '%s.alias-of (%s) points to another alias' % 
(c['name'], c['alias-of']))

WARNING: line over 80 characters
#591: FILE: tests/acceptance/x86_cpu_model_versions.py:78:
+        """Check if pc-*-4.0 unversioned CPU model won't be reported as 
aliases"""

WARNING: line over 80 characters
#598: FILE: tests/acceptance/x86_cpu_model_versions.py:85:
+        cpus = dict((m['name'], m) for m in 
self.vm.command('query-cpu-definitions'))

WARNING: line over 80 characters
#601: FILE: tests/acceptance/x86_cpu_model_versions.py:88:
+                         'unversioned Cascadelake-Server CPU model must not be 
static')

total: 2 errors, 20 warnings, 550 lines checked

Patch 35/42 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

36/42 Checking commit 1e573a4ff537 (i386: Define -IBRS, -noTSX, -IBRS versions 
of CPU models)
WARNING: Block comments use a leading /* on a separate line
#36: FILE: target/i386/cpu.c:1863:
+                    { /* end of list */ }

WARNING: Block comments use a leading /* on a separate line
#39: FILE: target/i386/cpu.c:1866:
+            { /* end of list */ }

WARNING: Block comments use a leading /* on a separate line
#57: FILE: target/i386/cpu.c:1933:
+                    { /* end of list */ }

WARNING: Block comments use a leading /* on a separate line
#60: FILE: target/i386/cpu.c:1936:
+            { /* end of list */ }

WARNING: Block comments use a leading /* on a separate line
#78: FILE: target/i386/cpu.c:2011:
+                    { /* end of list */ }

WARNING: Block comments use a leading /* on a separate line
#81: FILE: target/i386/cpu.c:2014:
+            { /* end of list */ }

WARNING: Block comments use a leading /* on a separate line
#99: FILE: target/i386/cpu.c:2097:
+                    { /* end of list */ }

WARNING: Block comments use a leading /* on a separate line
#102: FILE: target/i386/cpu.c:2100:
+            { /* end of list */ }

WARNING: Block comments use a leading /* on a separate line
#121: FILE: target/i386/cpu.c:2274:
+                    { /* end of list */ }

WARNING: Block comments use a leading /* on a separate line
#139: FILE: target/i386/cpu.c:2292:
+                    { /* end of list */ }

WARNING: Block comments use a leading /* on a separate line
#152: FILE: target/i386/cpu.c:2305:
+                    { /* end of list */ }

WARNING: Block comments use a leading /* on a separate line
#155: FILE: target/i386/cpu.c:2308:
+            { /* end of list */ }

WARNING: Block comments use a leading /* on a separate line
#173: FILE: target/i386/cpu.c:2489:
+                    { /* end of list */ }

WARNING: Block comments use a leading /* on a separate line
#186: FILE: target/i386/cpu.c:2502:
+                    { /* end of list */ }

WARNING: Block comments use a leading /* on a separate line
#198: FILE: target/i386/cpu.c:2514:
+                    { /* end of list */ }

WARNING: Block comments use a leading /* on a separate line
#201: FILE: target/i386/cpu.c:2517:
+            { /* end of list */ }

WARNING: Block comments use a leading /* on a separate line
#219: FILE: target/i386/cpu.c:2618:
+                    { /* end of list */ }

WARNING: Block comments use a leading /* on a separate line
#222: FILE: target/i386/cpu.c:2621:
+            { /* end of list */ }

WARNING: Block comments use a leading /* on a separate line
#243: FILE: target/i386/cpu.c:2737:
+                    { /* end of list */ }

WARNING: Block comments use a leading /* on a separate line
#246: FILE: target/i386/cpu.c:2740:
+            { /* end of list */ }

WARNING: Block comments use a leading /* on a separate line
#264: FILE: target/i386/cpu.c:3266:
+                    { /* end of list */ }

WARNING: Block comments use a leading /* on a separate line
#267: FILE: target/i386/cpu.c:3269:
+            { /* end of list */ }

total: 0 errors, 22 warnings, 240 lines checked

Patch 36/42 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
37/42 Checking commit e73a76fd3f07 (i386: Replace -noTSX, -IBRS, -IBPB CPU 
models with aliases)
38/42 Checking commit fbb18aaa23a5 (i386: Make unversioned CPU models be 
aliases)
WARNING: line over 80 characters
#267: FILE: tests/acceptance/x86_cpu_model_versions.py:108:
+        """Check if unversioned CPU model is an alias pointing to right 
version"""

WARNING: line over 80 characters
#272: FILE: tests/acceptance/x86_cpu_model_versions.py:113:
+        cpus = dict((m['name'], m) for m in 
self.vm.command('query-cpu-definitions'))

WARNING: line over 80 characters
#275: FILE: tests/acceptance/x86_cpu_model_versions.py:116:
+                         'unversioned Cascadelake-Server CPU model must not be 
static')

ERROR: line over 90 characters
#276: FILE: tests/acceptance/x86_cpu_model_versions.py:117:
+        self.assertEquals(cpus['Cascadelake-Server'].get('alias-of'), 
'Cascadelake-Server-v1',

WARNING: line over 80 characters
#277: FILE: tests/acceptance/x86_cpu_model_versions.py:118:
+                          'Cascadelake-Server must be an alias of 
Cascadelake-Server-v1')

WARNING: line over 80 characters
#369: FILE: tests/acceptance/x86_cpu_model_versions.py:210:
+        """Check if unversioned CPU model is an alias pointing to some 
version"""

WARNING: line over 80 characters
#374: FILE: tests/acceptance/x86_cpu_model_versions.py:215:
+        cpus = dict((m['name'], m) for m in 
self.vm.command('query-cpu-definitions'))

WARNING: line over 80 characters
#377: FILE: tests/acceptance/x86_cpu_model_versions.py:218:
+                         'unversioned Cascadelake-Server CPU model must not be 
static')

ERROR: line over 90 characters
#378: FILE: tests/acceptance/x86_cpu_model_versions.py:219:
+        self.assertTrue(re.match('Cascadelake-Server-v[0-9]+', 
cpus['Cascadelake-Server']['alias-of']),

WARNING: line over 80 characters
#379: FILE: tests/acceptance/x86_cpu_model_versions.py:220:
+                        'Cascadelake-Server must be an alias of versioned CPU 
model')

total: 2 errors, 8 warnings, 319 lines checked

Patch 38/42 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

39/42 Checking commit 9e2b74045cc1 (docs: Deprecate CPU model runnability 
guarantees)
40/42 Checking commit 339c30f18365 (i386: Add Cascadelake-Server-v2 CPU model)
WARNING: Block comments use a leading /* on a separate line
#45: FILE: target/i386/cpu.c:2355:
+                  { /* end of list */ }

WARNING: Block comments use a leading /* on a separate line
#48: FILE: target/i386/cpu.c:2358:
+            { /* end of list */ }

ERROR: line over 90 characters
#78: FILE: tests/acceptance/x86_cpu_model_versions.py:242:
+        vm.add_args('-cpu', 
'Cascadelake-Server,x-force-features=on,check=off,enforce=off')

ERROR: line over 90 characters
#81: FILE: tests/acceptance/x86_cpu_model_versions.py:245:
+                         'pc-i440fx-4.1 + Cascadelake-Server should not have 
arch-capabilities')

ERROR: line over 90 characters
#86: FILE: tests/acceptance/x86_cpu_model_versions.py:250:
+        vm.add_args('-cpu', 
'Cascadelake-Server,x-force-features=on,check=off,enforce=off')

ERROR: line over 90 characters
#89: FILE: tests/acceptance/x86_cpu_model_versions.py:253:
+                         'pc-i440fx-4.0 + Cascadelake-Server should not have 
arch-capabilities')

ERROR: line over 90 characters
#95: FILE: tests/acceptance/x86_cpu_model_versions.py:259:
+        vm.add_args('-cpu', 
'Cascadelake-Server,x-force-features=on,check=off,enforce=off,+arch-capabilities')

ERROR: line over 90 characters
#98: FILE: tests/acceptance/x86_cpu_model_versions.py:262:
+                        'pc-i440fx-4.0 + Cascadelake-Server,+arch-capabilities 
should have arch-capabilities')

ERROR: line over 90 characters
#103: FILE: tests/acceptance/x86_cpu_model_versions.py:267:
+        vm.add_args('-cpu', 
'Cascadelake-Server,x-force-features=on,check=off,enforce=off,-arch-capabilities')

ERROR: line over 90 characters
#106: FILE: tests/acceptance/x86_cpu_model_versions.py:270:
+                         'pc-i440fx-4.1 + 
Cascadelake-Server,-arch-capabilities should not have arch-capabilities')

ERROR: line over 90 characters
#112: FILE: tests/acceptance/x86_cpu_model_versions.py:276:
+        vm.add_args('-cpu', 
'Cascadelake-Server-v1,x-force-features=on,check=off,enforce=off')

ERROR: line over 90 characters
#115: FILE: tests/acceptance/x86_cpu_model_versions.py:279:
+                         'pc-i440fx-4.1 + Cascadelake-Server-v1 should not 
have arch-capabilities')

ERROR: line over 90 characters
#120: FILE: tests/acceptance/x86_cpu_model_versions.py:284:
+        vm.add_args('-cpu', 
'Cascadelake-Server-v2,x-force-features=on,check=off,enforce=off')

ERROR: line over 90 characters
#123: FILE: tests/acceptance/x86_cpu_model_versions.py:287:
+                         'pc-i440fx-4.1 + Cascadelake-Server-v1 should have 
arch-capabilities')

ERROR: line over 90 characters
#129: FILE: tests/acceptance/x86_cpu_model_versions.py:293:
+        vm.add_args('-cpu', 
'Cascadelake-Server,x-force-features=on,check=off,enforce=off,+arch-capabilities')

ERROR: line over 90 characters
#132: FILE: tests/acceptance/x86_cpu_model_versions.py:296:
+                         'pc-i440fx-4.0 + 
Cascadelake-Server-v1,+arch-capabilities should have arch-capabilities')

ERROR: line over 90 characters
#137: FILE: tests/acceptance/x86_cpu_model_versions.py:301:
+        vm.add_args('-cpu', 
'Cascadelake-Server-v2,x-force-features=on,check=off,enforce=off,-arch-capabilities')

ERROR: line over 90 characters
#140: FILE: tests/acceptance/x86_cpu_model_versions.py:304:
+                         'pc-i440fx-4.1 + 
Cascadelake-Server-v2,-arch-capabilities should not have arch-capabilities')

total: 16 errors, 2 warnings, 102 lines checked

Patch 40/42 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

41/42 Checking commit ff0f8ff6fe84 (numa: allow memory-less nodes when using 
memdev as backend)
42/42 Checking commit afcf402bad12 (tests: use -numa memdev option in tests 
instead of legacy 'mem' option)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden