[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] monitor: vnc: Fix compilation error if CONFIG_V
|
From: |
Stefano Garzarella |
|
Subject: |
Re: [Qemu-devel] [PATCH] monitor: vnc: Fix compilation error if CONFIG_VNC is disable |
|
Date: |
Wed, 3 Jul 2019 10:21:59 +0200 |
|
User-agent: |
NeoMutt/20180716 |
On Tue, Jul 02, 2019 at 07:01:31PM +0000, Julio Montes wrote:
> How to reproduce it?
> ===
>
> ```
> $ ./configure --disable-spice --disable-vte --disable-vnc \
> --disable-vnc-jpeg --disable-vnc-png --disable-vnc-sasl
> $ make
> ...
> monitor/hmp-cmds.c: In function ‘hmp_change’:
> monitor/hmp-cmds.c:1985:17: error: unused variable ‘hmp_mon’
> [-Werror=unused-variable]
> MonitorHMP *hmp_mon = container_of(mon, MonitorHMP, common);
> ```
>
> Fix
> ===
>
> Move `hmp_mon` variable within the `CONFIG_VNC` block
>
Hi Julio,
thanks for the patch, but Christophe sent a very similar patch last
week: https://patchew.org/QEMU/address@hidden/
Cheers,
Stefano