Re: [Qemu-devel] [PATCH v7 0/4] rng-builtin: add an RNG backend that uses qemu_guest_getrandom()

[Laurent Vivier]

On 03/07/2019 16:23, Amit Shah wrote:
> On Tue, 2019-07-02 at 18:48 +0200, Laurent Vivier wrote:
>> On 02/07/2019 15:21, Michael S. Tsirkin wrote:
>>> On Wed, May 29, 2019 at 04:31:02PM +0200, Laurent Vivier wrote:
>>>> Add a new RNG backend using QEMU builtin getrandom function.
>>>>
>>>> v7: rebase on master
>>>>     Make rng-builtin asynchronous with QEMUBH (removed existing
>>>> R-b)
>>>>
>>>> v6: remove "sysemu/rng-random.h" from virtio-rng.c
>>>>     rebase on qemu_getrandom v8
>>>>
>>>> v5: PATCH 1 s/linux/Linux/
>>>>     remove superfluous includes from rng-builtin.c
>>>>     don't update rng-random documentation
>>>>     add a patch from Markus to keep the default backend out of
>>>> VirtIORNGConf
>>>>     move TYPE_RNG_BUILTIN to sysemu/rng.h and remove sysemu/rng-
>>>> builtin.h
>>>>
>>>> v4: update PATCH 1 commit message
>>>>
>>>> v3: Include Kashyap's patch in the series
>>>>     Add a patch to change virtio-rng default backend to rng-
>>>> builtin
>>>>
>>>> v2: Update qemu-options.hx
>>>>     describe the new backend and specify virtio-rng uses the
>>>>     rng-random by default
>>>
>>>
>>> Reviewed-by: Michael S. Tsirkin <address@hidden>
>>>
>>> feel free to merge.
>>
>> Thank you Michael.
>>
>> I've already included PATCH 1 in a pull-request for trivial patches
>> branch.
>>
>> I'm not sure the other patches are good candidates for trivial
>> patches
>> branch, but is there any other maintainer that can include them in a
>> pull request (before the freeze)?
>>
>> Amit?
>> [Do you want I manage a virtio-rng pull-request for you?]
> 
> Hello Laurent,
> 
> Apologies as I haven't been around for a bit.

No problem.

> I don't mind you doing the pull req yourself if you have sufficient
> reviews.

I think it's too late to push this in 4.1., so it this will wait next
release.

>   Do you also want to consider maintaining rng yourself?

It's up to you: if you think you don't have time to maintain virtio-rng,
I can manage this.

Thanks,
Laurent