Re: [Qemu-devel] [PATCH v5 0/5] 9p: Fix file ID collisions

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Subject: [Qemu-devel] [PATCH v5 0/5] 9p: Fix file ID collisions
Message-id: address@hidden

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Switched to a new branch 'test'
0894392 9p: Use variable length suffixes for inode remapping
85bd3cf 9p: stat_to_qid: implement slow path
55ea63d 9p: Added virtfs option 'remap_inodes'
86cbf21 9p: Treat multiple devices on one export as an error
d864b5a 9p: unsigned type for type, version, path

=== OUTPUT BEGIN ===
1/5 Checking commit d864b5ad19ff (9p: unsigned type for type, version, path)
ERROR: Author email address is mangled by the mailing list
#2: 
Author: Christian Schoenebeck via Qemu-devel <address@hidden>

total: 1 errors, 0 warnings, 68 lines checked

Patch 1/5 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

2/5 Checking commit 86cbf21432ea (9p: Treat multiple devices on one export as 
an error)
ERROR: Author email address is mangled by the mailing list
#2: 
Author: Christian Schoenebeck via Qemu-devel <address@hidden>

total: 1 errors, 0 warnings, 175 lines checked

Patch 2/5 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

3/5 Checking commit 55ea63dbafc2 (9p: Added virtfs option 'remap_inodes')
ERROR: Author email address is mangled by the mailing list
#2: 
Author: Christian Schoenebeck via Qemu-devel <address@hidden>

WARNING: Block comments use a leading /* on a separate line
#144: FILE: hw/9pfs/9p.c:599:
+/* stat_to_qid needs to map inode number (64 bits) and device id (32 bits)

total: 1 errors, 1 warnings, 382 lines checked

Patch 3/5 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

4/5 Checking commit 85bd3cf1f51f (9p: stat_to_qid: implement slow path)
ERROR: Author email address is mangled by the mailing list
#2: 
Author: Christian Schoenebeck via Qemu-devel <address@hidden>

WARNING: line over 80 characters
#78: FILE: hw/9pfs/9p.c:621:
+        qht_init(&pdu->s->qpf_table, qpf_lookup_func, 1 << 16, 
QHT_MODE_AUTO_RESIZE);

total: 1 errors, 1 warnings, 142 lines checked

Patch 4/5 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

5/5 Checking commit 089439298922 (9p: Use variable length suffixes for inode 
remapping)
ERROR: Author email address is mangled by the mailing list
#2: 
Author: Christian Schoenebeck via Qemu-devel <address@hidden>

ERROR: space prohibited after that open parenthesis '('
#92: FILE: hw/9pfs/9p.c:585:
+    return ((uint64_t)mirror8bit( value        & 0xff) << 56) |

ERROR: space prohibited before that close parenthesis ')'
#98: FILE: hw/9pfs/9p.c:591:
+           ((uint64_t)mirror8bit((value >> 48) & 0xff) << 8 ) |

ERROR: space prohibited before that close parenthesis ')'
#99: FILE: hw/9pfs/9p.c:592:
+           ((uint64_t)mirror8bit((value >> 56) & 0xff)      ) ;

WARNING: Block comments use a leading /* on a separate line
#102: FILE: hw/9pfs/9p.c:595:
+/** @brief Parameter k for the Exponential Golomb algorihm to be used.

WARNING: Block comments use a leading /* on a separate line
#121: FILE: hw/9pfs/9p.c:614:
+/** @brief Exponential Golomb algorithm for arbitrary k (including k=0).

WARNING: Block comments use a leading /* on a separate line
#148: FILE: hw/9pfs/9p.c:641:
+/** @brief Converts a suffix into a prefix, or a prefix into a suffix.

ERROR: "foo* bar" should be "foo *bar"
#158: FILE: hw/9pfs/9p.c:651:
+static VariLenAffix invertAffix(const VariLenAffix* affix)

WARNING: line over 80 characters
#161: FILE: hw/9pfs/9p.c:654:
+        .type = (affix->type == AffixType_Suffix) ? AffixType_Prefix : 
AffixType_Suffix,

WARNING: line over 80 characters
#162: FILE: hw/9pfs/9p.c:655:
+        .value =  mirror64bit(affix->value) >> ((sizeof(affix->value) * 8) - 
affix->bits),

WARNING: Block comments use a leading /* on a separate line
#167: FILE: hw/9pfs/9p.c:660:
+/** @brief Generates suffix numbers with "suffix-free" property.

WARNING: Block comments use a leading /* on a separate line
#246: FILE: hw/9pfs/9p.c:751:
+/** @brief Slow / full mapping host inode nr -> guest inode nr.

WARNING: Block comments use a leading /* on a separate line
#300: FILE: hw/9pfs/9p.c:804:
+/** @brief Quick mapping host inode nr -> guest inode nr.

ERROR: spaces required around that '-' (ctx:VxV)
#348: FILE: hw/9pfs/9p.c:848:
+        .ino_prefix = (uint16_t) (stbuf->st_ino >> (64-ino_hash_bits))
                                                       ^

WARNING: Block comments use a leading /* on a separate line
#429: FILE: hw/9pfs/9p.h:244:
+/** @brief Unique affix of variable length.

ERROR: line over 90 characters
#442: FILE: hw/9pfs/9p.h:257:
+    int bits; /* Lenght of the affix, that is how many (of the lowest) bits of 
@c value must be used for appending/prepending this affix to its final 
resulting, unique number. */

ERROR: line over 90 characters
#448: FILE: hw/9pfs/9p.h:263:
+    int prefix_bits; /* How many (high) bits of the original inode number 
shall be used for hashing. */

total: 8 errors, 9 warnings, 386 lines checked

Patch 5/5 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden