Re: [Qemu-devel] [PATCH v3 0/3] char-socket: Fix race condition

[Max Reitz]

On 05.06.19 21:36, Max Reitz wrote:
> On 26.04.19 09:51, Paolo Bonzini wrote:
>> On 23/04/19 18:55, Daniel P. Berrangé wrote:
>>> ping - paolo/marc-andré - unless I'm missing something, it looks like
>>> this chardev series slipped through the cracks and missed 4.0
>>
>> Yeah, it had a bug unfortunately.  I'm looking at it RSN.
> 
> I’ll just leave another ping here

And another one.

Max

>> Paolo
>>
>>>
>>> On Fri, Feb 22, 2019 at 03:46:23PM +0200, Alberto Garcia wrote:
>>>> This fixes a race condition in which the tcp_chr_read() ioc handler
>>>> can close a connection that is being written to from another thread.
>>>>
>>>> Note: vhost-user-test still fails if QTEST_VHOST_USER_FIXME is set.
>>>>
>>>> Berto
>>>>
>>>> RFC: https://lists.gnu.org/archive/html/qemu-devel/2019-02/msg01510.html
>>>>
>>>> v1: https://lists.gnu.org/archive/html/qemu-devel/2019-02/msg01834.html
>>>> - Fixes memory leaks and adds a qemu_idle_add() function
>>>>
>>>> v2: https://lists.gnu.org/archive/html/qemu-devel/2019-02/msg06137.html
>>>> - Rebased on top of the current master (fc3dbb90f2eb069801bfb4cfe9cbc)
>>>> - Patches 1 and 2: Remove the changes in char-pty.c, they're not
>>>>                    needed after the rebase.
>>>> - Patch 3: Fix conflicts after the rebase.
>>>>
>>>> v3:
>>>> - Patch 3: Add tcp_chr_disconnect_locked() [Daniel]
>>>>
>>>> Alberto Garcia (3):
>>>>   main-loop: Fix GSource leak in qio_task_thread_worker()
>>>>   main-loop: Add qemu_idle_add()
>>>>   char-socket: Lock tcp_chr_disconnect() and socket_reconnect_timeout()
>>>>
>>>>  chardev/char-socket.c    | 25 +++++++++++++++++++++----
>>>>  include/qemu/main-loop.h | 12 ++++++++++++
>>>>  io/task.c                |  9 +++------
>>>>  util/main-loop.c         |  9 +++++++++
>>>>  4 files changed, 45 insertions(+), 10 deletions(-)
>>>>
>>>> -- 
>>>> 2.11.0
>>>>
>>>
>>> Regards,
>>> Daniel
>>>
>>
>>
>>
> 
>

signature.asc
Description: OpenPGP digital signature