Re: [Qemu-devel] [BUG] Inappropriate size of target_sigset_t

[Peter Maydell]

On Wed, 3 Jul 2019 at 21:20, Aleksandar Markovic <address@hidden> wrote:
>
> From: Laurent Vivier <address@hidden>
> > If I compare with kernel, it looks good:
> > ...
> > I think there is no problem.
>
> Sure, thanks for such fast response - again, I am glad if you are right. 
> However, for some reason, glibc (and musl too) define sigset_t differently 
> than kernel. Please take a look. I am not sure if this is covered fine in our 
> code.

Yeah, the libc definitions of sigset_t don't match the
kernel ones (this is for obscure historical reasons IIRC).
We're providing implementations of the target
syscall interface, so our target_sigset_t should be the
target kernel's version (and the target libc's version doesn't
matter to us). On the other hand we will be using the
host libc version, I think, so a little caution is required
and it's possible we have some bugs in our code.

thanks
-- PMM