[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] hw/display/vga: Why architecture specific code?
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] hw/display/vga: Why architecture specific code? |
|
Date: |
Thu, 4 Jul 2019 16:04:32 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 |
On 04/07/19 15:55, Gerd Hoffmann wrote:
> On Thu, Jul 04, 2019 at 03:27:25PM +0200, Philippe Mathieu-Daudé wrote:
>> Hi Gerd,
>>
>> I'm looking at:
>>
>> static const MemoryRegionPortio vbe_portio_list[] = {
>> { 0, 1, 2, .read = vbe_ioport_read_index, .write =
>> vbe_ioport_write_index },
>> # ifdef TARGET_I386
>> { 1, 1, 2, .read = vbe_ioport_read_data, .write =
>> vbe_ioport_write_data },
>> # endif
>> { 2, 1, 2, .read = vbe_ioport_read_data, .write =
>> vbe_ioport_write_data },
>> PORTIO_END_OF_LIST(),
>> };
>
> Unaligned 16bit ioport access works on x86 only.
But I'm not sure that it needs to be target-dependent now. Worst case
you'd have a dead MemoryRegion.
Paolo