[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 04/18] qapi: add BitmapSyncMode enum
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH v2 04/18] qapi: add BitmapSyncMode enum |
Date: |
Fri, 05 Jul 2019 16:18:47 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) |
John Snow <address@hidden> writes:
> Depending on what a user is trying to accomplish, there might be a few
> bitmap cleanup actions that occur when an operation is finished that
> could be useful.
>
> I am proposing three:
> - NEVER: The bitmap is never synchronized against what was copied.
> - ALWAYS: The bitmap is always synchronized, even on failures.
> - CONDITIONAL: The bitmap is synchronized only on success.
>
> The existing incremental backup modes use 'conditional' semantics,
> so add just that one for right now.
>
> Signed-off-by: John Snow <address@hidden>
> ---
> qapi/block-core.json | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/qapi/block-core.json b/qapi/block-core.json
> index 7b23efcf13..87eba5a5d9 100644
> --- a/qapi/block-core.json
> +++ b/qapi/block-core.json
> @@ -1134,6 +1134,20 @@
> { 'enum': 'MirrorSyncMode',
> 'data': ['top', 'full', 'none', 'incremental'] }
>
> +##
> +# @BitmapSyncMode:
> +#
> +# An enumeration of possible behaviors for the synchronization of a bitmap
> +# when used for data copy operations.
> +#
> +# @conditional: The bitmap is only synced when the operation is successful.
> +# This is the behavior always used for 'INCREMENTAL' backups.
> +#
> +# Since: 4.2
> +##
> +{ 'enum': 'BitmapSyncMode',
> + 'data': ['conditional'] }
> +
> ##
> # @MirrorCopyMode:
> #
The name "conditional" makes me go "on what?". What about "on-success"?
- Re: [Qemu-devel] [PATCH v2 01/18] qapi/block-core: Introduce BackupCommon, (continued)
[Qemu-devel] [PATCH v2 02/18] drive-backup: create do_backup_common, John Snow, 2019/07/03
[Qemu-devel] [PATCH v2 03/18] blockdev-backup: utilize do_backup_common, John Snow, 2019/07/03
[Qemu-devel] [PATCH v2 04/18] qapi: add BitmapSyncMode enum, John Snow, 2019/07/03
[Qemu-devel] [PATCH v2 06/18] block/backup: add 'never' policy to bitmap sync mode, John Snow, 2019/07/03
[Qemu-devel] [PATCH v2 05/18] block/backup: Add mirror sync mode 'bitmap', John Snow, 2019/07/03
[Qemu-devel] [PATCH v2 07/18] hbitmap: Fix merge when b is empty, and result is not an alias of a, John Snow, 2019/07/03
[Qemu-devel] [PATCH v2 08/18] hbitmap: enable merging across granularities, John Snow, 2019/07/03
[Qemu-devel] [PATCH v2 09/18] block/dirty-bitmap: add bdrv_dirty_bitmap_merge_internal, John Snow, 2019/07/03