[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [RFC PATCH-for-4.1 v4 3/3] hw/ssi/xilinx_spips: Avoid out-o
From: |
Philippe Mathieu-Daudé |
Subject: |
[Qemu-devel] [RFC PATCH-for-4.1 v4 3/3] hw/ssi/xilinx_spips: Avoid out-of-bound access to lqspi_buf[] |
Date: |
Fri, 5 Jul 2019 22:25:00 +0200 |
Both lqspi_read() and lqspi_load_cache() expect a 32-bit
aligned address.
Set MemoryRegionOps.impl values to force 32-bit accesses,
this way we are sure we do not access the lqspi_buf[] array
out of bound.
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
---
Late friday patch...
hw/ssi/xilinx_spips.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/hw/ssi/xilinx_spips.c b/hw/ssi/xilinx_spips.c
index 3c4e8365ee..8f705132a3 100644
--- a/hw/ssi/xilinx_spips.c
+++ b/hw/ssi/xilinx_spips.c
@@ -1243,6 +1243,10 @@ static const MemoryRegionOps lqspi_ops = {
.min_access_size = 1,
.max_access_size = 4
}
+ .impl = {
+ .min_access_size = 4,
+ .max_access_size = 4,
+ }
};
static void xilinx_spips_realize(DeviceState *dev, Error **errp)
--
2.20.1