Re: [Qemu-devel] [PULL v6 29/42] qmp: Add deprecation information to query-machines

[Eric Blake]

On 7/5/19 5:14 PM, Eduardo Habkost wrote:
> Export machine type deprecation status through the query-machines
> QMP command.  With this, libvirt and management software will be
> able to show this information to users and/or suggest changes to
> VM configuration to avoid deprecated machines.
> 
> Signed-off-by: Eduardo Habkost <address@hidden>
> Message-Id: <address@hidden>
> Signed-off-by: Eduardo Habkost <address@hidden>
> ---
>  qapi/machine.json          | 7 ++++++-
>  hw/core/machine-qmp-cmds.c | 1 +
>  2 files changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/qapi/machine.json b/qapi/machine.json
> index 78d34ef717..6db8a7e2ec 100644
> --- a/qapi/machine.json
> +++ b/qapi/machine.json
> @@ -321,12 +321,17 @@
>  # @numa-mem-supported: true if '-numa node,mem' option is supported by
>  #                      the machine type and false otherwise (since 4.1)
>  #
> +# @deprecated: if true, the machine type is deprecated and may be removed
> +#              in future versions of QEMU according to the QEMU deprecation
> +#              policy (since 4.1.0)

Here, you used 'since 4.1.0'; in patch 31, you used merely 'since 4.1'.
It's not the first time we are inconsistent, but if someone wants a
trivial cleanup job, scrubbing the docs for all 3-element versions and
converting them to 2-element may be an interesting beginner's task.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

signature.asc
Description: OpenPGP digital signature