[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/3] Add dbus-vmstate object
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH 3/3] Add dbus-vmstate object |
|
Date: |
Mon, 8 Jul 2019 11:11:01 -0500 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 |
On 7/8/19 3:41 AM, Juan Quintela wrote:
> Marc-André Lureau <address@hidden> wrote:
>> When instanciated, this object will connect to the given D-Bus
>> bus. During migration, it will take the data from org.qemu.VMState1
>> instances.
>>
>> See documentation for further details.
>>
>> Signed-off-by: Marc-André Lureau <address@hidden>
>
>
> Before anything, I have no clue about DBUS and not a lot about glib, so
> don't expect anything else that questions on that front.
>
Ditto from me, but just noticing:
> Several questions:
>
>> +#define DBUS_VMSTATE_SIZE_LIMIT (1 << 20) /* 1mb */
Should this include units.h and spell it (1 * MiB)?
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 0/3] Add dbus-vmstate, Marc-André Lureau, 2019/07/08
- [Qemu-devel] [PATCH 1/3] qemu-file: move qemu_{get, put}_counted_string() declarations, Marc-André Lureau, 2019/07/08
- [Qemu-devel] [PATCH 2/3] tests: add qtest_set_exit_status(), Marc-André Lureau, 2019/07/08
- [Qemu-devel] [PATCH 3/3] Add dbus-vmstate object, Marc-André Lureau, 2019/07/08
- Re: [Qemu-devel] [PATCH 0/3] Add dbus-vmstate, no-reply, 2019/07/08
- Re: [Qemu-devel] [PATCH 0/3] Add dbus-vmstate, no-reply, 2019/07/08
- Re: [Qemu-devel] [PATCH 0/3] Add dbus-vmstate, Dr. David Alan Gilbert, 2019/07/08
- Re: [Qemu-devel] [PATCH 0/3] Add dbus-vmstate, Daniel P . Berrangé, 2019/07/08