Re: [Qemu-devel] [PATCH 07/17] MAINTAINERS: Merge sections CPU, NUMA into Machine core

[Markus Armbruster]

Eduardo Habkost <address@hidden> writes:

> On Mon, Jun 24, 2019 at 01:22:07PM +0200, Markus Armbruster wrote:
>> Daniel P. Berrangé <address@hidden> writes:
>> 
>> > On Wed, Jun 19, 2019 at 10:10:40PM +0200, Markus Armbruster wrote:
>> >> Suggested-by: Paolo Bonzini <address@hidden>
>> >> Cc: Eduardo Habkost <address@hidden>
>> >> Cc: Marcel Apfelbaum <address@hidden>
>> >> Signed-off-by: Markus Armbruster <address@hidden>
>> >> ---
>> >>  MAINTAINERS | 16 ++++------------
>> >>  1 file changed, 4 insertions(+), 12 deletions(-)
>> >
>> > Reviewed-by: Daniel P. Berrangé <address@hidden>
>> >
>> >> 
>> >> diff --git a/MAINTAINERS b/MAINTAINERS
>> >> index 1aef0afaf7..f18fddbbbb 100644
>> >> --- a/MAINTAINERS
>> >> +++ b/MAINTAINERS
>> >> @@ -1268,8 +1268,12 @@ S: Supported
>> >>  F: hw/core/machine.c
>> >>  F: hw/core/null-machine.c
>> >>  F: hw/cpu/cluster.c
>> >> +F: numa.c
>> >> +F: qom/cpu.c
>> >
>> > Not a blocker for this patch, but as a later patch, I'd encourage you to
>> > move qom/cpu.c somewhere else. Pretty much anywhere else would be better
>> > than under qom/ IMHO :-)
>> 
>> Eduardo, any ideas?
>
> Sorry for the late reply.  I suggest hw/core/cpu.c.

Can do.  Also: include/qom/cpu.h -> include/hw/core/cpu.h.

There's also hw/cpu/ and include/hw/cpu/.  I presume they are less
suited than hw/core and include/hw/core/.