Re: [Qemu-devel] [PATCH 00/11] Multiple simultaneous audio backends

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [PATCH 00/11] Multiple simultaneous audio backends

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
3080c9b audio: use size_t where makes sense
c4faae9 audio: remove read and write pcm_ops
8d1cbe2 paaudio: fix playback glitches
dbeb913 audio: do not run each backend in audio_run
ec4e34e audio: remove audio_MIN, audio_MAX
b36085a paaudio: properly disconnect streams in fini_*
db53be0 paaudio: do not move stream when sink/source name is specified
052ab5c audio: audiodev= parameters no longer optional when -audiodev present
c0cf5a5 audio: add audiodev properties to frontends
15c571f audio: basic support for multi backend audio
88dfd06 audio: reduce glob_audio_state usage

=== OUTPUT BEGIN ===
1/11 Checking commit 88dfd065d232 (audio: reduce glob_audio_state usage)
2/11 Checking commit 15c571f4acb7 (audio: basic support for multi backend audio)
ERROR: space prohibited between function name and open parenthesis '('
#168: FILE: audio/audio.c:1526:
+    QLIST_INSERT_HEAD (&card->state->card_head, card, entries);

total: 1 errors, 0 warnings, 366 lines checked

Patch 2/11 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

3/11 Checking commit c0cf5a5363ac (audio: add audiodev properties to frontends)
4/11 Checking commit 052ab5cd93bd (audio: audiodev= parameters no longer 
optional when -audiodev present)
5/11 Checking commit db53be05092d (paaudio: do not move stream when sink/source 
name is specified)
6/11 Checking commit b36085a0bf72 (paaudio: properly disconnect streams in 
fini_*)
7/11 Checking commit ec4e34eade3d (audio: remove audio_MIN, audio_MAX)
ERROR: space prohibited between function name and open parenthesis '('
#22: FILE: audio/alsaaudio.c:637:
+        int len = MIN (alsa->pending, left_till_end_samples);

ERROR: space prohibited between function name and open parenthesis '('
#31: FILE: audio/alsaaudio.c:700:
+    decr = MIN (live, avail);

ERROR: space prohibited between function name and open parenthesis '('
#40: FILE: audio/alsaaudio.c:918:
+    decr = MIN (dead, avail);

ERROR: space prohibited between function name and open parenthesis '('
#53: FILE: audio/audio.c:536:
+            m = MIN (m, sw->total_hw_samples_acquired);

ERROR: space prohibited between function name and open parenthesis '('
#62: FILE: audio/audio.c:556:
+    int len = MIN (left, live);

ERROR: space prohibited between function name and open parenthesis '('
#70: FILE: audio/audio.c:563:
+        int samples_to_clip = MIN (len, samples_till_end_of_buf);

ERROR: space prohibited between function name and open parenthesis '('
#79: FILE: audio/audio.c:617:
+    swlim = MIN (swlim, samples);

ERROR: space prohibited between function name and open parenthesis '('
#88: FILE: audio/audio.c:665:
+            m = MIN (m, sw->total_hw_samples_mixed);

ERROR: space prohibited between function name and open parenthesis '('
#97: FILE: audio/audio.c:728:
+    swlim = MIN (swlim, samples);

ERROR: space prohibited between function name and open parenthesis '('
#106: FILE: audio/audio.c:740:
+        blck = MIN (dead, left);

ERROR: space prohibited between function name and open parenthesis '('
#115: FILE: audio/audio.c:1032:
+                int to_write = MIN (till_end_of_hw, n);

ERROR: space prohibited between function name and open parenthesis '('
#124: FILE: audio/audio.c:1050:
+    n = MIN (samples, hw->samples - rpos);

ERROR: space prohibited between function name and open parenthesis '('
#133: FILE: audio/audio.c:1206:
+            int to_capture = MIN (live, left);

ERROR: space prohibited between function name and open parenthesis '('
#174: FILE: audio/coreaudio.c:416:
+    decr = MIN (core->decr, live);

ERROR: space prohibited between function name and open parenthesis '('
#187: FILE: audio/dsoundaudio.c:710:
+    len = MIN (len, dead);

ERROR: space prohibited between function name and open parenthesis '('
#205: FILE: audio/noaudio.c:59:
+    decr = MIN (live, samples);

ERROR: space prohibited between function name and open parenthesis '('
#214: FILE: audio/noaudio.c:114:
+        bytes = MIN (bytes, INT_MAX);

ERROR: space prohibited between function name and open parenthesis '('
#217: FILE: audio/noaudio.c:116:
+        samples = MIN (samples, dead);

ERROR: space prohibited between function name and open parenthesis '('
#226: FILE: audio/noaudio.c:127:
+    int to_clear = MIN (samples, total);

ERROR: space prohibited between function name and open parenthesis '('
#239: FILE: audio/ossaudio.c:391:
+        int samples_to_write = MIN (oss->pending, samples_till_end);

ERROR: space prohibited between function name and open parenthesis '('
#248: FILE: audio/ossaudio.c:440:
+        decr = MIN (bytes >> hw->info.shift, live);

ERROR: space prohibited between function name and open parenthesis '('
#257: FILE: audio/ossaudio.c:459:
+        decr = MIN (abinfo.bytes >> hw->info.shift, live);

ERROR: space prohibited between function name and open parenthesis '('
#279: FILE: audio/paaudio.c:247:
+            int chunk = MIN (to_mix, hw->samples - rpos);

ERROR: space prohibited between function name and open parenthesis '('
#288: FILE: audio/paaudio.c:285:
+    decr = MIN (live, pa->decr);

ERROR: space prohibited between function name and open parenthesis '('
#306: FILE: audio/paaudio.c:339:
+            int chunk = MIN (to_grab, hw->samples - wpos);

ERROR: space prohibited between function name and open parenthesis '('
#315: FILE: audio/paaudio.c:378:
+    incr = MIN (dead, pa->incr);

ERROR: space prohibited between function name and open parenthesis '('
#341: FILE: audio/sdlaudio.c:239:
+    decr = MIN (sdl->decr, live);

ERROR: space prohibited between function name and open parenthesis '('
#354: FILE: audio/spiceaudio.c:167:
+    decr = MIN (live, decr);

ERROR: space prohibited between function name and open parenthesis '('
#361: FILE: audio/spiceaudio.c:173:
+        int len = MIN (samples, left_till_end_samples);

ERROR: space prohibited between function name and open parenthesis '('
#369: FILE: audio/spiceaudio.c:180:
+            len = MIN (len, out->fsize);

ERROR: space prohibited between function name and open parenthesis '('
#378: FILE: audio/spiceaudio.c:298:
+    num_samples = MIN (num_samples, delta_samp);

ERROR: space prohibited between function name and open parenthesis '('
#387: FILE: audio/spiceaudio.c:308:
+    num_samples = MIN (ready, num_samples);

ERROR: space prohibited between function name and open parenthesis '('
#400: FILE: audio/wavaudio.c:62:
+    decr = MIN (live, samples);

ERROR: space prohibited between function name and open parenthesis '('
#406: FILE: audio/wavaudio.c:67:
+        int convert_samples = MIN (samples, left_till_end_samples);

ERROR: space prohibited between function name and open parenthesis '('
#419: FILE: hw/audio/ac97.c:967:
+    temp = MIN (temp, max);

ERROR: space prohibited between function name and open parenthesis '('
#428: FILE: hw/audio/ac97.c:976:
+        to_copy = MIN (temp, sizeof (tmpbuf));

ERROR: space prohibited between function name and open parenthesis '('
#428: FILE: hw/audio/ac97.c:976:
+        to_copy = MIN (temp, sizeof (tmpbuf));

ERROR: space prohibited between function name and open parenthesis '('
#437: FILE: hw/audio/ac97.c:1022:
+        int temp = MIN (elapsed, sizeof (s->silence));

ERROR: space prohibited between function name and open parenthesis '('
#437: FILE: hw/audio/ac97.c:1022:
+        int temp = MIN (elapsed, sizeof (s->silence));

ERROR: space prohibited between function name and open parenthesis '('
#446: FILE: hw/audio/ac97.c:1043:
+    temp = MIN (temp, max);

ERROR: space prohibited between function name and open parenthesis '('
#455: FILE: hw/audio/ac97.c:1052:
+        to_copy = MIN (temp, sizeof (tmpbuf));

ERROR: space prohibited between function name and open parenthesis '('
#455: FILE: hw/audio/ac97.c:1052:
+        to_copy = MIN (temp, sizeof (tmpbuf));

ERROR: space prohibited between function name and open parenthesis '('
#468: FILE: hw/audio/adlib.c:198:
+    to_play = MIN (s->left, samples);

ERROR: space prohibited between function name and open parenthesis '('
#477: FILE: hw/audio/adlib.c:213:
+    samples = MIN (samples, s->samples - s->pos);

ERROR: space prohibited between function name and open parenthesis '('
#490: FILE: hw/audio/cs4231a.c:538:
+        to_copy = MIN (temp, left);

ERROR: space prohibited between function name and open parenthesis '('
#499: FILE: hw/audio/cs4231a.c:581:
+        copy = MIN (till, copy);

ERROR: space prohibited between function name and open parenthesis '('
#512: FILE: hw/audio/es1370.c:648:
+    int temp = MIN (max, MIN (left, csc_bytes));

ERROR: space prohibited between function name and open parenthesis '('
#512: FILE: hw/audio/es1370.c:648:
+    int temp = MIN (max, MIN (left, csc_bytes));

ERROR: space prohibited between function name and open parenthesis '('
#521: FILE: hw/audio/es1370.c:657:
+            to_copy = MIN ((size_t) temp, sizeof (tmpbuf));

ERROR: space prohibited between function name and open parenthesis '('
#521: FILE: hw/audio/es1370.c:657:
+            to_copy = MIN ((size_t) temp, sizeof (tmpbuf));

ERROR: space prohibited between function name and open parenthesis '('
#530: FILE: hw/audio/es1370.c:675:
+            to_copy = MIN ((size_t) temp, sizeof (tmpbuf));

ERROR: space prohibited between function name and open parenthesis '('
#530: FILE: hw/audio/es1370.c:675:
+            to_copy = MIN ((size_t) temp, sizeof (tmpbuf));

ERROR: space prohibited between function name and open parenthesis '('
#543: FILE: hw/audio/gus.c:120:
+    to_play = MIN (samples, s->left);

ERROR: space prohibited between function name and open parenthesis '('
#552: FILE: hw/audio/gus.c:135:
+    samples = MIN (samples, s->samples);

ERROR: space prohibited between function name and open parenthesis '('
#561: FILE: hw/audio/gus.c:195:
+        int to_copy = MIN ((size_t) left, sizeof (tmpbuf));

ERROR: space prohibited between function name and open parenthesis '('
#561: FILE: hw/audio/gus.c:195:
+        int to_copy = MIN ((size_t) left, sizeof (tmpbuf));

ERROR: space prohibited between function name and open parenthesis '('
#691: FILE: hw/audio/sb16.c:1171:
+        to_copy = MIN (temp, left);

total: 57 errors, 0 warnings, 559 lines checked

Patch 7/11 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

8/11 Checking commit dbeb913b9bda (audio: do not run each backend in audio_run)
9/11 Checking commit 8d1cbe2aac33 (paaudio: fix playback glitches)
10/11 Checking commit c4faae967433 (audio: remove read and write pcm_ops)
11/11 Checking commit 3080c9b66a87 (audio: use size_t where makes sense)
ERROR: space prohibited between function name and open parenthesis '('
#62: FILE: audio/alsaaudio.c:871:
+    size_t live = audio_pcm_hw_get_live_in (hw);

ERROR: space prohibited between function name and open parenthesis '('
#91: FILE: audio/audio.c:529:
+static size_t audio_pcm_hw_find_min_in (HWVoiceIn *hw)

ERROR: space prohibited between function name and open parenthesis '('
#109: FILE: audio/audio.c:544:
+    size_t live = hw->total_samples_captured - audio_pcm_hw_find_min_in (hw);

ERROR: space prohibited between function name and open parenthesis '('
#126: FILE: audio/audio.c:556:
+    size_t len = MIN (left, live);

ERROR: space prohibited between function name and open parenthesis '('
#135: FILE: audio/audio.c:563:
+        size_t samples_to_clip = MIN (len, samples_till_end_of_buf);

ERROR: space prohibited between function name and open parenthesis '('
#210: FILE: audio/audio.c:652:
+static size_t audio_pcm_hw_find_min_out (HWVoiceOut *hw, int *nb_livep)

ERROR: space prohibited between function name and open parenthesis '('
#223: FILE: audio/audio.c:669:
+static size_t audio_pcm_hw_get_live_out (HWVoiceOut *hw, int *nb_live)

WARNING: line over 80 characters
#253: FILE: audio/audio.c:696:
+    size_t hwsamples, samples, isamp, osamp, wpos, live, dead, left, swlim, 
blck;

ERROR: space prohibited between function name and open parenthesis '('
#301: FILE: audio/audio.c:964:
+static size_t audio_get_avail (SWVoiceIn *sw)

ERROR: space prohibited between function name and open parenthesis '('
#409: FILE: audio/audio.c:1066:
+            dolog ("live=%zu hw->samples=%zu\n", live, hw->samples);

ERROR: space prohibited between function name and open parenthesis '('
#795: FILE: audio/noaudio.c:109:
+        bytes = MIN (bytes, SIZE_MAX);

ERROR: space prohibited between function name and open parenthesis '('
#886: FILE: audio/ossaudio.c:723:
+    size_t live = audio_pcm_hw_get_live_in (hw);

ERROR: space prohibited between function name and open parenthesis '('
#981: FILE: audio/paaudio.c:247:
+            size_t chunk = MIN (to_mix, hw->samples - rpos);

ERROR: space prohibited between function name and open parenthesis '('
#1011: FILE: audio/paaudio.c:334:
+            size_t chunk = MIN (to_grab, hw->samples - wpos);

ERROR: space prohibited between function name and open parenthesis '('
#1135: FILE: audio/spiceaudio.c:156:
+static size_t line_out_run (HWVoiceOut *hw, size_t live)

WARNING: line over 80 characters
#1201: FILE: include/sysemu/replay.h:184:
+void replay_audio_in(size_t *recorded, void *samples, size_t *wpos, size_t 
size);

total: 14 errors, 2 warnings, 1106 lines checked

Patch 11/11 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden