[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 01/18] qapi/block-core: Introduce BackupCommo
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH v4 01/18] qapi/block-core: Introduce BackupCommon |
Date: |
Wed, 10 Jul 2019 06:11:32 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) |
John Snow <address@hidden> writes:
> On 7/9/19 7:25 PM, John Snow wrote:
>> drive-backup and blockdev-backup have an awful lot of things in common
>> that are the same. Let's fix that.
>>
>> I don't deduplicate 'target', because the semantics actually did change
>> between each structure. Leave that one alone so it can be documented
>> separately.
>
> Sorry Markus, I forgot to adjust this. Pretend I wrote:
>
> Where documentation was not identical, use the most up-to-date version.
> For "speed", use Blockdev-Backup's version. For "sync", use
> Drive-Backup's version.
With that:
Reviewed-by: Markus Armbruster <address@hidden>
[...]
- [Qemu-devel] [PATCH v4 07/18] hbitmap: Fix merge when b is empty, and result is not an alias of a, (continued)
- [Qemu-devel] [PATCH v4 07/18] hbitmap: Fix merge when b is empty, and result is not an alias of a, John Snow, 2019/07/09
- [Qemu-devel] [PATCH v4 06/18] block/backup: add 'never' policy to bitmap sync mode, John Snow, 2019/07/09
- [Qemu-devel] [PATCH v4 03/18] blockdev-backup: utilize do_backup_common, John Snow, 2019/07/09
- [Qemu-devel] [PATCH v4 08/18] hbitmap: enable merging across granularities, John Snow, 2019/07/09
- [Qemu-devel] [PATCH v4 04/18] qapi: add BitmapSyncMode enum, John Snow, 2019/07/09
- [Qemu-devel] [PATCH v4 02/18] drive-backup: create do_backup_common, John Snow, 2019/07/09
- [Qemu-devel] [PATCH v4 10/18] block/dirty-bitmap: add bdrv_dirty_bitmap_get, John Snow, 2019/07/09
- [Qemu-devel] [PATCH v4 01/18] qapi/block-core: Introduce BackupCommon, John Snow, 2019/07/09
- [Qemu-devel] [PATCH v4 13/18] iotests: add testing shim for script-style python tests, John Snow, 2019/07/09
- [Qemu-devel] [PATCH v4 14/18] iotests: teach run_job to cancel pending jobs, John Snow, 2019/07/09
- [Qemu-devel] [PATCH v4 12/18] block/backup: add 'always' bitmap sync policy, John Snow, 2019/07/09
- [Qemu-devel] [PATCH v4 15/18] iotests: teach FilePath to produce multiple paths, John Snow, 2019/07/09
- [Qemu-devel] [PATCH v4 16/18] iotests: Add virtio-scsi device helper, John Snow, 2019/07/09
- [Qemu-devel] [PATCH v4 11/18] block/backup: upgrade copy_bitmap to BdrvDirtyBitmap, John Snow, 2019/07/09
- [Qemu-devel] [PATCH v4 05/18] block/backup: Add mirror sync mode 'bitmap', John Snow, 2019/07/09
- [Qemu-devel] [PATCH v4 09/18] block/dirty-bitmap: add bdrv_dirty_bitmap_merge_internal, John Snow, 2019/07/09