[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 05/11] paaudio: do not move stream when sink/sou
From: |
Marc-André Lureau |
Subject: |
Re: [Qemu-devel] [PATCH 05/11] paaudio: do not move stream when sink/source name is specified |
Date: |
Wed, 10 Jul 2019 23:58:38 +0400 |
On Tue, Jul 9, 2019 at 10:53 PM Kővágó, Zoltán <address@hidden> wrote:
>
> Unless we disable stream moving, pulseaudio can easily move the stream
> on connect, effectively ignoring the source/sink specified by the user.
>
> Signed-off-by: Kővágó, Zoltán <address@hidden>
Reviewed-by: Marc-André Lureau <address@hidden>
> ---
> audio/paaudio.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/audio/paaudio.c b/audio/paaudio.c
> index cc3a34c2ea..24d98b344a 100644
> --- a/audio/paaudio.c
> +++ b/audio/paaudio.c
> @@ -517,6 +517,11 @@ static pa_stream *qpa_simple_new (
> #endif
> | PA_STREAM_AUTO_TIMING_UPDATE;
>
> + if (dev) {
> + /* don't move the stream if the user specified a sink/source */
> + flags |= PA_STREAM_DONT_MOVE;
> + }
> +
> if (dir == PA_STREAM_PLAYBACK) {
> r = pa_stream_connect_playback(stream, dev, attr, flags, NULL, NULL);
> } else {
> --
> 2.22.0
>
>
--
Marc-André Lureau
- [Qemu-devel] [PATCH 00/11] Multiple simultaneous audio backends, Kővágó, Zoltán, 2019/07/09
- [Qemu-devel] [PATCH 08/11] audio: do not run each backend in audio_run, Kővágó, Zoltán, 2019/07/09
- [Qemu-devel] [PATCH 06/11] paaudio: properly disconnect streams in fini_*, Kővágó, Zoltán, 2019/07/09
- [Qemu-devel] [PATCH 09/11] paaudio: fix playback glitches, Kővágó, Zoltán, 2019/07/09
- [Qemu-devel] [PATCH 05/11] paaudio: do not move stream when sink/source name is specified, Kővágó, Zoltán, 2019/07/09
- Re: [Qemu-devel] [PATCH 05/11] paaudio: do not move stream when sink/source name is specified,
Marc-André Lureau <=
- [Qemu-devel] [PATCH 03/11] audio: add audiodev properties to frontends, Kővágó, Zoltán, 2019/07/09
- [Qemu-devel] [PATCH 10/11] audio: remove read and write pcm_ops, Kővágó, Zoltán, 2019/07/09
- [Qemu-devel] [PATCH 01/11] audio: reduce glob_audio_state usage, Kővágó, Zoltán, 2019/07/09
- [Qemu-devel] [PATCH 02/11] audio: basic support for multi backend audio, Kővágó, Zoltán, 2019/07/09