[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/2] create_config: remove $(CONFIG_SOFTMMU) hac
From: |
Montes, Julio |
Subject: |
Re: [Qemu-devel] [PATCH 2/2] create_config: remove $(CONFIG_SOFTMMU) hack |
Date: |
Thu, 11 Jul 2019 18:31:05 +0000 |
lgtm, thanks Paolo
Reviewed-by: Julio Montes <address@hidden>
Tested-by: Julio Montes <address@hidden>
On Thu, 2019-07-11 at 19:22 +0200, Paolo Bonzini wrote:
> CONFIG_TPM is defined to a rather weird $(CONFIG_SOFTMMU) so that it
> expands to the right thing in hw/Makefile.objs. This however is not
> needed anymore and it has a corresponding hack in create_config
> to turn it into "#define CONFIG_TPM 1". Clean up.
>
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
> configure | 2 +-
> scripts/create_config | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/configure b/configure
> index 4983c8b..eb635c3 100755
> --- a/configure
> +++ b/configure
> @@ -7159,7 +7159,7 @@ if test "$live_block_migration" = "yes" ; then
> fi
>
> if test "$tpm" = "yes"; then
> - echo 'CONFIG_TPM=$(CONFIG_SOFTMMU)' >> $config_host_mak
> + echo 'CONFIG_TPM=y' >> $config_host_mak
> fi
>
> echo "TRACE_BACKENDS=$trace_backends" >> $config_host_mak
> diff --git a/scripts/create_config b/scripts/create_config
> index 00e86c8..6d8f08b 100755
> --- a/scripts/create_config
> +++ b/scripts/create_config
> @@ -54,7 +54,7 @@ case $line in
> done
> echo " NULL"
> ;;
> - CONFIG_*='$(CONFIG_SOFTMMU)'|CONFIG_*=y) # configuration
> + CONFIG_*=y) # configuration
> name=${line%=*}
> echo "#define $name 1"
> ;;