[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RISU PATCH v3 01/18] risugen_common: add helper functi
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [RISU PATCH v3 01/18] risugen_common: add helper functions insnv, randint |
Date: |
Fri, 12 Jul 2019 07:48:35 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.1 |
On 7/12/19 12:32 AM, Jan Bobek wrote:
> insnv allows emitting variable-length instructions in little-endian or
> big-endian byte order; it subsumes functionality of former insn16()
> and insn32() functions.
>
> randint can reliably generate signed or unsigned integers of arbitrary
> width.
>
> Signed-off-by: Jan Bobek <address@hidden>
> ---
> risugen_common.pm | 55 +++++++++++++++++++++++++++++++++++++++++------
> 1 file changed, 48 insertions(+), 7 deletions(-)
>
> diff --git a/risugen_common.pm b/risugen_common.pm
> index 71ee996..d63250a 100644
> --- a/risugen_common.pm
> +++ b/risugen_common.pm
> @@ -23,8 +23,9 @@ BEGIN {
> require Exporter;
>
> our @ISA = qw(Exporter);
> - our @EXPORT = qw(open_bin close_bin set_endian insn32 insn16 $bytecount
> - progress_start progress_update progress_end
> + our @EXPORT = qw(open_bin close_bin set_endian insn32 insn16
> + $bytecount insnv randint progress_start
> + progress_update progress_end
> eval_with_fields is_pow_of_2 sextract ctz
> dump_insn_details);
> }
> @@ -37,7 +38,7 @@ my $bigendian = 0;
> # (default is little endian, 0).
> sub set_endian
> {
> - $bigendian = @_;
> + ($bigendian) = @_;
> }
>
> sub open_bin
> @@ -52,18 +53,58 @@ sub close_bin
> close(BIN) or die "can't close output file: $!";
> }
>
> +sub insnv(%)
> +{
> + my (%args) = @_;
> +
> + # Default to big-endian order, so that the instruction bytes are
> + # emitted in the same order as they are written in the
> + # configuration file.
> + $args{bigendian} = 1 unless defined $args{bigendian};
> +
> + for (my $bitcur = 0; $bitcur < $args{width}; $bitcur += 8) {
> + my $value = $args{value} >> ($args{bigendian}
> + ? $args{width} - $bitcur - 8
> + : $bitcur);
> +
> + print BIN pack("C", $value & 0xff);
> + $bytecount += 1;
> + }
Looks like bytecount is no longer used?
Otherwise,
Reviewed-by: Richard Henderson <address@hidden>
r~
- Re: [Qemu-devel] [RISU PATCH v3 08/18] risugen: add command-line flag --x86_64, (continued)
- [Qemu-devel] [RISU PATCH v3 10/18] x86.risu: add MMX instructions, Jan Bobek, 2019/07/11
- [Qemu-devel] [RISU PATCH v3 06/18] risugen_x86: add module, Jan Bobek, 2019/07/11
- [Qemu-devel] [RISU PATCH v3 05/18] risugen_x86_memory: add module, Jan Bobek, 2019/07/11
- [Qemu-devel] [RISU PATCH v3 11/18] x86.risu: add SSE instructions, Jan Bobek, 2019/07/11
- [Qemu-devel] [RISU PATCH v3 01/18] risugen_common: add helper functions insnv, randint, Jan Bobek, 2019/07/11
- [Qemu-devel] [RISU PATCH v3 07/18] risugen: allow all byte-aligned instructions, Jan Bobek, 2019/07/11
- [Qemu-devel] [RISU PATCH v3 02/18] risugen_common: split eval_with_fields into extract_fields and eval_block, Jan Bobek, 2019/07/11
- [Qemu-devel] [RISU PATCH v3 04/18] risugen_x86_constraints: add module, Jan Bobek, 2019/07/11
- [Qemu-devel] [RISU PATCH v3 15/18] x86.risu: add SSE4.1 and SSE4.2 instructions, Jan Bobek, 2019/07/11