Re: [Qemu-devel] [PATCH RFC v5 1/3] tests: New make target check-source

[Markus Armbruster]

Richard Henderson <address@hidden> writes:

> On 7/11/19 2:28 PM, Markus Armbruster wrote:
>>  include/exec/cpu_ldst_template.h          |  3 +
>>  include/exec/cpu_ldst_useronly_template.h |  3 +
>>  include/exec/cputlb.h                     |  3 +
>>  include/exec/exec-all.h                   |  3 +
>>  include/exec/gen-icount.h                 |  2 +
>>  include/exec/helper-gen.h                 |  2 +
>>  include/exec/helper-proto.h               |  2 +
>>  include/exec/helper-tcg.h                 |  2 +
>>  include/exec/ioport.h                     |  2 +
>>  include/exec/memory-internal.h            |  2 +
>>  include/exec/memory_ldst.inc.h            |  2 +
>>  include/exec/memory_ldst_cached.inc.h     |  2 +
>>  include/exec/memory_ldst_phys.inc.h       |  2 +
>
> The pattern used should not match all *.h, but exclude *_template.h (older
> naming style) and *.inc.h (newer naming style; we really should finish the
> conversion).
>
> These headers are not standalone, and will be included multiple times by one 
> of
> the other headers.

Yes.

I excluded them the stupid way in this RFC, in part because I was unsure
about the naming convention for "special .h meant to be included
multiple times".  My cover letter should have mentioned this under
"Known issues".

For my series to shed the RFC tag, I need to eliminate the FIXMEs in
headers that aren't actually broken.  This includes the FIXMEs marking
"special .h meant to be included multiple times".

Perhaps I can finish the conversion to the .inc.h convention in v6.