[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for 4.1 3/4] target/mips: Add missing 'break' fo
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-devel] [PATCH for 4.1 3/4] target/mips: Add missing 'break' for certain cases of MFTR handling |
Date: |
Fri, 12 Jul 2019 15:56:17 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 |
On 7/12/19 1:37 PM, Aleksandar Markovic wrote:
> From: Aleksandar Markovic <address@hidden>
>
> This was found by GCC 8.3 static analysis.
>
Again, please amend:
Fixes: ead9360e2fb
Reported-by: Stefan Weil <address@hidden>
> Signed-off-by: Aleksandar Markovic <address@hidden>
> ---
> target/mips/translate.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/target/mips/translate.c b/target/mips/translate.c
> index 59d4acd..b1cf5f0 100644
> --- a/target/mips/translate.c
> +++ b/target/mips/translate.c
> @@ -9826,6 +9826,7 @@ static void gen_mftr(CPUMIPSState *env, DisasContext
> *ctx, int rt, int rd,
> gen_mfc0(ctx, t0, rt, sel);
> break;
> }
> + break;
> case 12:
> switch (sel) {
> case 0:
> @@ -9835,6 +9836,7 @@ static void gen_mftr(CPUMIPSState *env, DisasContext
> *ctx, int rt, int rd,
> gen_mfc0(ctx, t0, rt, sel);
> break;
> }
> + break;
> case 13:
> switch (sel) {
> case 0:
>
12 years missing...
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Tested-by: Philippe Mathieu-Daudé <address@hidden>
- [Qemu-devel] [PATCH for 4.1 0/4] target/mips: Fixes for 4.1, Aleksandar Markovic, 2019/07/12
- [Qemu-devel] [PATCH for 4.1 2/4] target/mips: Add missing 'break' for a case of MTHC0 handling, Aleksandar Markovic, 2019/07/12
- [Qemu-devel] [PATCH for 4.1 3/4] target/mips: Add missing 'break' for certain cases of MFTR handling, Aleksandar Markovic, 2019/07/12
- Re: [Qemu-devel] [PATCH for 4.1 3/4] target/mips: Add missing 'break' for certain cases of MFTR handling,
Philippe Mathieu-Daudé <=
- [Qemu-devel] [PATCH for 4.1 1/4] target/mips: Add 'fall through' comments for handling nanoMips' SHXS, SWXS, Aleksandar Markovic, 2019/07/12
- [Qemu-devel] [PATCH for 4.1 v2] linux-user: Fix structure target_ucontext for MIPS, Aleksandar Markovic, 2019/07/12
- [Qemu-devel] [PATCH for 4.1 4/4] target/mips: Add missing 'break' for certain cases of MTTR handling, Aleksandar Markovic, 2019/07/12