Re: [Qemu-devel] Building nsis installer - cross compile for Windows

[Philippe Mathieu-Daudé]

On Mon, Jan 28, 2019 at 4:18 PM Peter Maydell <address@hidden> wrote:
> On Mon, 28 Jan 2019 at 15:11, Daniel P. Berrangé <address@hidden> wrote:
> >
> > On Mon, Jan 28, 2019 at 03:03:34PM +0000, Peter Maydell wrote:
> > > Though something
> > > doesn't seem quite right here, because the sdl2.c code is
> > > looking for icon files in a hicolor/ subdirectory that
> > > doesn't exist in the source tree.
> >
> > That directory is the standard icon installation directory for
> > application icons. The QEMU icons are placed there by 'make install',
> > but in the source dir they are in a flat layotu.
>
> There doesn't seem to be any code to handle the flat layout,
> though. (Contrast os_find_datadir() which looks in several
> places for any particular file.)

FWIW this bug is still present in QEMU v4.1.0-rc0.