[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 6/6] test: skip tests if socket_check_protoco
|
From: |
Daniel P . Berrangé |
|
Subject: |
Re: [Qemu-devel] [PATCH v3 6/6] test: skip tests if socket_check_protocol_support() failed |
|
Date: |
Mon, 15 Jul 2019 11:29:27 +0100 |
|
User-agent: |
Mutt/1.12.0 (2019-05-25) |
On Mon, Jul 15, 2019 at 02:25:03PM +0400, Marc-André Lureau wrote:
> Hi
>
> On Mon, Jul 15, 2019 at 1:40 PM Daniel P. Berrangé <address@hidden> wrote:
> >
> > On Sat, Jul 13, 2019 at 06:33:11PM +0400, Marc-André Lureau wrote:
> > > Skip the tests if socket_check_protocol_support() failed, but do run
> > > g_test_run() to keep TAP harness happy.
> >
> > Did you actually find a scenario in which it failed, or is this just
> > doing the change for the sake of strict correctness ?
>
> It fails under podman atm (https://github.com/containers/libpod/issues/3535)
Oh i see. I wonder if a better strategy is to simply set
has_ipv4 = has_ipv6 = false
if getaddrinfo() returns an error and make socket_check_protocol_support
return void.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|