[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 2/3] qapi: implement block-dirty-bitmap-remov
From: |
Max Reitz |
Subject: |
Re: [Qemu-devel] [PATCH v3 2/3] qapi: implement block-dirty-bitmap-remove transaction action |
Date: |
Mon, 15 Jul 2019 13:40:05 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 |
On 09.07.19 00:05, John Snow wrote:
> It is used to do transactional movement of the bitmap (which is
> possible in conjunction with merge command). Transactional bitmap
> movement is needed in scenarios with external snapshot, when we don't
> want to leave copy of the bitmap in the base image.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
> Signed-off-by: John Snow <address@hidden>
> ---
> block.c | 2 +-
> block/dirty-bitmap.c | 15 +++----
> blockdev.c | 79 +++++++++++++++++++++++++++++++---
> include/block/dirty-bitmap.h | 2 +-
> migration/block-dirty-bitmap.c | 2 +-
> qapi/transaction.json | 2 +
> 6 files changed, 85 insertions(+), 17 deletions(-)
[...]
> diff --git a/qapi/transaction.json b/qapi/transaction.json
> index 95edb78227..da95b804aa 100644
> --- a/qapi/transaction.json
> +++ b/qapi/transaction.json
> @@ -45,6 +45,7 @@
> #
> # - @abort: since 1.6
> # - @block-dirty-bitmap-add: since 2.5
> +# - @block-dirty-bitmap-remove: since 4.1
Optimistic.
But anyway:
Reviewed-by: Max Reitz <address@hidden>
> # - @block-dirty-bitmap-clear: since 2.5
> # - @block-dirty-bitmap-enable: since 4.0
> # - @block-dirty-bitmap-disable: since 4.0
signature.asc
Description: OpenPGP digital signature