qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [qemu-s390x] [PATCH 3/3] s390x/cpumodel: change interna


From: Thomas Huth
Subject: Re: [Qemu-devel] [qemu-s390x] [PATCH 3/3] s390x/cpumodel: change internal name of vxp to make description
Date: Tue, 16 Jul 2019 11:25:47 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2

On 15/07/2019 16.23, Christian Borntraeger wrote:
> The internal macro name VECTOR_BCD_ENH does not match the actual
> description. Fix this.
> 
> Signed-off-by: Christian Borntraeger <address@hidden>
> ---
>  target/s390x/cpu_features_def.inc.h | 2 +-
>  target/s390x/gen-features.c         | 4 ++--
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/target/s390x/cpu_features_def.inc.h 
> b/target/s390x/cpu_features_def.inc.h
> index 99f58a89318a..f7c52bc17c2e 100644
> --- a/target/s390x/cpu_features_def.inc.h
> +++ b/target/s390x/cpu_features_def.inc.h
> @@ -104,7 +104,7 @@ DEF_FEAT(CMM_NT, "cmmnt", STFL, 147, "CMM: 
> ESSA-enhancement (no translate) facil
>  DEF_FEAT(VECTOR_ENH2, "vxeh2", STFL, 148, "Vector Enhancements facility 2")
>  DEF_FEAT(ESORT_BASE, "esort-base", STFL, 150, "Enhanced-sort facility 
> (excluding subfunctions)")
>  DEF_FEAT(DEFLATE_BASE, "deflate-base", STFL, 151, "Deflate-conversion 
> facility (excluding subfunctions)")
> -DEF_FEAT(VECTOR_BCD_ENH, "vxp", STFL, 152, 
> "Vector-Packed-Decimal-Enhancement Facility")
> +DEF_FEAT(VECTOR_PACKED_DECIMAL_ENH, "vxp", STFL, 152, 
> "Vector-Packed-Decimal-Enhancement Facility")

With "vxpdeh" instead of "vxp":

Reviewed-by: Thomas Huth <address@hidden>


>  DEF_FEAT(MSA_EXT_9, "msa9-base", STFL, 155, 
> "Message-security-assist-extension-9 facility (excluding subfunctions)")
>  DEF_FEAT(ETOKEN, "etoken", STFL, 156, "Etoken facility")
>  
> diff --git a/target/s390x/gen-features.c b/target/s390x/gen-features.c
> index 6debfc1d217e..49a650ac52d0 100644
> --- a/target/s390x/gen-features.c
> +++ b/target/s390x/gen-features.c
> @@ -558,7 +558,7 @@ static uint16_t full_GEN15_GA1[] = {
>      S390_FEAT_VECTOR_ENH2,
>      S390_FEAT_GROUP_ENH_SORT,
>      S390_FEAT_GROUP_DEFLATE_CONVERSION,
> -    S390_FEAT_VECTOR_BCD_ENH,
> +    S390_FEAT_VECTOR_PACKED_DECIMAL_ENH,
>      S390_FEAT_GROUP_MSA_EXT_9,
>      S390_FEAT_GROUP_MSA_EXT_9_PCKMO,
>      S390_FEAT_ETOKEN,
> @@ -643,7 +643,7 @@ static uint16_t default_GEN14_GA1[] = {
>  static uint16_t default_GEN15_GA1[] = {
>      S390_FEAT_VECTOR_ENH2,
>      S390_FEAT_GROUP_DEFLATE_CONVERSION,
> -    S390_FEAT_VECTOR_BCD_ENH,
> +    S390_FEAT_VECTOR_PACKED_DECIMAL_ENH,
>      S390_FEAT_GROUP_MSA_EXT_9,
>      S390_FEAT_GROUP_MSA_EXT_9_PCKMO,
>      S390_FEAT_ETOKEN,
> 




reply via email to

[Prev in Thread] Current Thread [Next in Thread]