Re: [Qemu-devel] [NOTFORMERGE PATCH v2 1/9] tests/docker: Kludge to build the Fedora image

[Philippe Mathieu-Daudé]

On 7/16/19 12:54 PM, Alex Bennée wrote:
> 
> Philippe Mathieu-Daudé <address@hidden> writes:
> 
>> Rebuilding the Fedora image is failing:
>>
>>   $ make docker-image-fedora V=1
> 
> Broken build state? Just do:
> 
>   make docker-image-fedora V=1 NOCACHE=1

No, this doesn't help:

$ make docker-image-fedora V=1 NOCACHE=1
./tests/docker/docker.py build qemu:fedora
tests/docker/dockerfiles/fedora.docker  --no-cache --add-current-user
Sending build context to Docker daemon  4.096kB
Step 1/8 : FROM fedora:30
 ---> 9754ce14641d
Step 2/8 : ENV PACKAGES     bc     bison     bluez-libs-devel
brlapi-devel     bzip2     bzip2-devel     ccache     clang
cyrus-sasl-devel     device-mapper-multipath-devel     findutils
flex     gcc     gcc-c++     gettext     git     glib2-devel
glusterfs-api-devel     gnutls-devel     gtk3-devel     hostname
libaio-devel     libasan     libattr-devel     libblockdev-mpath-devel
   libcap-devel     libcap-ng-devel     libcurl-devel     libfdt-devel
   libiscsi-devel     libjpeg-devel     libpmem-devel     libpng-devel
   librbd-devel     libseccomp-devel     libssh-devel     libubsan
libusbx-devel     libxml2-devel     llvm     lzo-devel     make
mingw32-bzip2     mingw32-curl     mingw32-glib2     mingw32-gmp
mingw32-gnutls     mingw32-gtk3     mingw32-libjpeg-turbo
mingw32-libpng     mingw32-libtasn1     mingw32-nettle
mingw32-pixman     mingw32-pkg-config     mingw32-SDL2     mingw64-bzip2
    mingw64-curl     mingw64-glib2     mingw64-gmp     mingw64-gnutls
  mingw64-gtk3     mingw64-libjpeg-turbo     mingw64-libpng
mingw64-libtasn1     mingw64-nettle     mingw64-pixman
mingw64-pkg-config     mingw64-SDL2     ncurses-devel     nettle-devel
   nss-devel     numactl-devel     perl     perl-Test-Harness
pixman-devel     python3     python3-sphinx     PyYAML
rdma-core-devel     SDL2-devel     snappy-devel     sparse
spice-server-devel     systemd-devel     systemtap-sdt-devel     tar
 usbredir-devel     virglrenderer-devel     vte291-devel     which
xen-devel     zlib-devel
 ---> Running in dfeaaaa6bd31
Removing intermediate container dfeaaaa6bd31
 ---> 853735cf32a1
Step 3/8 : ENV QEMU_CONFIGURE_OPTS --python=/usr/bin/python3
 ---> Running in 64af2877181d
Removing intermediate container 64af2877181d
 ---> 2cb74a994b35
Step 4/8 : RUN dnf install -y $PACKAGES
 ---> Running in 106e7fcb2900
Fedora Modular 30 - x86_64                      2.1 MB/s | 2.7 MB
00:01
Fedora Modular 30 - x86_64 - Updates            1.6 MB/s | 2.3 MB
00:01
Fedora 30 - x86_64 - Updates                    6.3 MB/s |  17 MB
00:02
Failed to synchronize cache for repo 'updates'
Error: Failed to synchronize cache for repo 'updates'
The command '/bin/sh -c dnf install -y $PACKAGES' returned a non-zero
code: 1

>>   [...]
>>   Step 4/8 : RUN dnf install -y $PACKAGES
>>    ---> Running in cef9615efafb
>>   Fedora Modular 30 - x86_64                      2.0 MB/s | 2.7 MB     00:01
>>   Fedora Modular 30 - x86_64 - Updates            1.6 MB/s | 2.3 MB     00:01
>>   Fedora 30 - x86_64 - Updates                    6.1 MB/s |  17 MB     00:02
>>   Failed to synchronize cache for repo 'updates'
>>   Error: Failed to synchronize cache for repo 'updates'
>>   The command '/bin/sh -c dnf install -y $PACKAGES' returned a non-zero 
>> code: 1
>>   Traceback (most recent call last):
>>     File "./tests/docker/docker.py", line 615, in <module>
>>       sys.exit(main())
>>     File "./tests/docker/docker.py", line 611, in main
>>       return args.cmdobj.run(args, argv)
>>     File "./tests/docker/docker.py", line 413, in run
>>       extra_files_cksum=cksum)
>>     File "./tests/docker/docker.py", line 280, in build_image
>>       quiet=quiet)
>>     File "./tests/docker/docker.py", line 207, in _do_check
>>       return subprocess.check_call(self._command + cmd, **kwargs)
>>     File "/usr/lib64/python2.7/subprocess.py", line 190, in check_call
>>       raise CalledProcessError(retcode, cmd)
>>   subprocess.CalledProcessError: Command '['docker', 'build', '-t', 
>> 'qemu:fedora', '-f', '/tmp/docker_buildbKtWAa/tmpIctHw2.docker', 
>> '/tmp/docker_buildbKtWAa']' returned non-zero exit status 1
>>   make: *** [tests/docker/Makefile.include:53: docker-image-fedora] Error 1
>>
>> The fix found in one of the comment from this thread helped to have
>> it working again: https://bugzilla.redhat.com/show_bug.cgi?id=1706627
>>
>> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
>> ---
>> I have no idea what it does, it just works (TM).
>> ---
>>  tests/docker/dockerfiles/fedora.docker | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/tests/docker/dockerfiles/fedora.docker 
>> b/tests/docker/dockerfiles/fedora.docker
>> index e6d39e14cb..f6be5e2dd7 100644
>> --- a/tests/docker/dockerfiles/fedora.docker
>> +++ b/tests/docker/dockerfiles/fedora.docker
>> @@ -94,6 +94,7 @@ ENV PACKAGES \
>>      zlib-devel
>>  ENV QEMU_CONFIGURE_OPTS --python=/usr/bin/python3
>>
>> -RUN dnf install -y $PACKAGES
>> +RUN echo zchunk=False >> /etc/dnf/dnf.conf
>> +RUN dnf clean metadata && dnf install -y $PACKAGES
>>  RUN rpm -q $PACKAGES | sort > /packages.txt
>>  ENV FEATURES mingw clang pyyaml asan
> 
> 
> --
> Alex Bennée
>