Re: [Qemu-devel] [PATCH] s390: support EDAT-2 in mmu_translate_region

[David Hildenbrand]

On 16.07.19 15:11, Christian Borntraeger wrote:
> 
> On 16.07.19 15:04, Cornelia Huck wrote:
>> On Tue, 16 Jul 2019 14:52:03 +0200
>> Ilya Leoshkevich <address@hidden> wrote:
>>
>>>> Am 16.07.2019 um 14:41 schrieb David Hildenbrand <address@hidden>:
>>>>
>>>> How urgent is this? If this can wait, I can polish and send my series I 
>>>> have here
>>>> instead, which also implents
>>>> - IEP support
>>>> - access-exception-fetch/store-indication facility
>>>> - ESOP-1, ESOP-2  
>>>
>>> This is not urgent, I can live with my patch for now.
>>> It’s good to know that proper EDAT-2 support is being worked on.
>>>
>>> Thanks!
>>> Ilya
>>
>> Ok, so I will not queue this patch right now (I assume you're fine with
>> keeping this locally for now?), but wait for David's series for 4.2.
>>
>> Sounds reasonable?
> 
> While not complete, Ilyas  patch clearly improves the situation (and it is 
> pretty
> similar to the EDAT-1 support). 
> I think the question is: are there other instruction that we emulate in qemu 
> via the
> page table walker even for KVM? I believe we always go via the kvm memory 
> ioctl for
> page table  access via instructions so the patch is not critical for KVM. So 
> unless
> we have something I think Connys proposal is reasonable.

Yes, I remember we always go via the ioctl. Only debug memory accesses
take this path for KVM.

-- 

Thanks,

David / dhildenb