[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 04/12] block: Keep subtree drained in drop_in
|
From: |
Kevin Wolf |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 04/12] block: Keep subtree drained in drop_intermediate |
|
Date: |
Tue, 16 Jul 2019 19:03:49 +0200 |
|
User-agent: |
Mutt/1.11.3 (2019-02-01) |
Am 03.07.2019 um 19:28 hat Max Reitz geschrieben:
> bdrv_drop_intermediate() calls BdrvChildRole.update_filename(). That
> may poll, thus changing the graph, which potentially breaks the
> QLIST_FOREACH_SAFE() loop.
>
> Just keep the whole subtree drained. This is probably the right thing
> to do anyway (dropping nodes while the subtree is not drained seems
> wrong).
>
> Signed-off-by: Max Reitz <address@hidden>
Reviewed-by: Kevin Wolf <address@hidden>
- [Qemu-devel] [PATCH v2 00/12] block: Fixes for concurrent block jobs, Max Reitz, 2019/07/03
- [Qemu-devel] [PATCH v2 01/12] block: Add BDS.never_freeze, Max Reitz, 2019/07/03
- [Qemu-devel] [PATCH v2 04/12] block: Keep subtree drained in drop_intermediate, Max Reitz, 2019/07/03
- Re: [Qemu-devel] [PATCH v2 04/12] block: Keep subtree drained in drop_intermediate,
Kevin Wolf <=
- [Qemu-devel] [PATCH v2 11/12] iotests: Add read-only test case to 030, Max Reitz, 2019/07/03
- [Qemu-devel] [PATCH v2 02/12] block/stream: Fix error path, Max Reitz, 2019/07/03
- [Qemu-devel] [PATCH v2 05/12] block: Reduce (un)drains when replacing a child, Max Reitz, 2019/07/03
- [Qemu-devel] [PATCH v2 09/12] iotests: Add @use_log to VM.run_job(), Max Reitz, 2019/07/03
- [Qemu-devel] [PATCH v2 12/12] iotests: Add test for concurrent stream/commit, Max Reitz, 2019/07/03
- [Qemu-devel] [PATCH v2 07/12] iotests: Fix throttling in 030, Max Reitz, 2019/07/03
- [Qemu-devel] [PATCH v2 03/12] block/stream: Swap backing file change order, Max Reitz, 2019/07/03
- [Qemu-devel] [PATCH v2 08/12] iotests: Compare error messages in 030, Max Reitz, 2019/07/03
- [Qemu-devel] [PATCH v2 06/12] block: Deep-clear inherits_from, Max Reitz, 2019/07/03