Re: [Qemu-devel] [PATCH 2/4] memory: Single byte swap along the I/O path

[Richard Henderson]

On 7/16/19 11:06 PM, address@hidden wrote:
> +++ b/include/exec/poison.h
> @@ -38,7 +38,6 @@
>  #pragma GCC poison TARGET_HAS_BFLT
>  #pragma GCC poison TARGET_NAME
>  #pragma GCC poison TARGET_SUPPORTS_MTTCG
> -#pragma GCC poison TARGET_WORDS_BIGENDIAN

You can't do this.  This is here for a very good reason, to avoid letting
target-specific values creep into code that is compiled once, for all targets.

This means that you'll need to either move MO_TE out of memop.h or perhaps
conditionalize it upon NEED_CPU_H.

I would like to see this patch broken up into smaller bits.  Convert one
interface at a time, pushing the use of MemOp further down the stack.  At
present it's hard to review.


r~