[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/3] ram: RAMBlock->offset is always aligned to
|
From: |
Wei Yang |
|
Subject: |
Re: [Qemu-devel] [PATCH 3/3] ram: RAMBlock->offset is always aligned to a word |
|
Date: |
Thu, 18 Jul 2019 09:11:20 +0800 |
|
User-agent: |
Mutt/1.9.4 (2018-02-28) |
On Wed, Jul 17, 2019 at 11:17:50AM +0200, Paolo Bonzini wrote:
>On 30/04/19 05:44, Wei Yang wrote:
>> RAMBlock->offset is calculated by find_ram_offset, which makes sure the
>> offset is aligned to a word.
>>
>> This patch removes the alignment check on offset and unnecessary
>> variable *word*.
>>
>> Signed-off-by: Wei Yang <address@hidden>
>
>I would add an assertion instead, but overall leaving the condition
>there is harmless. You still need the "else" part for the case where
>the length is unaligned.
>
Thanks, then I would leave current code untouched.
>Paolo
>
--
Wei Yang
Help you, Help me