[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-block] [PATCH-for-4.1] hw/ide/piix: Mark the PIIX
|
From: |
Kevin Wolf |
|
Subject: |
Re: [Qemu-devel] [Qemu-block] [PATCH-for-4.1] hw/ide/piix: Mark the PIIX IDE interfaces as not user_creatable |
|
Date: |
Thu, 18 Jul 2019 14:12:50 +0200 |
|
User-agent: |
Mutt/1.11.3 (2019-02-01) |
Am 18.07.2019 um 11:26 hat Paolo Bonzini geschrieben:
> On 18/07/19 11:17, Philippe Mathieu-Daudé wrote:
> > The 'piix3-ide' (and 'piix3-ide-xen') devices are part of the
> > PIIX3 chipset modelled as TYPE_PIIX3_PCI_DEVICE (respectivelly
> > TYPE_PIIX3_XEN_DEVICE). The PIIX3 chipset can not be created
> > in part, it has to be created and used as a whole.
> >
> > Similarly with the 'piix4-ide' device and the PIIX4 chipset
> > modelled as TYPE_PIIX4_PCI_DEVICE.
> >
> > Disable the 'user_creatable' flag.
> >
> > part of TYPE_PIIX3_PCI_DEVICE (TYPE_PIIX3_XEN_DEVICE)
> >
> > Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
>
> This works though:
>
> qemu-system-x86_64 \
> -M q35,sata=off -device piix3-ide,addr=1f.2 \
> -drive if=none,file=freedos.raw,id=hd -device ide-hd,drive=hd
>
> And it is a nice hack to mimic Q35's legacy IDE mode...
And I've seen it often enough that I'm sure users are using it.
If we want to remove it at all, we'd have to go through the usual
deprecation period. But as long as we don't have another option for
getting a legacy IDE controller on Q35, I don't think we should remove
this.
Kevin