qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH for-4.1] configure: Clarify URL to source downlo


From: Thomas Huth
Subject: Re: [Qemu-devel] [PATCH for-4.1] configure: Clarify URL to source downloads
Date: Thu, 18 Jul 2019 15:18:41 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2

On 18/07/2019 15.16, Peter Maydell wrote:
> If configure detects that it's being run on a source tree which
> is missing git modules, it prints an error messages suggesting
> that the user downloads a correct source archive from the project
> website. However https://www.qemu.org/download/ is a link to a
> page with multiple tabs, with the default being the one telling
> users how to get binaries from their distro. Clarify the URL
> we print to include the #source anchor, so that the browser will
> go directly to the source-tarball instructions.
> 
> Reported-by: Philippe Mathieu-Daudé <address@hidden>
> Suggested-by: Stefan Weil <address@hidden>
> Signed-off-by: Peter Maydell <address@hidden>
> ---
>  configure | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/configure b/configure
> index eb635c3b9a5..bf79bbd0e8d 100755
> --- a/configure
> +++ b/configure
> @@ -322,7 +322,7 @@ else
>          echo "to acquire QEMU source archives. Non-GIT builds are only"
>          echo "supported with source archives linked from:"
>          echo
> -        echo "  https://www.qemu.org/download/";
> +        echo "  https://www.qemu.org/download/#source";
>          echo
>          echo "Developers working with GIT can use scripts/archive-source.sh"
>          echo "if they need to create valid source archives."
> 

Reviewed-by: Thomas Huth <address@hidden>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]