[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v3 04/10] block: Make bdrv_parent_drained_[^_]*() st
From: |
Max Reitz |
Subject: |
[Qemu-devel] [PATCH v3 04/10] block: Make bdrv_parent_drained_[^_]*() static |
Date: |
Fri, 19 Jul 2019 11:26:12 +0200 |
These functions are not used outside of block/io.c, there is no reason
why they should be globally available.
Signed-off-by: Max Reitz <address@hidden>
---
include/block/block.h | 18 ------------------
block/io.c | 8 ++++----
2 files changed, 4 insertions(+), 22 deletions(-)
diff --git a/include/block/block.h b/include/block/block.h
index bff3317696..a81645e8a3 100644
--- a/include/block/block.h
+++ b/include/block/block.h
@@ -600,15 +600,6 @@ int bdrv_probe_geometry(BlockDriverState *bs, HDGeometry
*geo);
void bdrv_io_plug(BlockDriverState *bs);
void bdrv_io_unplug(BlockDriverState *bs);
-/**
- * bdrv_parent_drained_begin:
- *
- * Begin a quiesced section of all users of @bs. This is part of
- * bdrv_drained_begin.
- */
-void bdrv_parent_drained_begin(BlockDriverState *bs, BdrvChild *ignore,
- bool ignore_bds_parents);
-
/**
* bdrv_parent_drained_begin_single:
*
@@ -624,15 +615,6 @@ void bdrv_parent_drained_begin_single(BdrvChild *c, bool
poll);
*/
void bdrv_parent_drained_end_single(BdrvChild *c);
-/**
- * bdrv_parent_drained_end:
- *
- * End a quiesced section of all users of @bs. This is part of
- * bdrv_drained_end.
- */
-void bdrv_parent_drained_end(BlockDriverState *bs, BdrvChild *ignore,
- bool ignore_bds_parents);
-
/**
* bdrv_drain_poll:
*
diff --git a/block/io.c b/block/io.c
index c42e18b068..b0b33174d3 100644
--- a/block/io.c
+++ b/block/io.c
@@ -42,8 +42,8 @@ static void bdrv_parent_cb_resize(BlockDriverState *bs);
static int coroutine_fn bdrv_co_do_pwrite_zeroes(BlockDriverState *bs,
int64_t offset, int bytes, BdrvRequestFlags flags);
-void bdrv_parent_drained_begin(BlockDriverState *bs, BdrvChild *ignore,
- bool ignore_bds_parents)
+static void bdrv_parent_drained_begin(BlockDriverState *bs, BdrvChild *ignore,
+ bool ignore_bds_parents)
{
BdrvChild *c, *next;
@@ -64,8 +64,8 @@ void bdrv_parent_drained_end_single(BdrvChild *c)
}
}
-void bdrv_parent_drained_end(BlockDriverState *bs, BdrvChild *ignore,
- bool ignore_bds_parents)
+static void bdrv_parent_drained_end(BlockDriverState *bs, BdrvChild *ignore,
+ bool ignore_bds_parents)
{
BdrvChild *c, *next;
--
2.21.0
- [Qemu-devel] [PATCH v3 00/10] block: Delay poll when ending drained sections, Max Reitz, 2019/07/19
- [Qemu-devel] [PATCH v3 01/10] block: Introduce BdrvChild.parent_quiesce_counter, Max Reitz, 2019/07/19
- [Qemu-devel] [PATCH v3 02/10] tests: Add job commit by drained_end test, Max Reitz, 2019/07/19
- [Qemu-devel] [PATCH v3 03/10] block: Add @drained_end_counter, Max Reitz, 2019/07/19
- [Qemu-devel] [PATCH v3 04/10] block: Make bdrv_parent_drained_[^_]*() static,
Max Reitz <=
- [Qemu-devel] [PATCH v3 05/10] tests: Lock AioContexts in test-block-iothread, Max Reitz, 2019/07/19
- [Qemu-devel] [PATCH v3 06/10] block: Do not poll in bdrv_do_drained_end(), Max Reitz, 2019/07/19
- [Qemu-devel] [PATCH v3 07/10] tests: Extend commit by drained_end test, Max Reitz, 2019/07/19
- [Qemu-devel] [PATCH v3 08/10] block: Loop unsafely in bdrv*drained_end(), Max Reitz, 2019/07/19
- [Qemu-devel] [PATCH v3 09/10] iotests: Add @has_quit to vm.shutdown(), Max Reitz, 2019/07/19
- [Qemu-devel] [PATCH v3 10/10] iotests: Test commit with a filter on the chain, Max Reitz, 2019/07/19
- Re: [Qemu-devel] [PATCH v3 00/10] block: Delay poll when ending drained sections, Kevin Wolf, 2019/07/19