Re: [Qemu-devel] [PATCH for 4.1 v4 1/5] target/mips: Add 'fall through' comments for handling nanoMips' SHXS, SWXS

[Aleksandar Rikalo]

> From: Aleksandar Markovic <address@hidden>
> Sent: Monday, July 15, 2019 10:00 PM
> To: address@hidden
> Cc: address@hidden; Aleksandar Markovic; Aleksandar Rikalo
> Subject: [PATCH for 4.1 v4 1/5] target/mips: Add 'fall through' comments for 
> handling nanoMips' SHXS, SWXS
>
> From: Aleksandar Markovic <address@hidden>
>
> This was found by GCC 8.3 static analysis.
>
> Signed-off-by: Aleksandar Markovic <address@hidden>
> ---
>  target/mips/translate.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/target/mips/translate.c b/target/mips/translate.c
> index f96f141..2be5e2d 100644
> --- a/target/mips/translate.c
> +++ b/target/mips/translate.c
> @@ -20136,12 +20136,14 @@ static void gen_p_lsx(DisasContext *ctx, int rd, 
> int rs, int rt)
>          switch (extract32(ctx->opcode, 7, 4)) {
>          case NM_SHXS:
>              check_nms(ctx);
> +            /* fall through */
>          case NM_LHXS:
>          case NM_LHUXS:
>              tcg_gen_shli_tl(t0, t0, 1);
>              break;
>          case NM_SWXS:
>              check_nms(ctx);
> +            /* fall through */
>          case NM_LWXS:
>          case NM_LWC1XS:
>          case NM_SWC1XS:
> --
> 2.7.4

Reviewed-by: Aleksandar Rikalo <address@hidden>