Re: [Qemu-devel] [PATCH for 4.1 v5 1/2] target/mips: Add 'fall through' comments for handling nanoMips' SHXS, SWXS

[Philippe Mathieu-Daudé]

Hi Aleksandar,

On 7/22/19 4:43 PM, Aleksandar Markovic wrote:
> From: Aleksandar Markovic <address@hidden>
> 
> This was found by GCC 8.3 static analysis.
> 

Can you add:

"Missed in commit fb32f8c8560."

So when looking at this commit the missing 'fall through' is more obvious.

> Signed-off-by: Aleksandar Markovic <address@hidden>
> Reviewed-by: Aleksandar Rikalo <address@hidden>

Reviewed-by: Philippe Mathieu-Daudé <address@hidden>

Thanks,

Phil.

> ---
>  target/mips/translate.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/target/mips/translate.c b/target/mips/translate.c
> index 3575eff..ca62800 100644
> --- a/target/mips/translate.c
> +++ b/target/mips/translate.c
> @@ -20141,12 +20141,14 @@ static void gen_p_lsx(DisasContext *ctx, int rd, 
> int rs, int rt)
>          switch (extract32(ctx->opcode, 7, 4)) {
>          case NM_SHXS:
>              check_nms(ctx);
> +            /* fall through */
>          case NM_LHXS:
>          case NM_LHUXS:
>              tcg_gen_shli_tl(t0, t0, 1);
>              break;
>          case NM_SWXS:
>              check_nms(ctx);
> +            /* fall through */
>          case NM_LWXS:
>          case NM_LWC1XS:
>          case NM_SWC1XS:
>