[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 16/23] NSIS: Add missing firmware blobs
From: |
Stefan Weil |
Subject: |
Re: [Qemu-devel] [PATCH v2 16/23] NSIS: Add missing firmware blobs |
Date: |
Tue, 23 Jul 2019 07:33:59 +0200 |
User-agent: |
Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 |
Am 22.07.2019 um 22:06 schrieb Philippe Mathieu-Daudé:
> On 7/17/19 8:23 PM, Stefan Weil wrote:
>> Am 17.07.2019 um 15:43 schrieb Alex Bennée:
>>> From: Philippe Mathieu-Daudé <address@hidden>
>>>
>>> Various firmwares has been added in the pc-bios/ directory:
>>>
>>> - CCW (since commit 0c1fecdd523)
>>> - Skiboot (since commit bcad45de6a0)
>>> - EDK2 (since commit f7fa38b74c3)
>>>
>>> Since we install qemu-system able to run the architectures
>>> targetted by these firmware, include them in the NSIS exe.
>>>
>>> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
>>> Message-Id: <address@hidden>
>>> Signed-off-by: Alex Bennée <address@hidden>
>>> ---
>>> qemu.nsi | 3 +++
>>> 1 file changed, 3 insertions(+)
>>>
>>> diff --git a/qemu.nsi b/qemu.nsi
>>> index 75f1608b9e0..89c7c04f957 100644
>>> --- a/qemu.nsi
>>> +++ b/qemu.nsi
>>> @@ -122,6 +122,9 @@ Section "${PRODUCT} (required)"
>>> File "${BINDIR}\*.bmp"
>>> File "${BINDIR}\*.bin"
>>> File "${BINDIR}\*.dtb"
>>> + File "${BINDIR}\*.fd"
>>> + File "${BINDIR}\*.img"
>>> + File "${BINDIR}\*.lid"
>>> File "${BINDIR}\*.rom"
>>> File "${BINDIR}\openbios-*"
>>>
>>
>> Hi,
>>
>> what about qemu_vga.ndrv? And all new file pattern should also be added
>> to the uninstall section.
> Good point.
>
> Alex, so you mind amending:
>
> + File "${BINDIR}\*.ndrv"
>
> Stefan is that OK if we fix the uninstall section for the next rc or
> release?
>
> Else, Alex please drop this patch.
Sure, we can improve the NSIS script in several steps and fix the
uninstall later.
You may add a
Reviewed-by: Stefan Weil <address@hidden>
Thanks,
Stefan
- [Qemu-devel] [PATCH v2 14/23] buildsys: The NSIS Windows build requires qemu-nsis.bmp installed, (continued)
- [Qemu-devel] [PATCH v2 14/23] buildsys: The NSIS Windows build requires qemu-nsis.bmp installed, Alex Bennée, 2019/07/17
- [Qemu-devel] [PATCH v2 15/23] tests/docker: Let the test-mingw test generate a NSIS installer, Alex Bennée, 2019/07/17
- [Qemu-devel] [PATCH v2 13/23] buildsys: The NSIS Windows build requires the documentation installed, Alex Bennée, 2019/07/17
- [Qemu-devel] [PATCH v2 23/23] gitlab-ci: Remove qcow2 tests that are handled by "make check" already, Alex Bennée, 2019/07/17
- [Qemu-devel] [PATCH v2 22/23] tests: Run the iotests during "make check" again, Alex Bennée, 2019/07/17
- [Qemu-devel] [PATCH v2 16/23] NSIS: Add missing firmware blobs, Alex Bennée, 2019/07/17
- [Qemu-devel] [PATCH v2 19/23] tests/docker: invoke the DEBUG shell with --noprofile/--norc, Alex Bennée, 2019/07/17
- [Qemu-devel] [PATCH v2 21/23] tests/qemu-iotests/group: Remove some more tests from the "auto" group, Alex Bennée, 2019/07/17
- Re: [Qemu-devel] [PATCH v2 00/23] testing/next for 4.1-rc2 (win, travis, iotests), Alex Bennée, 2019/07/22