Re: [Qemu-devel] [PULL for 4.1-rc2 00/23] testing updates (green CI!)

[Philippe Mathieu-Daudé]

On 7/23/19 1:46 PM, Alex Bennée wrote:
> 
> Peter Maydell <address@hidden> writes:
> 
>> On Tue, 23 Jul 2019 at 11:36, Alex Bennée <address@hidden> wrote:
>>>
>>> The following changes since commit 23da9e297b4120ca9702cabec91599a44255fe96:
>>>
>>>   Merge remote-tracking branch 
>>> 'remotes/pmaydell/tags/pull-target-arm-20190722' into staging (2019-07-22 
>>> 15:16:48 +0100)
>>>
>>> are available in the Git repository at:
>>>
>>>   https://github.com/stsquad/qemu.git tags/pull-testing-230719-1
>>>
>>> for you to fetch changes up to 2e3b8743cd66f1d0fbc83051b0b6b072a97460cc:
>>>
>>>   gitlab-ci: Remove qcow2 tests that are handled by "make check" already 
>>> (2019-07-23 11:33:15 +0100)
>>>
>>> ----------------------------------------------------------------
>>> Final testing updates:
>>>
>>>   - docker sphinx updates
>>>   - windows build re-enabled in CI
>>>   - travis_retry for make check
>>>   - quick iotests enabled for make check
>>>   - build fixes
>>>
>>> ----------------------------------------------------------------
>>
>> 'make check-tcg' fails (x86-64 host):
>>
>> make: Entering directory
>> '/home/petmay01/linaro/qemu-for-merges/build/all-linux-static'
>>   BUILD   debian10
>> The command '/bin/sh -c DEBIAN_FRONTEND=noninteractive eatmydata
>> apt install -y --no-install-recommends         bison
>> build-essential         ca-certificates         clang         flex
>>     gettext         git         pkg-config         psmisc
>> python         python3-sphinx         texinfo         $(apt-get -s
>> build-dep qemu | egrep ^Inst | fgrep '[all]' | cut -d\  -f2)' returned
>> a non-zero code: 100
>> Traceback (most recent call last):
>>   File "/home/petmay01/linaro/qemu-for-merges/tests/docker/docker.py",
>> line 615, in <module>
>>     sys.exit(main())
>>   File "/home/petmay01/linaro/qemu-for-merges/tests/docker/docker.py",
>> line 611, in main
>>     return args.cmdobj.run(args, argv)
>>   File "/home/petmay01/linaro/qemu-for-merges/tests/docker/docker.py",
>> line 413, in run
>>     extra_files_cksum=cksum)
>>   File "/home/petmay01/linaro/qemu-for-merges/tests/docker/docker.py",
>> line 280, in build_image
>>     quiet=quiet)
>>   File "/home/petmay01/linaro/qemu-for-merges/tests/docker/docker.py",
>> line 207, in _do_check
>>     return subprocess.check_call(self._command + cmd, **kwargs)
>>   File "/usr/lib/python2.7/subprocess.py", line 190, in check_call
>>     raise CalledProcessError(retcode, cmd)
>> subprocess.CalledProcessError: Command '['docker', 'build', '-t',
>> 'qemu:debian10', '-f', '/tmp/docker_buildBgZdCD/tmp6MJLiZ.docker',
>> '/tmp/docker_buildBgZdCD']' returned non-zero exit status 100
>> /home/petmay01/linaro/qemu-for-merges/tests/docker/Makefile.include:53:
>> recipe for target 'docker-image-debian10' failed

Yes, we should definitively improve this error report.

>> make: *** [docker-image-debian10] Error 1
>> make: Leaving directory
>> '/home/petmay01/linaro/qemu-for-merges/build/all-linux-static'
> 
> Odd. Does:
> 
>   make docker-image-debian10 V=1
> 
> fail for you? Can you retry with:
> 
>   make docker-image-debian10 V=1 NOCACHE=1

Should we use a stable tag for the stable release? Such:

-- >8 --
diff --git a/tests/docker/dockerfiles/debian10.docker
b/tests/docker/dockerfiles/debian10.docker
index aeeb151b52..0f2800377d 100644
--- a/tests/docker/dockerfiles/debian10.docker
+++ b/tests/docker/dockerfiles/debian10.docker
@@ -7,7 +7,7 @@
 # On its own you can't build much but the docker-foo-cross targets
 # build on top of the base debian image.
 #
-FROM debian:buster-slim
+FROM debian:buster-20190708-slim

 # Duplicate deb line as deb-src
---

>>
>> I also got a failure with openbsd which seems to be when
>> the tests run check-block.sh:
>>
>> /home/qemu/qemu-test.Dy1Aj3/src/tests/check-block.sh
>>   TEST    iotest-qcow2: 001
>>   TEST    iotest-qcow2: 002
>>   TEST    iotest-qcow2: 003
>>   TEST    iotest-qcow2: 004
>>   TEST    iotest-qcow2: 005 [not run]
>>   TEST    iotest-qcow2: 007 [fail]
>> QEMU          --
>> "/home/qemu/qemu-test.Dy1Aj3/build/tests/qemu-iotests/../../aarch64-softmmu/qemu-system-aarch64"
>> -nodefaults -machine virt,accel=qtest
>> QEMU_IMG      --
>> "/home/qemu/qemu-test.Dy1Aj3/build/tests/qemu-iotests/../../qemu-img"
>> QEMU_IO       --
>> "/home/qemu/qemu-test.Dy1Aj3/build/tests/qemu-iotests/../../qemu-io"
>> --cache writeback -f qcow2
>> QEMU_NBD      --
>> "/home/qemu/qemu-test.Dy1Aj3/build/tests/qemu-iotests/../../qemu-nbd"
>> IMGFMT        -- qcow2 (compat=1.1)
>> IMGPROTO      -- file
>> PLATFORM      -- OpenBSD/amd64 openbsd 6.5
>> TEST_DIR      -- /home/qemu/qemu-test.Dy1Aj3/build/tests/qemu-iotests/scratch
>> SOCKET_SCM_HELPER --
>>
>> --- /home/qemu/qemu-test.Dy1Aj3/src/tests/qemu-iotests/007.out  Tue
>> Jul 23 10:49:15 2019
>> +++ /home/qemu/qemu-test.Dy1Aj3/build/tests/qemu-iotests/007.out.bad
>>  Tue Jul 23 11:10:21 2019
>> @@ -2,16 +2,7 @@
>>
>>  creating image
>>  Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=1048576
>> -savevm 1
>> -savevm 2
>> -savevm 3
>> -savevm 4
>> -savevm 5
>> -savevm 6
>> -savevm 7
>> -savevm 8
>> -savevm 9
>> -savevm 10
>> +./007: line 51: seq: command not found
>>
>> [and some other failures]
>>
>> I see Thomas Huth has a patch on-list for that, but this
>> didn't manifest as a problem before this pullreq.
> 
> OK, I'll add it and rebuild the PR.

But Thomas got another error later...

> 
> Have you noticed any issues with check-acceptance?
> 
>>
>> thanks
>> -- PMM
> 
> 
> --
> Alex Bennée
>