[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 1/2] elf-ops.h: Map into memory the ELF to lo
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 1/2] elf-ops.h: Map into memory the ELF to load |
|
Date: |
Tue, 23 Jul 2019 17:00:22 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 |
On 23/07/19 16:57, Stefano Garzarella wrote:
> On Tue, Jul 23, 2019 at 04:33:44PM +0200, Paolo Bonzini wrote:
>> Since this is the only call to rom_add_elf_program, what about adding a
>> GMappedFile* field to struct Rom and passing it here instead of
>> data+file_size?
>
> Ehm, we currently use a subsection of the mmapped file as a ROM.
> Should we keep the data+file_size parameter? (plus the new GMappedFile*)
Yes, either that or an offset/file_size.
> At this point, is it better to call 'g_mapped_file_ref(gmf)' in the
> 'rom_add_elf_program()'?
Yes, of course.
Paolo