|
| From: | Paolo Bonzini |
| Subject: | Re: [Qemu-devel] [PATCH for-4.2 14/14] icount: clean up cpu_can_io before jumping to the next block |
| Date: | Thu, 25 Jul 2019 08:27:13 +0200 |
| User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 |
On 25/07/19 07:55, Pavel Dovgalyuk wrote: >> >> I think you do not need this patch if you remove the assignment in >> cpu_tb_exec, and compile a "move 0 to cpu->can_do_io" in gen_tb_start >> instead. > "move 0 to cpu->can_do_io" only for icount mode? Yes, using CF_ICOUNT. > And we'll also need to set can_do_io to 1 somewhere, because it > is checked in non-icount mode too. It is already set in qemu_tcg_cpu_thread_fn. Paolo
| [Prev in Thread] | Current Thread | [Next in Thread] |