qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v4 0/3] restrict bridge interface name to IFNAMS


From: Jason Wang
Subject: Re: [Qemu-devel] [PATCH v4 0/3] restrict bridge interface name to IFNAMSIZ
Date: Fri, 26 Jul 2019 18:26:08 +0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0


On 2019/7/23 下午6:47, P J P wrote:
From: Prasad J Pandit <address@hidden>

Hello,

Linux net_deivce defines network interface name to be of IFNAMSIZE(=16)
bytes, including the terminating null('\0') byte.

Qemu tap deivce, while invoking 'qemu-bridge-helper' tool to set up the
network bridge interface, supplies bridge name of 16 characters, thus
allowing to create an ACL bypass scenario.

This patch series attempts to fix it. It also updates bridge helper
invocation routine 'net_bridge_run_helper' to avoid snprintf() calls.

Thank you.
--
Prasad J Pandit (3):
   qemu-bridge-helper: restrict interface name to IFNAMSIZ
   qemu-bridge-helper: move repeating code in parse_acl_file
   net: tap: replace snprintf with g_strdup_printf calls

  net/tap.c            | 19 +++++++++++--------
  qemu-bridge-helper.c | 24 +++++++++++++++++-------
  2 files changed, 28 insertions(+), 15 deletions(-)


Applied.

Thanks




reply via email to

[Prev in Thread] Current Thread [Next in Thread]