[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [for-4.2 PATCH 2/6] replay: disable default snapshot for re
From: |
Pavel Dovgalyuk |
Subject: |
[Qemu-devel] [for-4.2 PATCH 2/6] replay: disable default snapshot for record/replay |
Date: |
Mon, 29 Jul 2019 09:29:36 +0300 |
User-agent: |
StGit/0.17.1-dirty |
From: Pavel Dovgalyuk <address@hidden>
This patch disables setting '-snapshot' option on by default
in record/replay mode. This is needed for creating vmstates in record
and replay modes.
Signed-off-by: Pavel Dovgalyuk <address@hidden>
Acked-by: Kevin Wolf <address@hidden>
---
vl.c | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/vl.c b/vl.c
index b426b32134..b73fd078a8 100644
--- a/vl.c
+++ b/vl.c
@@ -1202,7 +1202,7 @@ static void configure_blockdev(BlockdevOptionsQueue
*bdo_queue,
qapi_free_BlockdevOptions(bdo->bdo);
g_free(bdo);
}
- if (snapshot || replay_mode != REPLAY_MODE_NONE) {
+ if (snapshot) {
qemu_opts_foreach(qemu_find_opts("drive"), drive_enable_snapshot,
NULL, NULL);
}
@@ -3051,7 +3051,13 @@ int main(int argc, char **argv, char **envp)
drive_add(IF_PFLASH, -1, optarg, PFLASH_OPTS);
break;
case QEMU_OPTION_snapshot:
- snapshot = 1;
+ {
+ Error *blocker = NULL;
+ snapshot = 1;
+ error_setg(&blocker, QERR_REPLAY_NOT_SUPPORTED,
+ "-snapshot");
+ replay_add_blocker(blocker);
+ }
break;
case QEMU_OPTION_numa:
opts = qemu_opts_parse_noisily(qemu_find_opts("numa"),
- [Qemu-devel] [for-4.2 PATCH 0/6] Block-related record/replay fixes, Pavel Dovgalyuk, 2019/07/29
- [Qemu-devel] [for-4.2 PATCH 1/6] block: implement bdrv_snapshot_goto for blkreplay, Pavel Dovgalyuk, 2019/07/29
- [Qemu-devel] [for-4.2 PATCH 2/6] replay: disable default snapshot for record/replay,
Pavel Dovgalyuk <=
- [Qemu-devel] [for-4.2 PATCH 3/6] replay: update docs for record/replay with block devices, Pavel Dovgalyuk, 2019/07/29
- [Qemu-devel] [for-4.2 PATCH 4/6] replay: don't drain/flush bdrv queue while RR is working, Pavel Dovgalyuk, 2019/07/29
- [Qemu-devel] [for-4.2 PATCH 5/6] replay: finish record/replay before closing the disks, Pavel Dovgalyuk, 2019/07/29
- [Qemu-devel] [for-4.2 PATCH 6/6] replay: add BH oneshot event for block layer, Pavel Dovgalyuk, 2019/07/29
- Re: [Qemu-devel] [for-4.2 PATCH 0/6] Block-related record/replay fixes, no-reply, 2019/07/29
- Re: [Qemu-devel] [for-4.2 PATCH 0/6] Block-related record/replay fixes, no-reply, 2019/07/29