Re: [Qemu-devel] [PATCH for 4.1 v2 7/7] linux-user: Add support for semtimedop() syscall

[Laurent Vivier]

Le 29/07/2019 à 15:26, Aleksandar Markovic a écrit :
> 
> 
> On Mon, Jul 29, 2019 at 3:11 PM Aleksandar Markovic
> <address@hidden <mailto:address@hidden>>
> wrote:
> 
>     From: Aleksandar Rikalo <address@hidden
>     <mailto:address@hidden>>
> 
>     Add support for semtimedop() emulation. It is based on invocation
>     of safe_semtimedop().
> 
>     Conversion is left out of safe_semtimedop(), since other safe_xxx()
>     usually don't contain similar conversions.
> 
>     Signed-off-by: Aleksandar Rikalo <address@hidden
>     <mailto:address@hidden>>
>     Signed-off-by: Aleksandar Markovic <address@hidden
>     <mailto:address@hidden>>
>     ---
> 
> 
> Aleksandar R., Laurent,
> 
> Please note that I just rebased the patch compared to its last
> incarnation - no code change.
> 
> Laurent's hints were as follows last time:
> 
> "To avoid duplicate code (and cleanup the stack allocation), you should
> 
> remove do_semop()  and call do_semtimedop(..., NULL) from IPCOP_semop
> and TARGET_NR_semop.
> 
> Thanks, Laurent"
> 
>  I guess they are still valid.

Yes, I didn't remember my comment and do the same again...

Thanks,
Laurent