Re: [Qemu-devel] [RFC] virtio-mmio: implement modern (v2) personality (virtio-1)

[Stefan Hajnoczi]

On Mon, Jul 29, 2019 at 02:57:55PM +0200, Sergio Lopez wrote:
> @@ -162,12 +183,34 @@ static uint64_t virtio_mmio_read(void *opaque, hwaddr 
> offset, unsigned size)
>          }
>          return VIRTQUEUE_MAX_SIZE;
>      case VIRTIO_MMIO_QUEUE_PFN:
> +        if (proxy->modern) {
> +            qemu_log_mask(LOG_GUEST_ERROR,
> +                          "%s: read from legacy register in modern mode\n",
> +                          __func__);

If you respin this series it would be nice to indicate which register
was accessed since these error messages are identical for the other
modern registers and there is no way to distinguish for troubleshooting.

Reviewed-by: Stefan Hajnoczi <address@hidden>

signature.asc
Description: PGP signature