[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] vhost-vsock: report QMP event when set running
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH] vhost-vsock: report QMP event when set running |
Date: |
Tue, 30 Jul 2019 08:19:41 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 |
On 7/30/19 7:24 AM, N. B. wrote:
> From: Ning Bo <address@hidden>
>
> Report vsock running event so that the upper application can
> control boot sequence.
> see https://github.com/kata-containers/runtime/pull/1918
>
> Signed-off-by: Ning Bo <address@hidden>
Your From: and S-o-b: differ from one another, which can make crawling
through git history in search of contributor statistics a bit harder.
Can you fix your git settings to use the same address in both places,
and/or contribute a patch to .mailmap to consolidate your contributions
under a single preferred address?
> ---
> hw/virtio/vhost-vsock.c | 3 +++
> qapi/char.json | 22 ++++++++++++++++++++++
> 2 files changed, 25 insertions(+)
>
> +++ b/qapi/char.json
> @@ -570,3 +570,25 @@
> { 'event': 'VSERPORT_CHANGE',
> 'data': { 'id': 'str',
> 'open': 'bool' } }
> +
> +##
> +# @VSOCK_RUNNING:
> +#
> +# Emitted when the guest be set running.
s/be set running/changes the vsock status/
> +#
> +# @cid: guest context ID
> +#
> +# @running: true if the vsock be set running
s/be set/is/
> +#
> +# Since: v4.1.0
Not our typical spelling, and as a new feature it is too late for 4.1.
This should read:
# Since: 4.2
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature