Re: [Qemu-devel] [PATCH v3 25/50] translator: add translator_ld{ub, sw, uw, l, q}

[Alex Bennée]

Richard Henderson <address@hidden> writes:

> On 7/30/19 5:41 AM, Alex Bennée wrote:
>> Do we ever need _code access that isn't part of the
>> translator loading instructions?
>
> We use it; I'm not sure that's the same as need.  ;-)

Yeah I've run into others (e.g. alpha alpha_cpu_do_unaligned_access). So
the question is do I attempt to deprecate code load in this series?

> Lots of the uses that I examined should use a mechanism
> like arm does for recording syndrome data in the unwind slots.

Yeah - hence the semihosting fixups. ATM we only touch translator_loop
guests but deprecating means having to do them all. Maybe we could
poison the build someway and ensure as each legacy translation is
converted to translator_loop we convert the _code use functions there.

> Quite possibly the only legitimate use is sparc, where it
> has an alternate address space that reads with execute permission.
> We could probably find a different way to accomplish that
> if we removed the *_code helpers.
>
>
> r~


--
Alex Bennée