[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-4.1 2/2] iotests/118: Test inserting a read-
|
From: |
Max Reitz |
|
Subject: |
Re: [Qemu-devel] [PATCH for-4.1 2/2] iotests/118: Test inserting a read-only medium |
|
Date: |
Tue, 30 Jul 2019 17:24:38 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 |
On 30.07.19 16:57, Kevin Wolf wrote:
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> tests/qemu-iotests/118 | 6 +++++-
> tests/qemu-iotests/118.out | 4 ++--
> 2 files changed, 7 insertions(+), 3 deletions(-)
Personally, I wouldn’t mind a
self.assert_qmp(result, 'return[0]/inserted/ro', read_only_node)
at the end of test_cycle(), but oh well:
Reviewed-by: Max Reitz <address@hidden>
(We’d also want it in other places, e.g. test_tray_open_change() should
check that it’s always False for floppy disks, and True for CDs.)
signature.asc
Description: OpenPGP digital signature