Re: [Qemu-devel] [PATCH v4 0/1] configure: Define target access alignment in configure

[Alex Bennée]

address@hidden writes:

> Move the define of target access alignment earlier from
> target/foo/cpu.h to configure.
>
> Suggested in Richard Henderson's reply to "[PATCH 1/4] tcg: TCGMemOp
> is now accelerator independent MemOp"
>
> Analysed target/foo/cpu.h for more candidates to define earlier but
> did not spot any other straight forward predicates.
>
> Possible future clean ups:
> - TCG_GUEST_DEFAULT_MO and TCG_TARGET_DEFAULT_MO seems like duplicates

These aren't duplicates. This is used to work out if the host memory
order is compatible with running the guest under TCG with multiple
threads (MTTCG). See check_tcg_memory_orders_compatible.

> - TARGET_INSN_START_EXTRA_WORDS 1 seems redundant as ifndef value is 1
>
> v2:
> - split cosmetic changes into separate patch
> - cc corresponding maintainers
>
> v3:
> - dropped cosmetic changes
> - improved commit message
>
> v4:
> - further improved commit message
>
> Tony Nguyen (1):
>   configure: Define TARGET_ALIGNED_ONLY in configure
>
>  configure             | 10 +++++++++-
>  include/exec/poison.h |  1 +
>  include/qom/cpu.h     |  2 +-
>  target/alpha/cpu.h    |  2 --
>  target/hppa/cpu.h     |  1 -
>  target/mips/cpu.h     |  2 --
>  target/sh4/cpu.h      |  2 --
>  target/sparc/cpu.h    |  2 --
>  target/xtensa/cpu.h   |  2 --
>  tcg/tcg.c             |  2 +-
>  tcg/tcg.h             |  8 +++++---
>  11 files changed, 17 insertions(+), 17 deletions(-)


--
Alex Bennée