Re: [Qemu-devel] [RFC PATCH v1 00/22] reimplement (some) x86 vector inst

qemu-devel
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH v1 00/22] reimplement (some) x86 vector inst

From:	no-reply
Subject:	Re: [Qemu-devel] [RFC PATCH v1 00/22] reimplement (some) x86 vector instructions using tcg-gvec
Date:	Wed, 31 Jul 2019 12:21:14 -0700 (PDT)
Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: address@hidden
Type: series
Subject: [Qemu-devel] [RFC PATCH v1 00/22] reimplement (some) x86 vector 
instructions using tcg-gvec

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

From https://github.com/patchew-project/qemu
 t [tag update]            patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
e2438c48fc target/i386: reimplement (V)P(EQ, CMP)(B, W, D)
4c83ed32e8 target/i386: reimplement (V)PMAXUB
dfde70d5c7 target/i386: reimplement (V)PMAXSW
3062bca413 target/i386: reimplement (V)PMINUB
121c2e52e8 target/i386: reimplement (V)PMINSW
944c0e98d2 target/i386: reimplement (V)PSUBUS(B, W)
34accebf3d target/i386: reimplement (V)PSUBS(B, W)
76c9dc0f39 target/i386: reimplement (V)PADDUS(B, W)
066ed674ee target/i386: reimplement (V)PADDS(B, W)
917f7d51ac target/i386: reimplement (V)PSUB(B, W, D, Q)
9f2a4e2bfa target/i386: reimplement (V)PADD(B, W, D, Q)
ddb637d6a4 target/i386: reimplement (V)PANDN, (V)ANDNPS, (V)ANDNPD
4558786faa target/i386: reimplement (V)PXOR, (V)XORPS, (V)XORPD
fe6b414735 target/i386: reimplement (V)POR, (V)ORPS, (V)ORPD
4cd94d3225 target/i386: reimplement (V)PAND, (V)ANDPS, (V)ANDPD
7c39e7aeaa target/i386: add vector register file alignment constraints
8ce334d91c target/i386: introduce gen_gvec_ld_modrm_* helpers
ec7c250e83 target/i386: introduce gen_ld_modrm_* helpers
eef2fd456b target/i386: Simplify gen_exception arguments
6273f91cf3 target/i386: Use prefix, aflag and dflag from DisasContext
6405677dbd target/i386: Push rex_w into DisasContext
0bac241111 target/i386: Push rex_r into DisasContext

=== OUTPUT BEGIN ===
1/22 Checking commit 0bac2411117e (target/i386: Push rex_r into DisasContext)
2/22 Checking commit 6405677dbd77 (target/i386: Push rex_w into DisasContext)
3/22 Checking commit 6273f91cf368 (target/i386: Use prefix, aflag and dflag 
from DisasContext)
4/22 Checking commit eef2fd456b74 (target/i386: Simplify gen_exception 
arguments)
5/22 Checking commit ec7c250e837b (target/i386: introduce gen_ld_modrm_* 
helpers)
WARNING: line over 80 characters
#22: FILE: target/i386/translate.c:3043:
+static inline void gen_ld_modrm_PqQq(CPUX86State *env, DisasContext *s, int 
modrm,

ERROR: "foo* bar" should be "foo *bar"
#23: FILE: target/i386/translate.c:3044:
+                                     uint32_t* dofs, uint32_t* aofs)

ERROR: space required before the open parenthesis '('
#29: FILE: target/i386/translate.c:3050:
+    if(mod == 3) {

WARNING: line over 80 characters
#41: FILE: target/i386/translate.c:3062:
+static inline void gen_ld_modrm_VxWx(CPUX86State *env, DisasContext *s, int 
modrm,

ERROR: "foo* bar" should be "foo *bar"
#42: FILE: target/i386/translate.c:3063:
+                                     uint32_t* dofs, uint32_t* aofs)

ERROR: space required before the open parenthesis '('
#48: FILE: target/i386/translate.c:3069:
+    if(mod == 3) {

WARNING: line over 80 characters
#56: FILE: target/i386/translate.c:3077:
+        gen_ldo_env_A0(s, *aofs); /* FIXME this needs to load 32 bytes for YMM 
*/

WARNING: line over 80 characters
#60: FILE: target/i386/translate.c:3081:
+static inline void gen_ld_modrm_VxHxWx(CPUX86State *env, DisasContext *s, int 
modrm,

WARNING: line over 80 characters
#61: FILE: target/i386/translate.c:3082:
+                                       uint32_t* dofs, uint32_t* aofs, 
uint32_t* bofs)

ERROR: "foo* bar" should be "foo *bar"
#61: FILE: target/i386/translate.c:3082:
+                                       uint32_t* dofs, uint32_t* aofs, 
uint32_t* bofs)

total: 5 errors, 5 warnings, 53 lines checked

Patch 5/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

6/22 Checking commit 8ce334d91cad (target/i386: introduce gen_gvec_ld_modrm_* 
helpers)
WARNING: line over 80 characters
#21: FILE: target/i386/translate.c:3090:
+typedef void (*gen_ld_modrm_2_fp_t)(CPUX86State *env, DisasContext *s, int 
modrm,

WARNING: line over 80 characters
#23: FILE: target/i386/translate.c:3092:
+typedef void (*gen_ld_modrm_3_fp_t)(CPUX86State *env, DisasContext *s, int 
modrm,

WARNING: line over 80 characters
#24: FILE: target/i386/translate.c:3093:
+                                    uint32_t *dofs, uint32_t *aofs, uint32_t 
*bofs);

total: 0 errors, 3 warnings, 83 lines checked

Patch 6/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
7/22 Checking commit 7c39e7aeaa89 (target/i386: add vector register file 
alignment constraints)
8/22 Checking commit 4cd94d32253d (target/i386: reimplement (V)PAND, (V)ANDPS, 
(V)ANDPD)
ERROR: line over 90 characters
#92: FILE: target/i386/translate.c:3169:
+#define gen_pand_mm(env, s, modrm)   gen_gvec_ld_modrm_mm  ((env), (s), 
(modrm), MO_64, tcg_gen_gvec_and, 0112)

ERROR: space prohibited between function name and open parenthesis '('
#92: FILE: target/i386/translate.c:3169:
+#define gen_pand_mm(env, s, modrm)   gen_gvec_ld_modrm_mm  ((env), (s), 
(modrm), MO_64, tcg_gen_gvec_and, 0112)

ERROR: line over 90 characters
#93: FILE: target/i386/translate.c:3170:
+#define gen_pand_xmm(env, s, modrm)  gen_gvec_ld_modrm_xmm ((env), (s), 
(modrm), MO_64, tcg_gen_gvec_and, 0112)

ERROR: space prohibited between function name and open parenthesis '('
#93: FILE: target/i386/translate.c:3170:
+#define gen_pand_xmm(env, s, modrm)  gen_gvec_ld_modrm_xmm ((env), (s), 
(modrm), MO_64, tcg_gen_gvec_and, 0112)

ERROR: line over 90 characters
#94: FILE: target/i386/translate.c:3171:
+#define gen_vpand_xmm(env, s, modrm) gen_gvec_ld_modrm_vxmm((env), (s), 
(modrm), MO_64, tcg_gen_gvec_and, 0123)

ERROR: line over 90 characters
#95: FILE: target/i386/translate.c:3172:
+#define gen_vpand_ymm(env, s, modrm) gen_gvec_ld_modrm_vymm((env), (s), 
(modrm), MO_64, tcg_gen_gvec_and, 0123)

ERROR: space required before the open parenthesis '('
#122: FILE: target/i386/translate.c:3266:
+    switch(b | M_0F

ERROR: trailing statements should be on next line
#127: FILE: target/i386/translate.c:3271:
+    case 0xdb | M_0F:                  gen_pand_mm(env, s, modrm); return;

ERROR: trailing statements should be on next line
#128: FILE: target/i386/translate.c:3272:
+    case 0xdb | M_0F | P_66:           gen_pand_xmm(env, s, modrm); return;

ERROR: trailing statements should be on next line
#129: FILE: target/i386/translate.c:3273:
+    case 0xdb | M_0F | P_66 | VEX_128: gen_vpand_xmm(env, s, modrm); return;

ERROR: trailing statements should be on next line
#130: FILE: target/i386/translate.c:3274:
+    case 0xdb | M_0F | P_66 | VEX_256: gen_vpand_ymm(env, s, modrm); return;

ERROR: trailing statements should be on next line
#131: FILE: target/i386/translate.c:3275:
+    case 0x54 | M_0F:                  gen_andps_xmm(env, s, modrm); return;

ERROR: trailing statements should be on next line
#132: FILE: target/i386/translate.c:3276:
+    case 0x54 | M_0F | VEX_128:        gen_vandps_xmm(env, s, modrm); return;

ERROR: trailing statements should be on next line
#133: FILE: target/i386/translate.c:3277:
+    case 0x54 | M_0F | VEX_256:        gen_vandps_ymm(env, s, modrm); return;

ERROR: trailing statements should be on next line
#134: FILE: target/i386/translate.c:3278:
+    case 0x54 | M_0F | P_66:           gen_andpd_xmm(env, s, modrm); return;

ERROR: trailing statements should be on next line
#135: FILE: target/i386/translate.c:3279:
+    case 0x54 | M_0F | P_66 | VEX_128: gen_vandpd_xmm(env, s, modrm); return;

ERROR: trailing statements should be on next line
#136: FILE: target/i386/translate.c:3280:
+    case 0x54 | M_0F | P_66 | VEX_256: gen_vandpd_ymm(env, s, modrm); return;

ERROR: trailing statements should be on next line
#137: FILE: target/i386/translate.c:3281:
+    default: break;

total: 18 errors, 0 warnings, 106 lines checked

Patch 8/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

9/22 Checking commit fe6b41473554 (target/i386: reimplement (V)POR, (V)ORPS, 
(V)ORPD)
ERROR: line over 90 characters
#70: FILE: target/i386/translate.c:3180:
+#define gen_por_mm(env, s, modrm)   gen_gvec_ld_modrm_mm  ((env), (s), 
(modrm), MO_64, tcg_gen_gvec_or, 0112)

ERROR: space prohibited between function name and open parenthesis '('
#70: FILE: target/i386/translate.c:3180:
+#define gen_por_mm(env, s, modrm)   gen_gvec_ld_modrm_mm  ((env), (s), 
(modrm), MO_64, tcg_gen_gvec_or, 0112)

ERROR: line over 90 characters
#71: FILE: target/i386/translate.c:3181:
+#define gen_por_xmm(env, s, modrm)  gen_gvec_ld_modrm_xmm ((env), (s), 
(modrm), MO_64, tcg_gen_gvec_or, 0112)

ERROR: space prohibited between function name and open parenthesis '('
#71: FILE: target/i386/translate.c:3181:
+#define gen_por_xmm(env, s, modrm)  gen_gvec_ld_modrm_xmm ((env), (s), 
(modrm), MO_64, tcg_gen_gvec_or, 0112)

ERROR: line over 90 characters
#72: FILE: target/i386/translate.c:3182:
+#define gen_vpor_xmm(env, s, modrm) gen_gvec_ld_modrm_vxmm((env), (s), 
(modrm), MO_64, tcg_gen_gvec_or, 0123)

ERROR: line over 90 characters
#73: FILE: target/i386/translate.c:3183:
+#define gen_vpor_ymm(env, s, modrm) gen_gvec_ld_modrm_vymm((env), (s), 
(modrm), MO_64, tcg_gen_gvec_or, 0123)

ERROR: trailing statements should be on next line
#89: FILE: target/i386/translate.c:3293:
+    case 0xeb | M_0F:                  gen_por_mm(env, s, modrm); return;

ERROR: trailing statements should be on next line
#90: FILE: target/i386/translate.c:3294:
+    case 0xeb | M_0F | P_66:           gen_por_xmm(env, s, modrm); return;

ERROR: trailing statements should be on next line
#91: FILE: target/i386/translate.c:3295:
+    case 0xeb | M_0F | P_66 | VEX_128: gen_vpor_xmm(env, s, modrm); return;

ERROR: trailing statements should be on next line
#92: FILE: target/i386/translate.c:3296:
+    case 0xeb | M_0F | P_66 | VEX_256: gen_vpor_ymm(env, s, modrm); return;

ERROR: trailing statements should be on next line
#93: FILE: target/i386/translate.c:3297:
+    case 0x56 | M_0F:                  gen_orps_xmm(env, s, modrm); return;

ERROR: trailing statements should be on next line
#94: FILE: target/i386/translate.c:3298:
+    case 0x56 | M_0F | VEX_128:        gen_vorps_xmm(env, s, modrm); return;

ERROR: trailing statements should be on next line
#95: FILE: target/i386/translate.c:3299:
+    case 0x56 | M_0F | VEX_256:        gen_vorps_ymm(env, s, modrm); return;

ERROR: trailing statements should be on next line
#96: FILE: target/i386/translate.c:3300:
+    case 0x56 | M_0F | P_66:           gen_orpd_xmm(env, s, modrm); return;

ERROR: trailing statements should be on next line
#97: FILE: target/i386/translate.c:3301:
+    case 0x56 | M_0F | P_66 | VEX_128: gen_vorpd_xmm(env, s, modrm); return;

ERROR: trailing statements should be on next line
#98: FILE: target/i386/translate.c:3302:
+    case 0x56 | M_0F | P_66 | VEX_256: gen_vorpd_ymm(env, s, modrm); return;

total: 16 errors, 0 warnings, 72 lines checked

Patch 9/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

10/22 Checking commit 4558786faa52 (target/i386: reimplement (V)PXOR, (V)XORPS, 
(V)XORPD)
ERROR: line over 90 characters
#70: FILE: target/i386/translate.c:3191:
+#define gen_pxor_mm(env, s, modrm)   gen_gvec_ld_modrm_mm  ((env), (s), 
(modrm), MO_64, tcg_gen_gvec_xor, 0112)

ERROR: space prohibited between function name and open parenthesis '('
#70: FILE: target/i386/translate.c:3191:
+#define gen_pxor_mm(env, s, modrm)   gen_gvec_ld_modrm_mm  ((env), (s), 
(modrm), MO_64, tcg_gen_gvec_xor, 0112)

ERROR: line over 90 characters
#71: FILE: target/i386/translate.c:3192:
+#define gen_pxor_xmm(env, s, modrm)  gen_gvec_ld_modrm_xmm ((env), (s), 
(modrm), MO_64, tcg_gen_gvec_xor, 0112)

ERROR: space prohibited between function name and open parenthesis '('
#71: FILE: target/i386/translate.c:3192:
+#define gen_pxor_xmm(env, s, modrm)  gen_gvec_ld_modrm_xmm ((env), (s), 
(modrm), MO_64, tcg_gen_gvec_xor, 0112)

ERROR: line over 90 characters
#72: FILE: target/i386/translate.c:3193:
+#define gen_vpxor_xmm(env, s, modrm) gen_gvec_ld_modrm_vxmm((env), (s), 
(modrm), MO_64, tcg_gen_gvec_xor, 0123)

ERROR: line over 90 characters
#73: FILE: target/i386/translate.c:3194:
+#define gen_vpxor_ymm(env, s, modrm) gen_gvec_ld_modrm_vymm((env), (s), 
(modrm), MO_64, tcg_gen_gvec_xor, 0123)

ERROR: trailing statements should be on next line
#88: FILE: target/i386/translate.c:3315:
+    case 0xef | M_0F:                  gen_pxor_mm(env, s, modrm); return;

ERROR: trailing statements should be on next line
#89: FILE: target/i386/translate.c:3316:
+    case 0xef | M_0F | P_66:           gen_pxor_xmm(env, s, modrm); return;

ERROR: trailing statements should be on next line
#90: FILE: target/i386/translate.c:3317:
+    case 0xef | M_0F | P_66 | VEX_128: gen_vpxor_xmm(env, s, modrm); return;

ERROR: trailing statements should be on next line
#91: FILE: target/i386/translate.c:3318:
+    case 0xef | M_0F | P_66 | VEX_256: gen_vpxor_ymm(env, s, modrm); return;

ERROR: trailing statements should be on next line
#92: FILE: target/i386/translate.c:3319:
+    case 0x57 | M_0F:                  gen_xorps_xmm(env, s, modrm); return;

ERROR: trailing statements should be on next line
#93: FILE: target/i386/translate.c:3320:
+    case 0x57 | M_0F | VEX_128:        gen_vxorps_xmm(env, s, modrm); return;

ERROR: trailing statements should be on next line
#94: FILE: target/i386/translate.c:3321:
+    case 0x57 | M_0F | VEX_256:        gen_vxorps_ymm(env, s, modrm); return;

ERROR: trailing statements should be on next line
#95: FILE: target/i386/translate.c:3322:
+    case 0x57 | M_0F | P_66:           gen_xorpd_xmm(env, s, modrm); return;

ERROR: trailing statements should be on next line
#96: FILE: target/i386/translate.c:3323:
+    case 0x57 | M_0F | P_66 | VEX_128: gen_vxorpd_xmm(env, s, modrm); return;

ERROR: trailing statements should be on next line
#97: FILE: target/i386/translate.c:3324:
+    case 0x57 | M_0F | P_66 | VEX_256: gen_vxorpd_ymm(env, s, modrm); return;

total: 16 errors, 0 warnings, 71 lines checked

Patch 10/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

11/22 Checking commit ddb637d6a452 (target/i386: reimplement (V)PANDN, 
(V)ANDNPS, (V)ANDNPD)
ERROR: line over 90 characters
#73: FILE: target/i386/translate.c:3180:
+#define gen_pandn_mm(env, s, modrm)   gen_gvec_ld_modrm_mm  ((env), (s), 
(modrm), MO_64, tcg_gen_gvec_andc, 0121)

ERROR: space prohibited between function name and open parenthesis '('
#73: FILE: target/i386/translate.c:3180:
+#define gen_pandn_mm(env, s, modrm)   gen_gvec_ld_modrm_mm  ((env), (s), 
(modrm), MO_64, tcg_gen_gvec_andc, 0121)

ERROR: line over 90 characters
#74: FILE: target/i386/translate.c:3181:
+#define gen_pandn_xmm(env, s, modrm)  gen_gvec_ld_modrm_xmm ((env), (s), 
(modrm), MO_64, tcg_gen_gvec_andc, 0121)

ERROR: space prohibited between function name and open parenthesis '('
#74: FILE: target/i386/translate.c:3181:
+#define gen_pandn_xmm(env, s, modrm)  gen_gvec_ld_modrm_xmm ((env), (s), 
(modrm), MO_64, tcg_gen_gvec_andc, 0121)

ERROR: line over 90 characters
#75: FILE: target/i386/translate.c:3182:
+#define gen_vpandn_xmm(env, s, modrm) gen_gvec_ld_modrm_vxmm((env), (s), 
(modrm), MO_64, tcg_gen_gvec_andc, 0132)

ERROR: line over 90 characters
#76: FILE: target/i386/translate.c:3183:
+#define gen_vpandn_ymm(env, s, modrm) gen_gvec_ld_modrm_vymm((env), (s), 
(modrm), MO_64, tcg_gen_gvec_andc, 0132)

ERROR: trailing statements should be on next line
#91: FILE: target/i386/translate.c:3315:
+    case 0xdf | M_0F:                  gen_pandn_mm(env, s, modrm); return;

ERROR: trailing statements should be on next line
#92: FILE: target/i386/translate.c:3316:
+    case 0xdf | M_0F | P_66:           gen_pandn_xmm(env, s, modrm); return;

ERROR: trailing statements should be on next line
#93: FILE: target/i386/translate.c:3317:
+    case 0xdf | M_0F | P_66 | VEX_128: gen_vpandn_xmm(env, s, modrm); return;

ERROR: trailing statements should be on next line
#94: FILE: target/i386/translate.c:3318:
+    case 0xdf | M_0F | P_66 | VEX_256: gen_vpandn_ymm(env, s, modrm); return;

ERROR: trailing statements should be on next line
#95: FILE: target/i386/translate.c:3319:
+    case 0x55 | M_0F:                  gen_andnps_xmm(env, s, modrm); return;

ERROR: trailing statements should be on next line
#96: FILE: target/i386/translate.c:3320:
+    case 0x55 | M_0F | VEX_128:        gen_vandnps_xmm(env, s, modrm); return;

ERROR: trailing statements should be on next line
#97: FILE: target/i386/translate.c:3321:
+    case 0x55 | M_0F | VEX_256:        gen_vandnps_ymm(env, s, modrm); return;

ERROR: trailing statements should be on next line
#98: FILE: target/i386/translate.c:3322:
+    case 0x55 | M_0F | P_66:           gen_andnpd_xmm(env, s, modrm); return;

ERROR: trailing statements should be on next line
#99: FILE: target/i386/translate.c:3323:
+    case 0x55 | M_0F | P_66 | VEX_128: gen_vandnpd_xmm(env, s, modrm); return;

ERROR: trailing statements should be on next line
#100: FILE: target/i386/translate.c:3324:
+    case 0x55 | M_0F | P_66 | VEX_256: gen_vandnpd_ymm(env, s, modrm); return;

total: 16 errors, 0 warnings, 74 lines checked

Patch 11/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

12/22 Checking commit 9f2a4e2bfa17 (target/i386: reimplement (V)PADD(B, W, D, 
Q))
ERROR: line over 90 characters
#82: FILE: target/i386/translate.c:3169:
+#define gen_padd_mm(env, s, modrm, vece)   gen_gvec_ld_modrm_mm  ((env), (s), 
(modrm), (vece), tcg_gen_gvec_add, 0112)

ERROR: space prohibited between function name and open parenthesis '('
#82: FILE: target/i386/translate.c:3169:
+#define gen_padd_mm(env, s, modrm, vece)   gen_gvec_ld_modrm_mm  ((env), (s), 
(modrm), (vece), tcg_gen_gvec_add, 0112)

ERROR: line over 90 characters
#83: FILE: target/i386/translate.c:3170:
+#define gen_padd_xmm(env, s, modrm, vece)  gen_gvec_ld_modrm_xmm ((env), (s), 
(modrm), (vece), tcg_gen_gvec_add, 0112)

ERROR: space prohibited between function name and open parenthesis '('
#83: FILE: target/i386/translate.c:3170:
+#define gen_padd_xmm(env, s, modrm, vece)  gen_gvec_ld_modrm_xmm ((env), (s), 
(modrm), (vece), tcg_gen_gvec_add, 0112)

ERROR: line over 90 characters
#84: FILE: target/i386/translate.c:3171:
+#define gen_vpadd_xmm(env, s, modrm, vece) gen_gvec_ld_modrm_vxmm((env), (s), 
(modrm), (vece), tcg_gen_gvec_add, 0123)

ERROR: line over 90 characters
#85: FILE: target/i386/translate.c:3172:
+#define gen_vpadd_ymm(env, s, modrm, vece) gen_gvec_ld_modrm_vymm((env), (s), 
(modrm), (vece), tcg_gen_gvec_add, 0123)

ERROR: trailing statements should be on next line
#94: FILE: target/i386/translate.c:3309:
+    case 0xfc | M_0F:                  gen_padd_mm(env, s, modrm, MO_8); 
return;

WARNING: line over 80 characters
#95: FILE: target/i386/translate.c:3310:
+    case 0xfc | M_0F | P_66:           gen_padd_xmm(env, s, modrm, MO_8); 
return;

ERROR: trailing statements should be on next line
#95: FILE: target/i386/translate.c:3310:
+    case 0xfc | M_0F | P_66:           gen_padd_xmm(env, s, modrm, MO_8); 
return;

WARNING: line over 80 characters
#96: FILE: target/i386/translate.c:3311:
+    case 0xfc | M_0F | P_66 | VEX_128: gen_vpadd_xmm(env, s, modrm, MO_8); 
return;

ERROR: trailing statements should be on next line
#96: FILE: target/i386/translate.c:3311:
+    case 0xfc | M_0F | P_66 | VEX_128: gen_vpadd_xmm(env, s, modrm, MO_8); 
return;

WARNING: line over 80 characters
#97: FILE: target/i386/translate.c:3312:
+    case 0xfc | M_0F | P_66 | VEX_256: gen_vpadd_ymm(env, s, modrm, MO_8); 
return;

ERROR: trailing statements should be on next line
#97: FILE: target/i386/translate.c:3312:
+    case 0xfc | M_0F | P_66 | VEX_256: gen_vpadd_ymm(env, s, modrm, MO_8); 
return;

WARNING: line over 80 characters
#99: FILE: target/i386/translate.c:3314:
+    case 0xfd | M_0F:                  gen_padd_mm(env, s, modrm, MO_16); 
return;

ERROR: trailing statements should be on next line
#99: FILE: target/i386/translate.c:3314:
+    case 0xfd | M_0F:                  gen_padd_mm(env, s, modrm, MO_16); 
return;

WARNING: line over 80 characters
#100: FILE: target/i386/translate.c:3315:
+    case 0xfd | M_0F | P_66:           gen_padd_xmm(env, s, modrm, MO_16); 
return;

ERROR: trailing statements should be on next line
#100: FILE: target/i386/translate.c:3315:
+    case 0xfd | M_0F | P_66:           gen_padd_xmm(env, s, modrm, MO_16); 
return;

WARNING: line over 80 characters
#101: FILE: target/i386/translate.c:3316:
+    case 0xfd | M_0F | P_66 | VEX_128: gen_vpadd_xmm(env, s, modrm, MO_16); 
return;

ERROR: trailing statements should be on next line
#101: FILE: target/i386/translate.c:3316:
+    case 0xfd | M_0F | P_66 | VEX_128: gen_vpadd_xmm(env, s, modrm, MO_16); 
return;

WARNING: line over 80 characters
#102: FILE: target/i386/translate.c:3317:
+    case 0xfd | M_0F | P_66 | VEX_256: gen_vpadd_ymm(env, s, modrm, MO_16); 
return;

ERROR: trailing statements should be on next line
#102: FILE: target/i386/translate.c:3317:
+    case 0xfd | M_0F | P_66 | VEX_256: gen_vpadd_ymm(env, s, modrm, MO_16); 
return;

WARNING: line over 80 characters
#104: FILE: target/i386/translate.c:3319:
+    case 0xfe | M_0F:                  gen_padd_mm(env, s, modrm, MO_32); 
return;

ERROR: trailing statements should be on next line
#104: FILE: target/i386/translate.c:3319:
+    case 0xfe | M_0F:                  gen_padd_mm(env, s, modrm, MO_32); 
return;

WARNING: line over 80 characters
#105: FILE: target/i386/translate.c:3320:
+    case 0xfe | M_0F | P_66:           gen_padd_xmm(env, s, modrm, MO_32); 
return;

ERROR: trailing statements should be on next line
#105: FILE: target/i386/translate.c:3320:
+    case 0xfe | M_0F | P_66:           gen_padd_xmm(env, s, modrm, MO_32); 
return;

WARNING: line over 80 characters
#106: FILE: target/i386/translate.c:3321:
+    case 0xfe | M_0F | P_66 | VEX_128: gen_vpadd_xmm(env, s, modrm, MO_32); 
return;

ERROR: trailing statements should be on next line
#106: FILE: target/i386/translate.c:3321:
+    case 0xfe | M_0F | P_66 | VEX_128: gen_vpadd_xmm(env, s, modrm, MO_32); 
return;

WARNING: line over 80 characters
#107: FILE: target/i386/translate.c:3322:
+    case 0xfe | M_0F | P_66 | VEX_256: gen_vpadd_ymm(env, s, modrm, MO_32); 
return;

ERROR: trailing statements should be on next line
#107: FILE: target/i386/translate.c:3322:
+    case 0xfe | M_0F | P_66 | VEX_256: gen_vpadd_ymm(env, s, modrm, MO_32); 
return;

WARNING: line over 80 characters
#109: FILE: target/i386/translate.c:3324:
+    case 0xd4 | M_0F:                  gen_padd_mm(env, s, modrm, MO_64); 
return;

ERROR: trailing statements should be on next line
#109: FILE: target/i386/translate.c:3324:
+    case 0xd4 | M_0F:                  gen_padd_mm(env, s, modrm, MO_64); 
return;

WARNING: line over 80 characters
#110: FILE: target/i386/translate.c:3325:
+    case 0xd4 | M_0F | P_66:           gen_padd_xmm(env, s, modrm, MO_64); 
return;

ERROR: trailing statements should be on next line
#110: FILE: target/i386/translate.c:3325:
+    case 0xd4 | M_0F | P_66:           gen_padd_xmm(env, s, modrm, MO_64); 
return;

WARNING: line over 80 characters
#111: FILE: target/i386/translate.c:3326:
+    case 0xd4 | M_0F | P_66 | VEX_128: gen_vpadd_xmm(env, s, modrm, MO_64); 
return;

ERROR: trailing statements should be on next line
#111: FILE: target/i386/translate.c:3326:
+    case 0xd4 | M_0F | P_66 | VEX_128: gen_vpadd_xmm(env, s, modrm, MO_64); 
return;

WARNING: line over 80 characters
#112: FILE: target/i386/translate.c:3327:
+    case 0xd4 | M_0F | P_66 | VEX_256: gen_vpadd_ymm(env, s, modrm, MO_64); 
return;

ERROR: trailing statements should be on next line
#112: FILE: target/i386/translate.c:3327:
+    case 0xd4 | M_0F | P_66 | VEX_256: gen_vpadd_ymm(env, s, modrm, MO_64); 
return;

total: 22 errors, 15 warnings, 86 lines checked

Patch 12/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

13/22 Checking commit 917f7d51ac81 (target/i386: reimplement (V)PSUB(B, W, D, 
Q))
ERROR: line over 90 characters
#75: FILE: target/i386/translate.c:3174:
+#define gen_psub_mm(env, s, modrm, vece)   gen_gvec_ld_modrm_mm  ((env), (s), 
(modrm), (vece), tcg_gen_gvec_sub, 0112)

ERROR: space prohibited between function name and open parenthesis '('
#75: FILE: target/i386/translate.c:3174:
+#define gen_psub_mm(env, s, modrm, vece)   gen_gvec_ld_modrm_mm  ((env), (s), 
(modrm), (vece), tcg_gen_gvec_sub, 0112)

ERROR: line over 90 characters
#76: FILE: target/i386/translate.c:3175:
+#define gen_psub_xmm(env, s, modrm, vece)  gen_gvec_ld_modrm_xmm ((env), (s), 
(modrm), (vece), tcg_gen_gvec_sub, 0112)

ERROR: space prohibited between function name and open parenthesis '('
#76: FILE: target/i386/translate.c:3175:
+#define gen_psub_xmm(env, s, modrm, vece)  gen_gvec_ld_modrm_xmm ((env), (s), 
(modrm), (vece), tcg_gen_gvec_sub, 0112)

ERROR: line over 90 characters
#77: FILE: target/i386/translate.c:3176:
+#define gen_vpsub_xmm(env, s, modrm, vece) gen_gvec_ld_modrm_vxmm((env), (s), 
(modrm), (vece), tcg_gen_gvec_sub, 0123)

ERROR: line over 90 characters
#78: FILE: target/i386/translate.c:3177:
+#define gen_vpsub_ymm(env, s, modrm, vece) gen_gvec_ld_modrm_vymm((env), (s), 
(modrm), (vece), tcg_gen_gvec_sub, 0123)

ERROR: trailing statements should be on next line
#87: FILE: target/i386/translate.c:3334:
+    case 0xf8 | M_0F:                  gen_psub_mm(env, s, modrm, MO_8); 
return;

WARNING: line over 80 characters
#88: FILE: target/i386/translate.c:3335:
+    case 0xf8 | M_0F | P_66:           gen_psub_xmm(env, s, modrm, MO_8); 
return;

ERROR: trailing statements should be on next line
#88: FILE: target/i386/translate.c:3335:
+    case 0xf8 | M_0F | P_66:           gen_psub_xmm(env, s, modrm, MO_8); 
return;

WARNING: line over 80 characters
#89: FILE: target/i386/translate.c:3336:
+    case 0xf8 | M_0F | P_66 | VEX_128: gen_vpsub_xmm(env, s, modrm, MO_8); 
return;

ERROR: trailing statements should be on next line
#89: FILE: target/i386/translate.c:3336:
+    case 0xf8 | M_0F | P_66 | VEX_128: gen_vpsub_xmm(env, s, modrm, MO_8); 
return;

WARNING: line over 80 characters
#90: FILE: target/i386/translate.c:3337:
+    case 0xf8 | M_0F | P_66 | VEX_256: gen_vpsub_ymm(env, s, modrm, MO_8); 
return;

ERROR: trailing statements should be on next line
#90: FILE: target/i386/translate.c:3337:
+    case 0xf8 | M_0F | P_66 | VEX_256: gen_vpsub_ymm(env, s, modrm, MO_8); 
return;

WARNING: line over 80 characters
#92: FILE: target/i386/translate.c:3339:
+    case 0xf9 | M_0F:                  gen_psub_mm(env, s, modrm, MO_16); 
return;

ERROR: trailing statements should be on next line
#92: FILE: target/i386/translate.c:3339:
+    case 0xf9 | M_0F:                  gen_psub_mm(env, s, modrm, MO_16); 
return;

WARNING: line over 80 characters
#93: FILE: target/i386/translate.c:3340:
+    case 0xf9 | M_0F | P_66:           gen_psub_xmm(env, s, modrm, MO_16); 
return;

ERROR: trailing statements should be on next line
#93: FILE: target/i386/translate.c:3340:
+    case 0xf9 | M_0F | P_66:           gen_psub_xmm(env, s, modrm, MO_16); 
return;

WARNING: line over 80 characters
#94: FILE: target/i386/translate.c:3341:
+    case 0xf9 | M_0F | P_66 | VEX_128: gen_vpsub_xmm(env, s, modrm, MO_16); 
return;

ERROR: trailing statements should be on next line
#94: FILE: target/i386/translate.c:3341:
+    case 0xf9 | M_0F | P_66 | VEX_128: gen_vpsub_xmm(env, s, modrm, MO_16); 
return;

WARNING: line over 80 characters
#95: FILE: target/i386/translate.c:3342:
+    case 0xf9 | M_0F | P_66 | VEX_256: gen_vpsub_ymm(env, s, modrm, MO_16); 
return;

ERROR: trailing statements should be on next line
#95: FILE: target/i386/translate.c:3342:
+    case 0xf9 | M_0F | P_66 | VEX_256: gen_vpsub_ymm(env, s, modrm, MO_16); 
return;

WARNING: line over 80 characters
#97: FILE: target/i386/translate.c:3344:
+    case 0xfa | M_0F:                  gen_psub_mm(env, s, modrm, MO_32); 
return;

ERROR: trailing statements should be on next line
#97: FILE: target/i386/translate.c:3344:
+    case 0xfa | M_0F:                  gen_psub_mm(env, s, modrm, MO_32); 
return;

WARNING: line over 80 characters
#98: FILE: target/i386/translate.c:3345:
+    case 0xfa | M_0F | P_66:           gen_psub_xmm(env, s, modrm, MO_32); 
return;

ERROR: trailing statements should be on next line
#98: FILE: target/i386/translate.c:3345:
+    case 0xfa | M_0F | P_66:           gen_psub_xmm(env, s, modrm, MO_32); 
return;

WARNING: line over 80 characters
#99: FILE: target/i386/translate.c:3346:
+    case 0xfa | M_0F | P_66 | VEX_128: gen_vpsub_xmm(env, s, modrm, MO_32); 
return;

ERROR: trailing statements should be on next line
#99: FILE: target/i386/translate.c:3346:
+    case 0xfa | M_0F | P_66 | VEX_128: gen_vpsub_xmm(env, s, modrm, MO_32); 
return;

WARNING: line over 80 characters
#100: FILE: target/i386/translate.c:3347:
+    case 0xfa | M_0F | P_66 | VEX_256: gen_vpsub_ymm(env, s, modrm, MO_32); 
return;

ERROR: trailing statements should be on next line
#100: FILE: target/i386/translate.c:3347:
+    case 0xfa | M_0F | P_66 | VEX_256: gen_vpsub_ymm(env, s, modrm, MO_32); 
return;

WARNING: line over 80 characters
#102: FILE: target/i386/translate.c:3349:
+    case 0xfb | M_0F:                  gen_psub_mm(env, s, modrm, MO_64); 
return;

ERROR: trailing statements should be on next line
#102: FILE: target/i386/translate.c:3349:
+    case 0xfb | M_0F:                  gen_psub_mm(env, s, modrm, MO_64); 
return;

WARNING: line over 80 characters
#103: FILE: target/i386/translate.c:3350:
+    case 0xfb | M_0F | P_66:           gen_psub_xmm(env, s, modrm, MO_64); 
return;

ERROR: trailing statements should be on next line
#103: FILE: target/i386/translate.c:3350:
+    case 0xfb | M_0F | P_66:           gen_psub_xmm(env, s, modrm, MO_64); 
return;

WARNING: line over 80 characters
#104: FILE: target/i386/translate.c:3351:
+    case 0xfb | M_0F | P_66 | VEX_128: gen_vpsub_xmm(env, s, modrm, MO_64); 
return;

ERROR: trailing statements should be on next line
#104: FILE: target/i386/translate.c:3351:
+    case 0xfb | M_0F | P_66 | VEX_128: gen_vpsub_xmm(env, s, modrm, MO_64); 
return;

WARNING: line over 80 characters
#105: FILE: target/i386/translate.c:3352:
+    case 0xfb | M_0F | P_66 | VEX_256: gen_vpsub_ymm(env, s, modrm, MO_64); 
return;

ERROR: trailing statements should be on next line
#105: FILE: target/i386/translate.c:3352:
+    case 0xfb | M_0F | P_66 | VEX_256: gen_vpsub_ymm(env, s, modrm, MO_64); 
return;

total: 22 errors, 15 warnings, 80 lines checked

Patch 13/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

14/22 Checking commit 066ed674eeda (target/i386: reimplement (V)PADDS(B, W))
ERROR: line over 90 characters
#74: FILE: target/i386/translate.c:3174:
+#define gen_padds_mm(env, s, modrm, vece)   gen_gvec_ld_modrm_mm  ((env), (s), 
(modrm), (vece), tcg_gen_gvec_ssadd, 0112)

ERROR: space prohibited between function name and open parenthesis '('
#74: FILE: target/i386/translate.c:3174:
+#define gen_padds_mm(env, s, modrm, vece)   gen_gvec_ld_modrm_mm  ((env), (s), 
(modrm), (vece), tcg_gen_gvec_ssadd, 0112)

ERROR: line over 90 characters
#75: FILE: target/i386/translate.c:3175:
+#define gen_padds_xmm(env, s, modrm, vece)  gen_gvec_ld_modrm_xmm ((env), (s), 
(modrm), (vece), tcg_gen_gvec_ssadd, 0112)

ERROR: space prohibited between function name and open parenthesis '('
#75: FILE: target/i386/translate.c:3175:
+#define gen_padds_xmm(env, s, modrm, vece)  gen_gvec_ld_modrm_xmm ((env), (s), 
(modrm), (vece), tcg_gen_gvec_ssadd, 0112)

ERROR: line over 90 characters
#76: FILE: target/i386/translate.c:3176:
+#define gen_vpadds_xmm(env, s, modrm, vece) gen_gvec_ld_modrm_vxmm((env), (s), 
(modrm), (vece), tcg_gen_gvec_ssadd, 0123)

ERROR: line over 90 characters
#77: FILE: target/i386/translate.c:3177:
+#define gen_vpadds_ymm(env, s, modrm, vece) gen_gvec_ld_modrm_vymm((env), (s), 
(modrm), (vece), tcg_gen_gvec_ssadd, 0123)

WARNING: line over 80 characters
#86: FILE: target/i386/translate.c:3339:
+    case 0xec | M_0F:                  gen_padds_mm(env, s, modrm, MO_8); 
return;

ERROR: trailing statements should be on next line
#86: FILE: target/i386/translate.c:3339:
+    case 0xec | M_0F:                  gen_padds_mm(env, s, modrm, MO_8); 
return;

WARNING: line over 80 characters
#87: FILE: target/i386/translate.c:3340:
+    case 0xec | M_0F | P_66:           gen_padds_xmm(env, s, modrm, MO_8); 
return;

ERROR: trailing statements should be on next line
#87: FILE: target/i386/translate.c:3340:
+    case 0xec | M_0F | P_66:           gen_padds_xmm(env, s, modrm, MO_8); 
return;

WARNING: line over 80 characters
#88: FILE: target/i386/translate.c:3341:
+    case 0xec | M_0F | P_66 | VEX_128: gen_vpadds_xmm(env, s, modrm, MO_8); 
return;

ERROR: trailing statements should be on next line
#88: FILE: target/i386/translate.c:3341:
+    case 0xec | M_0F | P_66 | VEX_128: gen_vpadds_xmm(env, s, modrm, MO_8); 
return;

WARNING: line over 80 characters
#89: FILE: target/i386/translate.c:3342:
+    case 0xec | M_0F | P_66 | VEX_256: gen_vpadds_ymm(env, s, modrm, MO_8); 
return;

ERROR: trailing statements should be on next line
#89: FILE: target/i386/translate.c:3342:
+    case 0xec | M_0F | P_66 | VEX_256: gen_vpadds_ymm(env, s, modrm, MO_8); 
return;

WARNING: line over 80 characters
#91: FILE: target/i386/translate.c:3344:
+    case 0xed | M_0F:                  gen_padds_mm(env, s, modrm, MO_16); 
return;

ERROR: trailing statements should be on next line
#91: FILE: target/i386/translate.c:3344:
+    case 0xed | M_0F:                  gen_padds_mm(env, s, modrm, MO_16); 
return;

WARNING: line over 80 characters
#92: FILE: target/i386/translate.c:3345:
+    case 0xed | M_0F | P_66:           gen_padds_xmm(env, s, modrm, MO_16); 
return;

ERROR: trailing statements should be on next line
#92: FILE: target/i386/translate.c:3345:
+    case 0xed | M_0F | P_66:           gen_padds_xmm(env, s, modrm, MO_16); 
return;

WARNING: line over 80 characters
#93: FILE: target/i386/translate.c:3346:
+    case 0xed | M_0F | P_66 | VEX_128: gen_vpadds_xmm(env, s, modrm, MO_16); 
return;

ERROR: trailing statements should be on next line
#93: FILE: target/i386/translate.c:3346:
+    case 0xed | M_0F | P_66 | VEX_128: gen_vpadds_xmm(env, s, modrm, MO_16); 
return;

WARNING: line over 80 characters
#94: FILE: target/i386/translate.c:3347:
+    case 0xed | M_0F | P_66 | VEX_256: gen_vpadds_ymm(env, s, modrm, MO_16); 
return;

ERROR: trailing statements should be on next line
#94: FILE: target/i386/translate.c:3347:
+    case 0xed | M_0F | P_66 | VEX_256: gen_vpadds_ymm(env, s, modrm, MO_16); 
return;

total: 14 errors, 8 warnings, 69 lines checked

Patch 14/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

15/22 Checking commit 76c9dc0f39fe (target/i386: reimplement (V)PADDUS(B, W))
ERROR: line over 90 characters
#73: FILE: target/i386/translate.c:3179:
+#define gen_paddus_mm(env, s, modrm, vece)   gen_gvec_ld_modrm_mm  ((env), 
(s), (modrm), (vece), tcg_gen_gvec_usadd, 0112)

ERROR: space prohibited between function name and open parenthesis '('
#73: FILE: target/i386/translate.c:3179:
+#define gen_paddus_mm(env, s, modrm, vece)   gen_gvec_ld_modrm_mm  ((env), 
(s), (modrm), (vece), tcg_gen_gvec_usadd, 0112)

ERROR: line over 90 characters
#74: FILE: target/i386/translate.c:3180:
+#define gen_paddus_xmm(env, s, modrm, vece)  gen_gvec_ld_modrm_xmm ((env), 
(s), (modrm), (vece), tcg_gen_gvec_usadd, 0112)

ERROR: space prohibited between function name and open parenthesis '('
#74: FILE: target/i386/translate.c:3180:
+#define gen_paddus_xmm(env, s, modrm, vece)  gen_gvec_ld_modrm_xmm ((env), 
(s), (modrm), (vece), tcg_gen_gvec_usadd, 0112)

ERROR: line over 90 characters
#75: FILE: target/i386/translate.c:3181:
+#define gen_vpaddus_xmm(env, s, modrm, vece) gen_gvec_ld_modrm_vxmm((env), 
(s), (modrm), (vece), tcg_gen_gvec_usadd, 0123)

ERROR: line over 90 characters
#76: FILE: target/i386/translate.c:3182:
+#define gen_vpaddus_ymm(env, s, modrm, vece) gen_gvec_ld_modrm_vymm((env), 
(s), (modrm), (vece), tcg_gen_gvec_usadd, 0123)

WARNING: line over 80 characters
#85: FILE: target/i386/translate.c:3344:
+    case 0xdc | M_0F:                  gen_paddus_mm(env, s, modrm, MO_8); 
return;

ERROR: trailing statements should be on next line
#85: FILE: target/i386/translate.c:3344:
+    case 0xdc | M_0F:                  gen_paddus_mm(env, s, modrm, MO_8); 
return;

WARNING: line over 80 characters
#86: FILE: target/i386/translate.c:3345:
+    case 0xdc | M_0F | P_66:           gen_paddus_xmm(env, s, modrm, MO_8); 
return;

ERROR: trailing statements should be on next line
#86: FILE: target/i386/translate.c:3345:
+    case 0xdc | M_0F | P_66:           gen_paddus_xmm(env, s, modrm, MO_8); 
return;

WARNING: line over 80 characters
#87: FILE: target/i386/translate.c:3346:
+    case 0xdc | M_0F | P_66 | VEX_128: gen_vpaddus_xmm(env, s, modrm, MO_8); 
return;

ERROR: trailing statements should be on next line
#87: FILE: target/i386/translate.c:3346:
+    case 0xdc | M_0F | P_66 | VEX_128: gen_vpaddus_xmm(env, s, modrm, MO_8); 
return;

WARNING: line over 80 characters
#88: FILE: target/i386/translate.c:3347:
+    case 0xdc | M_0F | P_66 | VEX_256: gen_vpaddus_ymm(env, s, modrm, MO_8); 
return;

ERROR: trailing statements should be on next line
#88: FILE: target/i386/translate.c:3347:
+    case 0xdc | M_0F | P_66 | VEX_256: gen_vpaddus_ymm(env, s, modrm, MO_8); 
return;

WARNING: line over 80 characters
#90: FILE: target/i386/translate.c:3349:
+    case 0xdd | M_0F:                  gen_paddus_mm(env, s, modrm, MO_16); 
return;

ERROR: trailing statements should be on next line
#90: FILE: target/i386/translate.c:3349:
+    case 0xdd | M_0F:                  gen_paddus_mm(env, s, modrm, MO_16); 
return;

WARNING: line over 80 characters
#91: FILE: target/i386/translate.c:3350:
+    case 0xdd | M_0F | P_66:           gen_paddus_xmm(env, s, modrm, MO_16); 
return;

ERROR: trailing statements should be on next line
#91: FILE: target/i386/translate.c:3350:
+    case 0xdd | M_0F | P_66:           gen_paddus_xmm(env, s, modrm, MO_16); 
return;

WARNING: line over 80 characters
#92: FILE: target/i386/translate.c:3351:
+    case 0xdd | M_0F | P_66 | VEX_128: gen_vpaddus_xmm(env, s, modrm, MO_16); 
return;

ERROR: trailing statements should be on next line
#92: FILE: target/i386/translate.c:3351:
+    case 0xdd | M_0F | P_66 | VEX_128: gen_vpaddus_xmm(env, s, modrm, MO_16); 
return;

WARNING: line over 80 characters
#93: FILE: target/i386/translate.c:3352:
+    case 0xdd | M_0F | P_66 | VEX_256: gen_vpaddus_ymm(env, s, modrm, MO_16); 
return;

ERROR: trailing statements should be on next line
#93: FILE: target/i386/translate.c:3352:
+    case 0xdd | M_0F | P_66 | VEX_256: gen_vpaddus_ymm(env, s, modrm, MO_16); 
return;

total: 14 errors, 8 warnings, 68 lines checked

Patch 15/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

16/22 Checking commit 34accebf3dca (target/i386: reimplement (V)PSUBS(B, W))
ERROR: line over 90 characters
#70: FILE: target/i386/translate.c:3189:
+#define gen_psubs_mm(env, s, modrm, vece)   gen_gvec_ld_modrm_mm  ((env), (s), 
(modrm), (vece), tcg_gen_gvec_sssub, 0112)

ERROR: space prohibited between function name and open parenthesis '('
#70: FILE: target/i386/translate.c:3189:
+#define gen_psubs_mm(env, s, modrm, vece)   gen_gvec_ld_modrm_mm  ((env), (s), 
(modrm), (vece), tcg_gen_gvec_sssub, 0112)

ERROR: line over 90 characters
#71: FILE: target/i386/translate.c:3190:
+#define gen_psubs_xmm(env, s, modrm, vece)  gen_gvec_ld_modrm_xmm ((env), (s), 
(modrm), (vece), tcg_gen_gvec_sssub, 0112)

ERROR: space prohibited between function name and open parenthesis '('
#71: FILE: target/i386/translate.c:3190:
+#define gen_psubs_xmm(env, s, modrm, vece)  gen_gvec_ld_modrm_xmm ((env), (s), 
(modrm), (vece), tcg_gen_gvec_sssub, 0112)

ERROR: line over 90 characters
#72: FILE: target/i386/translate.c:3191:
+#define gen_vpsubs_xmm(env, s, modrm, vece) gen_gvec_ld_modrm_vxmm((env), (s), 
(modrm), (vece), tcg_gen_gvec_sssub, 0123)

ERROR: line over 90 characters
#73: FILE: target/i386/translate.c:3192:
+#define gen_vpsubs_ymm(env, s, modrm, vece) gen_gvec_ld_modrm_vymm((env), (s), 
(modrm), (vece), tcg_gen_gvec_sssub, 0123)

WARNING: line over 80 characters
#82: FILE: target/i386/translate.c:3389:
+    case 0xe8 | M_0F:                  gen_psubs_mm(env, s, modrm, MO_8); 
return;

ERROR: trailing statements should be on next line
#82: FILE: target/i386/translate.c:3389:
+    case 0xe8 | M_0F:                  gen_psubs_mm(env, s, modrm, MO_8); 
return;

WARNING: line over 80 characters
#83: FILE: target/i386/translate.c:3390:
+    case 0xe8 | M_0F | P_66:           gen_psubs_xmm(env, s, modrm, MO_8); 
return;

ERROR: trailing statements should be on next line
#83: FILE: target/i386/translate.c:3390:
+    case 0xe8 | M_0F | P_66:           gen_psubs_xmm(env, s, modrm, MO_8); 
return;

WARNING: line over 80 characters
#84: FILE: target/i386/translate.c:3391:
+    case 0xe8 | M_0F | P_66 | VEX_128: gen_vpsubs_xmm(env, s, modrm, MO_8); 
return;

ERROR: trailing statements should be on next line
#84: FILE: target/i386/translate.c:3391:
+    case 0xe8 | M_0F | P_66 | VEX_128: gen_vpsubs_xmm(env, s, modrm, MO_8); 
return;

WARNING: line over 80 characters
#85: FILE: target/i386/translate.c:3392:
+    case 0xe8 | M_0F | P_66 | VEX_256: gen_vpsubs_ymm(env, s, modrm, MO_8); 
return;

ERROR: trailing statements should be on next line
#85: FILE: target/i386/translate.c:3392:
+    case 0xe8 | M_0F | P_66 | VEX_256: gen_vpsubs_ymm(env, s, modrm, MO_8); 
return;

WARNING: line over 80 characters
#87: FILE: target/i386/translate.c:3394:
+    case 0xe9 | M_0F:                  gen_psubs_mm(env, s, modrm, MO_16); 
return;

ERROR: trailing statements should be on next line
#87: FILE: target/i386/translate.c:3394:
+    case 0xe9 | M_0F:                  gen_psubs_mm(env, s, modrm, MO_16); 
return;

WARNING: line over 80 characters
#88: FILE: target/i386/translate.c:3395:
+    case 0xe9 | M_0F | P_66:           gen_psubs_xmm(env, s, modrm, MO_16); 
return;

ERROR: trailing statements should be on next line
#88: FILE: target/i386/translate.c:3395:
+    case 0xe9 | M_0F | P_66:           gen_psubs_xmm(env, s, modrm, MO_16); 
return;

WARNING: line over 80 characters
#89: FILE: target/i386/translate.c:3396:
+    case 0xe9 | M_0F | P_66 | VEX_128: gen_vpsubs_xmm(env, s, modrm, MO_16); 
return;

ERROR: trailing statements should be on next line
#89: FILE: target/i386/translate.c:3396:
+    case 0xe9 | M_0F | P_66 | VEX_128: gen_vpsubs_xmm(env, s, modrm, MO_16); 
return;

WARNING: line over 80 characters
#90: FILE: target/i386/translate.c:3397:
+    case 0xe9 | M_0F | P_66 | VEX_256: gen_vpsubs_ymm(env, s, modrm, MO_16); 
return;

ERROR: trailing statements should be on next line
#90: FILE: target/i386/translate.c:3397:
+    case 0xe9 | M_0F | P_66 | VEX_256: gen_vpsubs_ymm(env, s, modrm, MO_16); 
return;

total: 14 errors, 8 warnings, 65 lines checked

Patch 16/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

17/22 Checking commit 944c0e98d274 (target/i386: reimplement (V)PSUBUS(B, W))
ERROR: line over 90 characters
#70: FILE: target/i386/translate.c:3194:
+#define gen_psubus_mm(env, s, modrm, vece)   gen_gvec_ld_modrm_mm  ((env), 
(s), (modrm), (vece), tcg_gen_gvec_ussub, 0112)

ERROR: space prohibited between function name and open parenthesis '('
#70: FILE: target/i386/translate.c:3194:
+#define gen_psubus_mm(env, s, modrm, vece)   gen_gvec_ld_modrm_mm  ((env), 
(s), (modrm), (vece), tcg_gen_gvec_ussub, 0112)

ERROR: line over 90 characters
#71: FILE: target/i386/translate.c:3195:
+#define gen_psubus_xmm(env, s, modrm, vece)  gen_gvec_ld_modrm_xmm ((env), 
(s), (modrm), (vece), tcg_gen_gvec_ussub, 0112)

ERROR: space prohibited between function name and open parenthesis '('
#71: FILE: target/i386/translate.c:3195:
+#define gen_psubus_xmm(env, s, modrm, vece)  gen_gvec_ld_modrm_xmm ((env), 
(s), (modrm), (vece), tcg_gen_gvec_ussub, 0112)

ERROR: line over 90 characters
#72: FILE: target/i386/translate.c:3196:
+#define gen_vpsubus_xmm(env, s, modrm, vece) gen_gvec_ld_modrm_vxmm((env), 
(s), (modrm), (vece), tcg_gen_gvec_ussub, 0123)

ERROR: line over 90 characters
#73: FILE: target/i386/translate.c:3197:
+#define gen_vpsubus_ymm(env, s, modrm, vece) gen_gvec_ld_modrm_vymm((env), 
(s), (modrm), (vece), tcg_gen_gvec_ussub, 0123)

WARNING: line over 80 characters
#82: FILE: target/i386/translate.c:3394:
+    case 0xd8 | M_0F:                  gen_psubus_mm(env, s, modrm, MO_8); 
return;

ERROR: trailing statements should be on next line
#82: FILE: target/i386/translate.c:3394:
+    case 0xd8 | M_0F:                  gen_psubus_mm(env, s, modrm, MO_8); 
return;

WARNING: line over 80 characters
#83: FILE: target/i386/translate.c:3395:
+    case 0xd8 | M_0F | P_66:           gen_psubus_xmm(env, s, modrm, MO_8); 
return;

ERROR: trailing statements should be on next line
#83: FILE: target/i386/translate.c:3395:
+    case 0xd8 | M_0F | P_66:           gen_psubus_xmm(env, s, modrm, MO_8); 
return;

WARNING: line over 80 characters
#84: FILE: target/i386/translate.c:3396:
+    case 0xd8 | M_0F | P_66 | VEX_128: gen_vpsubus_xmm(env, s, modrm, MO_8); 
return;

ERROR: trailing statements should be on next line
#84: FILE: target/i386/translate.c:3396:
+    case 0xd8 | M_0F | P_66 | VEX_128: gen_vpsubus_xmm(env, s, modrm, MO_8); 
return;

WARNING: line over 80 characters
#85: FILE: target/i386/translate.c:3397:
+    case 0xd8 | M_0F | P_66 | VEX_256: gen_vpsubus_ymm(env, s, modrm, MO_8); 
return;

ERROR: trailing statements should be on next line
#85: FILE: target/i386/translate.c:3397:
+    case 0xd8 | M_0F | P_66 | VEX_256: gen_vpsubus_ymm(env, s, modrm, MO_8); 
return;

WARNING: line over 80 characters
#87: FILE: target/i386/translate.c:3399:
+    case 0xd9 | M_0F:                  gen_psubus_mm(env, s, modrm, MO_16); 
return;

ERROR: trailing statements should be on next line
#87: FILE: target/i386/translate.c:3399:
+    case 0xd9 | M_0F:                  gen_psubus_mm(env, s, modrm, MO_16); 
return;

WARNING: line over 80 characters
#88: FILE: target/i386/translate.c:3400:
+    case 0xd9 | M_0F | P_66:           gen_psubus_xmm(env, s, modrm, MO_16); 
return;

ERROR: trailing statements should be on next line
#88: FILE: target/i386/translate.c:3400:
+    case 0xd9 | M_0F | P_66:           gen_psubus_xmm(env, s, modrm, MO_16); 
return;

WARNING: line over 80 characters
#89: FILE: target/i386/translate.c:3401:
+    case 0xd9 | M_0F | P_66 | VEX_128: gen_vpsubus_xmm(env, s, modrm, MO_16); 
return;

ERROR: trailing statements should be on next line
#89: FILE: target/i386/translate.c:3401:
+    case 0xd9 | M_0F | P_66 | VEX_128: gen_vpsubus_xmm(env, s, modrm, MO_16); 
return;

WARNING: line over 80 characters
#90: FILE: target/i386/translate.c:3402:
+    case 0xd9 | M_0F | P_66 | VEX_256: gen_vpsubus_ymm(env, s, modrm, MO_16); 
return;

ERROR: trailing statements should be on next line
#90: FILE: target/i386/translate.c:3402:
+    case 0xd9 | M_0F | P_66 | VEX_256: gen_vpsubus_ymm(env, s, modrm, MO_16); 
return;

total: 14 errors, 8 warnings, 65 lines checked

Patch 17/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

18/22 Checking commit 121c2e52e8f8 (target/i386: reimplement (V)PMINSW)
ERROR: line over 90 characters
#61: FILE: target/i386/translate.c:3199:
+#define gen_pmins_mm(env, s, modrm, vece)   gen_gvec_ld_modrm_mm  ((env), (s), 
(modrm), (vece), tcg_gen_gvec_smin, 0112)

ERROR: space prohibited between function name and open parenthesis '('
#61: FILE: target/i386/translate.c:3199:
+#define gen_pmins_mm(env, s, modrm, vece)   gen_gvec_ld_modrm_mm  ((env), (s), 
(modrm), (vece), tcg_gen_gvec_smin, 0112)

ERROR: line over 90 characters
#62: FILE: target/i386/translate.c:3200:
+#define gen_pmins_xmm(env, s, modrm, vece)  gen_gvec_ld_modrm_xmm ((env), (s), 
(modrm), (vece), tcg_gen_gvec_smin, 0112)

ERROR: space prohibited between function name and open parenthesis '('
#62: FILE: target/i386/translate.c:3200:
+#define gen_pmins_xmm(env, s, modrm, vece)  gen_gvec_ld_modrm_xmm ((env), (s), 
(modrm), (vece), tcg_gen_gvec_smin, 0112)

ERROR: line over 90 characters
#63: FILE: target/i386/translate.c:3201:
+#define gen_vpmins_xmm(env, s, modrm, vece) gen_gvec_ld_modrm_vxmm((env), (s), 
(modrm), (vece), tcg_gen_gvec_smin, 0123)

ERROR: line over 90 characters
#64: FILE: target/i386/translate.c:3202:
+#define gen_vpmins_ymm(env, s, modrm, vece) gen_gvec_ld_modrm_vymm((env), (s), 
(modrm), (vece), tcg_gen_gvec_smin, 0123)

WARNING: line over 80 characters
#73: FILE: target/i386/translate.c:3419:
+    case 0xea | M_0F:                  gen_pmins_mm(env, s, modrm, MO_16); 
return;

ERROR: trailing statements should be on next line
#73: FILE: target/i386/translate.c:3419:
+    case 0xea | M_0F:                  gen_pmins_mm(env, s, modrm, MO_16); 
return;

WARNING: line over 80 characters
#74: FILE: target/i386/translate.c:3420:
+    case 0xea | M_0F | P_66:           gen_pmins_xmm(env, s, modrm, MO_16); 
return;

ERROR: trailing statements should be on next line
#74: FILE: target/i386/translate.c:3420:
+    case 0xea | M_0F | P_66:           gen_pmins_xmm(env, s, modrm, MO_16); 
return;

WARNING: line over 80 characters
#75: FILE: target/i386/translate.c:3421:
+    case 0xea | M_0F | P_66 | VEX_128: gen_vpmins_xmm(env, s, modrm, MO_16); 
return;

ERROR: trailing statements should be on next line
#75: FILE: target/i386/translate.c:3421:
+    case 0xea | M_0F | P_66 | VEX_128: gen_vpmins_xmm(env, s, modrm, MO_16); 
return;

WARNING: line over 80 characters
#76: FILE: target/i386/translate.c:3422:
+    case 0xea | M_0F | P_66 | VEX_256: gen_vpmins_ymm(env, s, modrm, MO_16); 
return;

ERROR: trailing statements should be on next line
#76: FILE: target/i386/translate.c:3422:
+    case 0xea | M_0F | P_66 | VEX_256: gen_vpmins_ymm(env, s, modrm, MO_16); 
return;

total: 10 errors, 4 warnings, 51 lines checked

Patch 18/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

19/22 Checking commit 3062bca41336 (target/i386: reimplement (V)PMINUB)
ERROR: line over 90 characters
#61: FILE: target/i386/translate.c:3204:
+#define gen_pminu_mm(env, s, modrm, vece)   gen_gvec_ld_modrm_mm  ((env), (s), 
(modrm), (vece), tcg_gen_gvec_umin, 0112)

ERROR: space prohibited between function name and open parenthesis '('
#61: FILE: target/i386/translate.c:3204:
+#define gen_pminu_mm(env, s, modrm, vece)   gen_gvec_ld_modrm_mm  ((env), (s), 
(modrm), (vece), tcg_gen_gvec_umin, 0112)

ERROR: line over 90 characters
#62: FILE: target/i386/translate.c:3205:
+#define gen_pminu_xmm(env, s, modrm, vece)  gen_gvec_ld_modrm_xmm ((env), (s), 
(modrm), (vece), tcg_gen_gvec_umin, 0112)

ERROR: space prohibited between function name and open parenthesis '('
#62: FILE: target/i386/translate.c:3205:
+#define gen_pminu_xmm(env, s, modrm, vece)  gen_gvec_ld_modrm_xmm ((env), (s), 
(modrm), (vece), tcg_gen_gvec_umin, 0112)

ERROR: line over 90 characters
#63: FILE: target/i386/translate.c:3206:
+#define gen_vpminu_xmm(env, s, modrm, vece) gen_gvec_ld_modrm_vxmm((env), (s), 
(modrm), (vece), tcg_gen_gvec_umin, 0123)

ERROR: line over 90 characters
#64: FILE: target/i386/translate.c:3207:
+#define gen_vpminu_ymm(env, s, modrm, vece) gen_gvec_ld_modrm_vymm((env), (s), 
(modrm), (vece), tcg_gen_gvec_umin, 0123)

WARNING: line over 80 characters
#73: FILE: target/i386/translate.c:3424:
+    case 0xda | M_0F:                  gen_pminu_mm(env, s, modrm, MO_8); 
return;

ERROR: trailing statements should be on next line
#73: FILE: target/i386/translate.c:3424:
+    case 0xda | M_0F:                  gen_pminu_mm(env, s, modrm, MO_8); 
return;

WARNING: line over 80 characters
#74: FILE: target/i386/translate.c:3425:
+    case 0xda | M_0F | P_66:           gen_pminu_xmm(env, s, modrm, MO_8); 
return;

ERROR: trailing statements should be on next line
#74: FILE: target/i386/translate.c:3425:
+    case 0xda | M_0F | P_66:           gen_pminu_xmm(env, s, modrm, MO_8); 
return;

WARNING: line over 80 characters
#75: FILE: target/i386/translate.c:3426:
+    case 0xda | M_0F | P_66 | VEX_128: gen_vpminu_xmm(env, s, modrm, MO_8); 
return;

ERROR: trailing statements should be on next line
#75: FILE: target/i386/translate.c:3426:
+    case 0xda | M_0F | P_66 | VEX_128: gen_vpminu_xmm(env, s, modrm, MO_8); 
return;

WARNING: line over 80 characters
#76: FILE: target/i386/translate.c:3427:
+    case 0xda | M_0F | P_66 | VEX_256: gen_vpminu_ymm(env, s, modrm, MO_8); 
return;

ERROR: trailing statements should be on next line
#76: FILE: target/i386/translate.c:3427:
+    case 0xda | M_0F | P_66 | VEX_256: gen_vpminu_ymm(env, s, modrm, MO_8); 
return;

total: 10 errors, 4 warnings, 51 lines checked

Patch 19/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

20/22 Checking commit dfde70d5c7bd (target/i386: reimplement (V)PMAXSW)
ERROR: line over 90 characters
#63: FILE: target/i386/translate.c:3209:
+#define gen_pmaxs_mm(env, s, modrm, vece)   gen_gvec_ld_modrm_mm  ((env), (s), 
(modrm), (vece), tcg_gen_gvec_smax, 0112)

ERROR: space prohibited between function name and open parenthesis '('
#63: FILE: target/i386/translate.c:3209:
+#define gen_pmaxs_mm(env, s, modrm, vece)   gen_gvec_ld_modrm_mm  ((env), (s), 
(modrm), (vece), tcg_gen_gvec_smax, 0112)

ERROR: line over 90 characters
#64: FILE: target/i386/translate.c:3210:
+#define gen_pmaxs_xmm(env, s, modrm, vece)  gen_gvec_ld_modrm_xmm ((env), (s), 
(modrm), (vece), tcg_gen_gvec_smax, 0112)

ERROR: space prohibited between function name and open parenthesis '('
#64: FILE: target/i386/translate.c:3210:
+#define gen_pmaxs_xmm(env, s, modrm, vece)  gen_gvec_ld_modrm_xmm ((env), (s), 
(modrm), (vece), tcg_gen_gvec_smax, 0112)

ERROR: line over 90 characters
#65: FILE: target/i386/translate.c:3211:
+#define gen_vpmaxs_xmm(env, s, modrm, vece) gen_gvec_ld_modrm_vxmm((env), (s), 
(modrm), (vece), tcg_gen_gvec_smax, 0123)

ERROR: line over 90 characters
#66: FILE: target/i386/translate.c:3212:
+#define gen_vpmaxs_ymm(env, s, modrm, vece) gen_gvec_ld_modrm_vymm((env), (s), 
(modrm), (vece), tcg_gen_gvec_smax, 0123)

WARNING: line over 80 characters
#75: FILE: target/i386/translate.c:3439:
+    case 0xee | M_0F:                  gen_pmaxs_mm(env, s, modrm, MO_16); 
return;

ERROR: trailing statements should be on next line
#75: FILE: target/i386/translate.c:3439:
+    case 0xee | M_0F:                  gen_pmaxs_mm(env, s, modrm, MO_16); 
return;

WARNING: line over 80 characters
#76: FILE: target/i386/translate.c:3440:
+    case 0xee | M_0F | P_66:           gen_pmaxs_xmm(env, s, modrm, MO_16); 
return;

ERROR: trailing statements should be on next line
#76: FILE: target/i386/translate.c:3440:
+    case 0xee | M_0F | P_66:           gen_pmaxs_xmm(env, s, modrm, MO_16); 
return;

WARNING: line over 80 characters
#77: FILE: target/i386/translate.c:3441:
+    case 0xee | M_0F | P_66 | VEX_128: gen_vpmaxs_xmm(env, s, modrm, MO_16); 
return;

ERROR: trailing statements should be on next line
#77: FILE: target/i386/translate.c:3441:
+    case 0xee | M_0F | P_66 | VEX_128: gen_vpmaxs_xmm(env, s, modrm, MO_16); 
return;

WARNING: line over 80 characters
#78: FILE: target/i386/translate.c:3442:
+    case 0xee | M_0F | P_66 | VEX_256: gen_vpmaxs_ymm(env, s, modrm, MO_16); 
return;

ERROR: trailing statements should be on next line
#78: FILE: target/i386/translate.c:3442:
+    case 0xee | M_0F | P_66 | VEX_256: gen_vpmaxs_ymm(env, s, modrm, MO_16); 
return;

total: 10 errors, 4 warnings, 53 lines checked

Patch 20/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

21/22 Checking commit 4c83ed32e8ad (target/i386: reimplement (V)PMAXUB)
ERROR: line over 90 characters
#64: FILE: target/i386/translate.c:3214:
+#define gen_pmaxu_mm(env, s, modrm, vece)   gen_gvec_ld_modrm_mm  ((env), (s), 
(modrm), (vece), tcg_gen_gvec_umax, 0112)

ERROR: space prohibited between function name and open parenthesis '('
#64: FILE: target/i386/translate.c:3214:
+#define gen_pmaxu_mm(env, s, modrm, vece)   gen_gvec_ld_modrm_mm  ((env), (s), 
(modrm), (vece), tcg_gen_gvec_umax, 0112)

ERROR: line over 90 characters
#65: FILE: target/i386/translate.c:3215:
+#define gen_pmaxu_xmm(env, s, modrm, vece)  gen_gvec_ld_modrm_xmm ((env), (s), 
(modrm), (vece), tcg_gen_gvec_umax, 0112)

ERROR: space prohibited between function name and open parenthesis '('
#65: FILE: target/i386/translate.c:3215:
+#define gen_pmaxu_xmm(env, s, modrm, vece)  gen_gvec_ld_modrm_xmm ((env), (s), 
(modrm), (vece), tcg_gen_gvec_umax, 0112)

ERROR: line over 90 characters
#66: FILE: target/i386/translate.c:3216:
+#define gen_vpmaxu_xmm(env, s, modrm, vece) gen_gvec_ld_modrm_vxmm((env), (s), 
(modrm), (vece), tcg_gen_gvec_umax, 0123)

ERROR: line over 90 characters
#67: FILE: target/i386/translate.c:3217:
+#define gen_vpmaxu_ymm(env, s, modrm, vece) gen_gvec_ld_modrm_vymm((env), (s), 
(modrm), (vece), tcg_gen_gvec_umax, 0123)

WARNING: line over 80 characters
#76: FILE: target/i386/translate.c:3444:
+    case 0xde | M_0F:                  gen_pmaxu_mm(env, s, modrm, MO_8); 
return;

ERROR: trailing statements should be on next line
#76: FILE: target/i386/translate.c:3444:
+    case 0xde | M_0F:                  gen_pmaxu_mm(env, s, modrm, MO_8); 
return;

WARNING: line over 80 characters
#77: FILE: target/i386/translate.c:3445:
+    case 0xde | M_0F | P_66:           gen_pmaxu_xmm(env, s, modrm, MO_8); 
return;

ERROR: trailing statements should be on next line
#77: FILE: target/i386/translate.c:3445:
+    case 0xde | M_0F | P_66:           gen_pmaxu_xmm(env, s, modrm, MO_8); 
return;

WARNING: line over 80 characters
#78: FILE: target/i386/translate.c:3446:
+    case 0xde | M_0F | P_66 | VEX_128: gen_vpmaxu_xmm(env, s, modrm, MO_8); 
return;

ERROR: trailing statements should be on next line
#78: FILE: target/i386/translate.c:3446:
+    case 0xde | M_0F | P_66 | VEX_128: gen_vpmaxu_xmm(env, s, modrm, MO_8); 
return;

WARNING: line over 80 characters
#79: FILE: target/i386/translate.c:3447:
+    case 0xde | M_0F | P_66 | VEX_256: gen_vpmaxu_ymm(env, s, modrm, MO_8); 
return;

ERROR: trailing statements should be on next line
#79: FILE: target/i386/translate.c:3447:
+    case 0xde | M_0F | P_66 | VEX_256: gen_vpmaxu_ymm(env, s, modrm, MO_8); 
return;

total: 10 errors, 4 warnings, 54 lines checked

Patch 21/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

22/22 Checking commit e2438c48fcd1 (target/i386: reimplement (V)P(EQ, CMP)(B, 
W, D))
ERROR: line over 90 characters
#103: FILE: target/i386/translate.c:3226:
+#define gen_pcmpeq_mm(env, s, modrm, vece)   gen_gvec_ld_modrm_mm  ((env), 
(s), (modrm), (vece), gen_gvec_cmpeq, 0112)

ERROR: space prohibited between function name and open parenthesis '('
#103: FILE: target/i386/translate.c:3226:
+#define gen_pcmpeq_mm(env, s, modrm, vece)   gen_gvec_ld_modrm_mm  ((env), 
(s), (modrm), (vece), gen_gvec_cmpeq, 0112)

ERROR: line over 90 characters
#104: FILE: target/i386/translate.c:3227:
+#define gen_pcmpeq_xmm(env, s, modrm, vece)  gen_gvec_ld_modrm_xmm ((env), 
(s), (modrm), (vece), gen_gvec_cmpeq, 0112)

ERROR: space prohibited between function name and open parenthesis '('
#104: FILE: target/i386/translate.c:3227:
+#define gen_pcmpeq_xmm(env, s, modrm, vece)  gen_gvec_ld_modrm_xmm ((env), 
(s), (modrm), (vece), gen_gvec_cmpeq, 0112)

ERROR: line over 90 characters
#105: FILE: target/i386/translate.c:3228:
+#define gen_vpcmpeq_xmm(env, s, modrm, vece) gen_gvec_ld_modrm_vxmm((env), 
(s), (modrm), (vece), gen_gvec_cmpeq, 0123)

ERROR: line over 90 characters
#106: FILE: target/i386/translate.c:3229:
+#define gen_vpcmpeq_ymm(env, s, modrm, vece) gen_gvec_ld_modrm_vymm((env), 
(s), (modrm), (vece), gen_gvec_cmpeq, 0123)

ERROR: line over 90 characters
#115: FILE: target/i386/translate.c:3238:
+#define gen_pcmpgt_mm(env, s, modrm, vece)   gen_gvec_ld_modrm_mm  ((env), 
(s), (modrm), (vece), gen_gvec_cmpgt, 0112)

ERROR: space prohibited between function name and open parenthesis '('
#115: FILE: target/i386/translate.c:3238:
+#define gen_pcmpgt_mm(env, s, modrm, vece)   gen_gvec_ld_modrm_mm  ((env), 
(s), (modrm), (vece), gen_gvec_cmpgt, 0112)

ERROR: line over 90 characters
#116: FILE: target/i386/translate.c:3239:
+#define gen_pcmpgt_xmm(env, s, modrm, vece)  gen_gvec_ld_modrm_xmm ((env), 
(s), (modrm), (vece), gen_gvec_cmpgt, 0112)

ERROR: space prohibited between function name and open parenthesis '('
#116: FILE: target/i386/translate.c:3239:
+#define gen_pcmpgt_xmm(env, s, modrm, vece)  gen_gvec_ld_modrm_xmm ((env), 
(s), (modrm), (vece), gen_gvec_cmpgt, 0112)

ERROR: line over 90 characters
#117: FILE: target/i386/translate.c:3240:
+#define gen_vpcmpgt_xmm(env, s, modrm, vece) gen_gvec_ld_modrm_vxmm((env), 
(s), (modrm), (vece), gen_gvec_cmpgt, 0123)

ERROR: line over 90 characters
#118: FILE: target/i386/translate.c:3241:
+#define gen_vpcmpgt_ymm(env, s, modrm, vece) gen_gvec_ld_modrm_vymm((env), 
(s), (modrm), (vece), gen_gvec_cmpgt, 0123)

WARNING: line over 80 characters
#127: FILE: target/i386/translate.c:3478:
+    case 0x64 | M_0F:                  gen_pcmpgt_mm(env, s, modrm, MO_8); 
return;

ERROR: trailing statements should be on next line
#127: FILE: target/i386/translate.c:3478:
+    case 0x64 | M_0F:                  gen_pcmpgt_mm(env, s, modrm, MO_8); 
return;

WARNING: line over 80 characters
#128: FILE: target/i386/translate.c:3479:
+    case 0x64 | M_0F | P_66:           gen_pcmpgt_xmm(env, s, modrm, MO_8); 
return;

ERROR: trailing statements should be on next line
#128: FILE: target/i386/translate.c:3479:
+    case 0x64 | M_0F | P_66:           gen_pcmpgt_xmm(env, s, modrm, MO_8); 
return;

WARNING: line over 80 characters
#129: FILE: target/i386/translate.c:3480:
+    case 0x64 | M_0F | P_66 | VEX_128: gen_vpcmpgt_xmm(env, s, modrm, MO_8); 
return;

ERROR: trailing statements should be on next line
#129: FILE: target/i386/translate.c:3480:
+    case 0x64 | M_0F | P_66 | VEX_128: gen_vpcmpgt_xmm(env, s, modrm, MO_8); 
return;

WARNING: line over 80 characters
#130: FILE: target/i386/translate.c:3481:
+    case 0x64 | M_0F | P_66 | VEX_256: gen_vpcmpgt_ymm(env, s, modrm, MO_8); 
return;

ERROR: trailing statements should be on next line
#130: FILE: target/i386/translate.c:3481:
+    case 0x64 | M_0F | P_66 | VEX_256: gen_vpcmpgt_ymm(env, s, modrm, MO_8); 
return;

WARNING: line over 80 characters
#132: FILE: target/i386/translate.c:3483:
+    case 0x65 | M_0F:                  gen_pcmpgt_mm(env, s, modrm, MO_16); 
return;

ERROR: trailing statements should be on next line
#132: FILE: target/i386/translate.c:3483:
+    case 0x65 | M_0F:                  gen_pcmpgt_mm(env, s, modrm, MO_16); 
return;

WARNING: line over 80 characters
#133: FILE: target/i386/translate.c:3484:
+    case 0x65 | M_0F | P_66:           gen_pcmpgt_xmm(env, s, modrm, MO_16); 
return;

ERROR: trailing statements should be on next line
#133: FILE: target/i386/translate.c:3484:
+    case 0x65 | M_0F | P_66:           gen_pcmpgt_xmm(env, s, modrm, MO_16); 
return;

WARNING: line over 80 characters
#134: FILE: target/i386/translate.c:3485:
+    case 0x65 | M_0F | P_66 | VEX_128: gen_vpcmpgt_xmm(env, s, modrm, MO_16); 
return;

ERROR: trailing statements should be on next line
#134: FILE: target/i386/translate.c:3485:
+    case 0x65 | M_0F | P_66 | VEX_128: gen_vpcmpgt_xmm(env, s, modrm, MO_16); 
return;

WARNING: line over 80 characters
#135: FILE: target/i386/translate.c:3486:
+    case 0x65 | M_0F | P_66 | VEX_256: gen_vpcmpgt_ymm(env, s, modrm, MO_16); 
return;

ERROR: trailing statements should be on next line
#135: FILE: target/i386/translate.c:3486:
+    case 0x65 | M_0F | P_66 | VEX_256: gen_vpcmpgt_ymm(env, s, modrm, MO_16); 
return;

WARNING: line over 80 characters
#137: FILE: target/i386/translate.c:3488:
+    case 0x66 | M_0F:                  gen_pcmpgt_mm(env, s, modrm, MO_32); 
return;

ERROR: trailing statements should be on next line
#137: FILE: target/i386/translate.c:3488:
+    case 0x66 | M_0F:                  gen_pcmpgt_mm(env, s, modrm, MO_32); 
return;

WARNING: line over 80 characters
#138: FILE: target/i386/translate.c:3489:
+    case 0x66 | M_0F | P_66:           gen_pcmpgt_xmm(env, s, modrm, MO_32); 
return;

ERROR: trailing statements should be on next line
#138: FILE: target/i386/translate.c:3489:
+    case 0x66 | M_0F | P_66:           gen_pcmpgt_xmm(env, s, modrm, MO_32); 
return;

WARNING: line over 80 characters
#139: FILE: target/i386/translate.c:3490:
+    case 0x66 | M_0F | P_66 | VEX_128: gen_vpcmpgt_xmm(env, s, modrm, MO_32); 
return;

ERROR: trailing statements should be on next line
#139: FILE: target/i386/translate.c:3490:
+    case 0x66 | M_0F | P_66 | VEX_128: gen_vpcmpgt_xmm(env, s, modrm, MO_32); 
return;

WARNING: line over 80 characters
#140: FILE: target/i386/translate.c:3491:
+    case 0x66 | M_0F | P_66 | VEX_256: gen_vpcmpgt_ymm(env, s, modrm, MO_32); 
return;

ERROR: trailing statements should be on next line
#140: FILE: target/i386/translate.c:3491:
+    case 0x66 | M_0F | P_66 | VEX_256: gen_vpcmpgt_ymm(env, s, modrm, MO_32); 
return;

WARNING: line over 80 characters
#142: FILE: target/i386/translate.c:3493:
+    case 0x74 | M_0F:                  gen_pcmpeq_mm(env, s, modrm, MO_8); 
return;

ERROR: trailing statements should be on next line
#142: FILE: target/i386/translate.c:3493:
+    case 0x74 | M_0F:                  gen_pcmpeq_mm(env, s, modrm, MO_8); 
return;

WARNING: line over 80 characters
#143: FILE: target/i386/translate.c:3494:
+    case 0x74 | M_0F | P_66:           gen_pcmpeq_xmm(env, s, modrm, MO_8); 
return;

ERROR: trailing statements should be on next line
#143: FILE: target/i386/translate.c:3494:
+    case 0x74 | M_0F | P_66:           gen_pcmpeq_xmm(env, s, modrm, MO_8); 
return;

WARNING: line over 80 characters
#144: FILE: target/i386/translate.c:3495:
+    case 0x74 | M_0F | P_66 | VEX_128: gen_vpcmpeq_xmm(env, s, modrm, MO_8); 
return;

ERROR: trailing statements should be on next line
#144: FILE: target/i386/translate.c:3495:
+    case 0x74 | M_0F | P_66 | VEX_128: gen_vpcmpeq_xmm(env, s, modrm, MO_8); 
return;

WARNING: line over 80 characters
#145: FILE: target/i386/translate.c:3496:
+    case 0x74 | M_0F | P_66 | VEX_256: gen_vpcmpeq_ymm(env, s, modrm, MO_8); 
return;

ERROR: trailing statements should be on next line
#145: FILE: target/i386/translate.c:3496:
+    case 0x74 | M_0F | P_66 | VEX_256: gen_vpcmpeq_ymm(env, s, modrm, MO_8); 
return;

WARNING: line over 80 characters
#147: FILE: target/i386/translate.c:3498:
+    case 0x75 | M_0F:                  gen_pcmpeq_mm(env, s, modrm, MO_16); 
return;

ERROR: trailing statements should be on next line
#147: FILE: target/i386/translate.c:3498:
+    case 0x75 | M_0F:                  gen_pcmpeq_mm(env, s, modrm, MO_16); 
return;

WARNING: line over 80 characters
#148: FILE: target/i386/translate.c:3499:
+    case 0x75 | M_0F | P_66:           gen_pcmpeq_xmm(env, s, modrm, MO_16); 
return;

ERROR: trailing statements should be on next line
#148: FILE: target/i386/translate.c:3499:
+    case 0x75 | M_0F | P_66:           gen_pcmpeq_xmm(env, s, modrm, MO_16); 
return;

WARNING: line over 80 characters
#149: FILE: target/i386/translate.c:3500:
+    case 0x75 | M_0F | P_66 | VEX_128: gen_vpcmpeq_xmm(env, s, modrm, MO_16); 
return;

ERROR: trailing statements should be on next line
#149: FILE: target/i386/translate.c:3500:
+    case 0x75 | M_0F | P_66 | VEX_128: gen_vpcmpeq_xmm(env, s, modrm, MO_16); 
return;

WARNING: line over 80 characters
#150: FILE: target/i386/translate.c:3501:
+    case 0x75 | M_0F | P_66 | VEX_256: gen_vpcmpeq_ymm(env, s, modrm, MO_16); 
return;

ERROR: trailing statements should be on next line
#150: FILE: target/i386/translate.c:3501:
+    case 0x75 | M_0F | P_66 | VEX_256: gen_vpcmpeq_ymm(env, s, modrm, MO_16); 
return;

WARNING: line over 80 characters
#152: FILE: target/i386/translate.c:3503:
+    case 0x76 | M_0F:                  gen_pcmpeq_mm(env, s, modrm, MO_32); 
return;

ERROR: trailing statements should be on next line
#152: FILE: target/i386/translate.c:3503:
+    case 0x76 | M_0F:                  gen_pcmpeq_mm(env, s, modrm, MO_32); 
return;

WARNING: line over 80 characters
#153: FILE: target/i386/translate.c:3504:
+    case 0x76 | M_0F | P_66:           gen_pcmpeq_xmm(env, s, modrm, MO_32); 
return;

ERROR: trailing statements should be on next line
#153: FILE: target/i386/translate.c:3504:
+    case 0x76 | M_0F | P_66:           gen_pcmpeq_xmm(env, s, modrm, MO_32); 
return;

WARNING: line over 80 characters
#154: FILE: target/i386/translate.c:3505:
+    case 0x76 | M_0F | P_66 | VEX_128: gen_vpcmpeq_xmm(env, s, modrm, MO_32); 
return;

ERROR: trailing statements should be on next line
#154: FILE: target/i386/translate.c:3505:
+    case 0x76 | M_0F | P_66 | VEX_128: gen_vpcmpeq_xmm(env, s, modrm, MO_32); 
return;

WARNING: line over 80 characters
#155: FILE: target/i386/translate.c:3506:
+    case 0x76 | M_0F | P_66 | VEX_256: gen_vpcmpeq_ymm(env, s, modrm, MO_32); 
return;

ERROR: trailing statements should be on next line
#155: FILE: target/i386/translate.c:3506:
+    case 0x76 | M_0F | P_66 | VEX_256: gen_vpcmpeq_ymm(env, s, modrm, MO_32); 
return;

total: 36 errors, 24 warnings, 129 lines checked

Patch 22/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden
[Prev in Thread]
Current Thread
[Next in Thread]
[Qemu-devel] [RFC PATCH v1 18/22] target/i386: reimplement (V)PMINSW, (continued)
- [Qemu-devel] [RFC PATCH v1 18/22] target/i386: reimplement (V)PMINSW, Jan Bobek, 2019/07/31
- [Qemu-devel] [RFC PATCH v1 19/22] target/i386: reimplement (V)PMINUB, Jan Bobek, 2019/07/31
- [Qemu-devel] [RFC PATCH v1 20/22] target/i386: reimplement (V)PMAXSW, Jan Bobek, 2019/07/31
- [Qemu-devel] [RFC PATCH v1 21/22] target/i386: reimplement (V)PMAXUB, Jan Bobek, 2019/07/31
- [Qemu-devel] [RFC PATCH v1 16/22] target/i386: reimplement (V)PSUBS(B, W), Jan Bobek, 2019/07/31
- [Qemu-devel] [RFC PATCH v1 22/22] target/i386: reimplement (V)P(EQ, CMP)(B, W, D), Jan Bobek, 2019/07/31
  - Re: [Qemu-devel] [RFC PATCH v1 22/22] target/i386: reimplement (V)P(EQ, CMP)(B, W, D), Richard Henderson, 2019/07/31
    - Re: [Qemu-devel] [RFC PATCH v1 22/22] target/i386: reimplement (V)P(EQ, CMP)(B, W, D), Aleksandar Markovic, 2019/07/31
    - Re: [Qemu-devel] [RFC PATCH v1 22/22] target/i386: reimplement (V)P(EQ, CMP)(B, W, D), Richard Henderson, 2019/07/31
- Re: [Qemu-devel] [RFC PATCH v1 00/22] reimplement (some) x86 vector instructions using tcg-gvec, no-reply, 2019/07/31
- Re: [Qemu-devel] [RFC PATCH v1 00/22] reimplement (some) x86 vector instructions using tcg-gvec, no-reply <=
- Re: [Qemu-devel] [RFC PATCH v1 00/22] reimplement (some) x86 vector instructions using tcg-gvec, no-reply, 2019/07/31
Prev by Date: Re: [Qemu-devel] [PATCH v5 1/5] 9p: unsigned type for type, version, path
Next by Date: Re: [Qemu-devel] [RFC PATCH v1 00/22] reimplement (some) x86 vector instructions using tcg-gvec
Previous by thread: Re: [Qemu-devel] [RFC PATCH v1 00/22] reimplement (some) x86 vector instructions using tcg-gvec
Next by thread: Re: [Qemu-devel] [RFC PATCH v1 00/22] reimplement (some) x86 vector instructions using tcg-gvec
Index(es):
- Date
- Thread