Re: [Qemu-devel] [PATCH 4/7] target/sparc: Correctly handle bus errors in page table walks

[Richard Henderson]

On 8/1/19 11:30 AM, Peter Maydell wrote:
> Currently we use the ldl_phys() function to read page table entries.
> With the unassigned_access hook in place, if these hit an unassigned
> area of memory then the hook will cause us to wrongly generate
> an exception with a fault address matching the address of the
> page table entry.
> 
> Change to using address_space_ldl() so we can detect and correctly
> handle bus errors and give them their correct behaviour of
> causing a translation error with a suitable fault status register.
> 
> Note that this won't actually take effect until we switch the
> over to using the do_translation_failed hook.
> 
> Signed-off-by: Peter Maydell <address@hidden>
> ---
>  target/sparc/mmu_helper.c | 24 ++++++++++++++++++++----
>  1 file changed, 20 insertions(+), 4 deletions(-)

Reviewed-by: Richard Henderson <address@hidden>


r~